public override void Bad(HttpRequest req, HttpResponse resp) { int data; data = int.MinValue; /* initialize data in case id is not in query string */ /* POTENTIAL FLAW: Parse id param out of the URL querystring (without using getParam) */ { if (req.QueryString["id"] != null) { try { data = int.Parse(req.QueryString["id"]); } catch (FormatException exceptNumberFormat) { IO.Logger.Log(NLog.LogLevel.Warn, exceptNumberFormat, "Number format exception reading id from query string"); } } } Hashtable dataHashtable = new Hashtable(5); dataHashtable.Add(0, data); dataHashtable.Add(1, data); dataHashtable.Add(2, data); CWE789_Uncontrolled_Mem_Alloc__QueryString_Web_HashSet_72b.BadSink(dataHashtable, req, resp); }
/* goodG2B() - use goodsource and badsink */ private static void GoodG2B(HttpRequest req, HttpResponse resp) { int data; /* FIX: Use a hardcoded number that won't cause underflow, overflow, divide by zero, or loss-of-precision issues */ data = 2; Hashtable dataHashtable = new Hashtable(5); dataHashtable.Add(0, data); dataHashtable.Add(1, data); dataHashtable.Add(2, data); CWE789_Uncontrolled_Mem_Alloc__QueryString_Web_HashSet_72b.GoodG2BSink(dataHashtable, req, resp); }