public void CommandEnded(CommandBuildStep command) { lock (lockObject) { TimeInterval commandInterval = commandExecutionIntervals[command]; long startTime = commandInterval.StartTime; long endTime = stopWatch.ElapsedTicks; commandInterval.End(endTime); foreach (var outputObject in command.Result.OutputObjects) { var outputUrl = outputObject.Key; List <TimeInterval <BuildStep> > inputReadAccess; if (readAccesses.TryGetValue(outputUrl, out inputReadAccess)) { foreach (TimeInterval <BuildStep> input in inputReadAccess.Where(input => input.Object != command && input.Overlap(startTime, endTime))) { logger.Error("Command {0} is writing {1} while command {2} is reading it", command, outputUrl, input.Object); } } List <TimeInterval <KeyValuePair <BuildStep, ObjectId> > > outputWriteAccess; if (!writeAccesses.TryGetValue(outputUrl, out outputWriteAccess)) { outputWriteAccess = new List <TimeInterval <KeyValuePair <BuildStep, ObjectId> > > { new TimeInterval <KeyValuePair <BuildStep, ObjectId> >(new KeyValuePair <BuildStep, ObjectId>(command, outputObject.Value), startTime, endTime) }; writeAccesses.Add(outputUrl, outputWriteAccess); } else { foreach (var output in outputWriteAccess.Where(output => output.Object.Key != command && output.Overlap(startTime, endTime))) { if (outputObject.Value != output.Object.Value) { logger.Error("Commands {0} and {1} are both writing {2} at the same time, but they are different objects", command, output.Object, outputUrl); } } outputWriteAccess.Add(new TimeInterval <KeyValuePair <BuildStep, ObjectId> >(new KeyValuePair <BuildStep, ObjectId>(command, outputObject.Value), startTime, endTime)); } } foreach (ObjectUrl inputUrl in command.Result.InputDependencyVersions.Keys) { List <TimeInterval <KeyValuePair <BuildStep, ObjectId> > > outputWriteAccess; if (writeAccesses.TryGetValue(inputUrl, out outputWriteAccess)) { foreach (TimeInterval <KeyValuePair <BuildStep, ObjectId> > output in outputWriteAccess.Where(output => output.Object.Key != command && output.Overlap(startTime, endTime))) { logger.Error("Command {0} is writing {1} while command {2} is reading it", output.Object, inputUrl, command); } } } foreach (ObjectUrl input in command.Command.GetInputFiles()) { readAccesses[input].Single(x => x.Object == command).End(endTime); } } }
public void CommandEnded(CommandBuildStep command) { lock (lockObject) { TimeInterval commandInterval = commandExecutionIntervals[command]; long startTime = commandInterval.StartTime; long endTime = stopWatch.ElapsedTicks; commandInterval.End(endTime); commandExecutionIntervals.Remove(command); foreach (var outputObject in command.Result.OutputObjects) { var outputUrl = outputObject.Key; ObjectAccesses inputAccess; if (objectsAccesses.TryGetValue(outputUrl, out inputAccess)) { foreach (TimeInterval <BuildStep> input in inputAccess.Reads.Where(input => input.Object != command && input.Overlap(startTime, endTime))) { logger.Error($"Command {command} is writing {outputUrl} while command {input.Object} is reading it"); } } ObjectAccesses outputAccess; if (!objectsAccesses.TryGetValue(outputUrl, out outputAccess)) { objectsAccesses.Add(outputUrl, outputAccess = new ObjectAccesses()); } foreach (var output in outputAccess.Writes.Where(output => output.Object.Key != command && output.Overlap(startTime, endTime))) { if (outputObject.Value != output.Object.Value) { logger.Error($"Commands {command} and {output.Object} are both writing {outputUrl} at the same time, but they are different objects"); } } outputAccess.Writes.Add(new TimeInterval <KeyValuePair <BuildStep, ObjectId> >(new KeyValuePair <BuildStep, ObjectId>(command, outputObject.Value), startTime, endTime)); } foreach (ObjectUrl inputUrl in command.Result.InputDependencyVersions.Keys) { ObjectAccesses outputAccess; if (objectsAccesses.TryGetValue(inputUrl, out outputAccess)) { foreach (TimeInterval <KeyValuePair <BuildStep, ObjectId> > output in outputAccess.Writes.Where(output => output.Object.Key != command && output.Overlap(startTime, endTime))) { logger.Error($"Command {output.Object} is writing {inputUrl} while command {command} is reading it"); } } } // Notify that we're done reading input files List <ObjectUrl> inputFiles; if (commandInputFiles.TryGetValue(command, out inputFiles)) { commandInputFiles.Remove(command); foreach (ObjectUrl input in inputFiles) { objectsAccesses[input].Reads.Single(x => x.Object == command).End(endTime); } } // "Garbage collection" of accesses var newEarliestCommandAliveStartTime = commandExecutionIntervals.Count > 0 ? commandExecutionIntervals.Min(x => x.Value.StartTime) : endTime; if (newEarliestCommandAliveStartTime > earliestCommandAliveStartTime) { earliestCommandAliveStartTime = newEarliestCommandAliveStartTime; // We can remove objects whose all R/W accesses are "completed" (EndTime is set) // and happened before all the current running commands started, since they won't affect us foreach (var objectAccesses in objectsAccesses.ToList()) { if (objectAccesses.Value.Reads.All(x => x.EndTime != 0 && x.EndTime < earliestCommandAliveStartTime) && objectAccesses.Value.Writes.All(x => x.EndTime != 0 && x.EndTime < earliestCommandAliveStartTime)) { objectsAccesses.Remove(objectAccesses.Key); } } } } }