public void InspectionName()
{
const string inspectionName = "VariableNotAssignedInspection";
var inspection = new VariableNotAssignedInspection(null);
Assert.AreEqual(inspectionName, inspection.Name);
}
public void UnassignedVariable_ReturnsResult_MultipleVariables_SomeAssigned()
{
const string inputCode =
@"Sub Foo()
Dim var1 as Integer
var1 = 8
Dim var2 as String
End Sub";
//Arrange
var builder = new MockVbeBuilder();
VBComponent component;
var vbe = builder.BuildFromSingleStandardModule(inputCode, out component);
var mockHost = new Mock <IHostApplication>();
mockHost.SetupAllProperties();
var parser = MockParser.Create(vbe.Object, new RubberduckParserState(new Mock <ISinks>().Object));
parser.Parse(new CancellationTokenSource());
if (parser.State.Status >= ParserState.Error)
{
Assert.Inconclusive("Parser Error");
}
var inspection = new VariableNotAssignedInspection(parser.State);
var inspectionResults = inspection.GetInspectionResults();
Assert.AreEqual(1, inspectionResults.Count());
}
public void VariableNotAssigned_Ignored_DoesNotReturnResult()
{
const string inputCode =
@"Sub Foo()
'@Ignore VariableNotAssigned
Dim var1 As String
End Sub";
//Arrange
var builder = new MockVbeBuilder();
VBComponent component;
var vbe = builder.BuildFromSingleStandardModule(inputCode, out component);
var mockHost = new Mock <IHostApplication>();
mockHost.SetupAllProperties();
var parser = MockParser.Create(vbe.Object, new RubberduckParserState(new Mock <ISinks>().Object));
parser.Parse(new CancellationTokenSource());
if (parser.State.Status >= ParserState.Error)
{
Assert.Inconclusive("Parser Error");
}
var inspection = new VariableNotAssignedInspection(parser.State);
var inspectionResults = inspection.GetInspectionResults();
Assert.IsFalse(inspectionResults.Any());
}
public void UnassignedVariable_DoesNotReturnResult()
{
const string inputCode =
@"Function Foo() As Boolean
Dim var1 as String
var1 = ""test""
End Function";
//Arrange
var builder = new MockVbeBuilder();
VBComponent component;
var vbe = builder.BuildFromSingleStandardModule(inputCode, out component);
var mockHost = new Mock <IHostApplication>();
mockHost.SetupAllProperties();
var parser = MockParser.Create(vbe.Object, new RubberduckParserState(new Mock <ISinks>().Object));
parser.Parse(new CancellationTokenSource());
if (parser.State.Status >= ParserState.Error)
{
Assert.Inconclusive("Parser Error");
}
var inspection = new VariableNotAssignedInspection(parser.State);
var inspectionResults = inspection.GetInspectionResults();
Assert.AreEqual(0, inspectionResults.Count());
}
public void UnassignedVariable_QuickFixWorks()
{
const string inputCode =
@"Sub Foo()
Dim var1 as Integer
End Sub";
const string expectedCode =
@"Sub Foo()
End Sub";
//Arrange
var builder = new MockVbeBuilder();
VBComponent component;
var vbe = builder.BuildFromSingleStandardModule(inputCode, out component);
var project = vbe.Object.VBProjects.Item(0);
var module = project.VBComponents.Item(0).CodeModule;
var mockHost = new Mock <IHostApplication>();
mockHost.SetupAllProperties();
var parser = MockParser.Create(vbe.Object, new RubberduckParserState(new Mock <ISinks>().Object));
parser.Parse(new CancellationTokenSource());
if (parser.State.Status >= ParserState.Error)
{
Assert.Inconclusive("Parser Error");
}
var inspection = new VariableNotAssignedInspection(parser.State);
inspection.GetInspectionResults().First().QuickFixes.First().Fix();
Assert.AreEqual(expectedCode, module.Lines());
}
public void VariableNotAssigned_ReturnsResult()
{
const string inputCode =
@"Sub Foo()
Dim var1 As String
End Sub";
var vbe = MockVbeBuilder.BuildFromSingleStandardModule(inputCode, out _);
var state = MockParser.CreateAndParse(vbe.Object);
var inspection = new VariableNotAssignedInspection(state);
var inspectionResults = inspection.GetInspectionResults();
Assert.AreEqual(1, inspectionResults.Count());
}
public void UnassignedVariable_DoesNotReturnResult()
{
const string inputCode =
@"Function Foo() As Boolean
Dim var1 as String
var1 = ""test""
End Function";
var vbe = MockVbeBuilder.BuildFromSingleStandardModule(inputCode, out _);
var state = MockParser.CreateAndParse(vbe.Object);
var inspection = new VariableNotAssignedInspection(state);
var inspectionResults = inspection.GetInspectionResults();
Assert.AreEqual(0, inspectionResults.Count());
}
public void VariableNotAssigned_Ignored_DoesNotReturnResult()
{
const string inputCode =
@"Sub Foo()
'@Ignore VariableNotAssigned
Dim var1 As String
End Sub";
var vbe = MockVbeBuilder.BuildFromSingleStandardModule(inputCode, out _);
var state = MockParser.CreateAndParse(vbe.Object);
var inspection = new VariableNotAssignedInspection(state);
var inspectionResults = inspection.GetInspectionResults();
Assert.IsFalse(inspectionResults.Any());
}
public void UnassignedVariable_ReturnsResult_MultipleVariables()
{
const string inputCode =
@"Sub Foo()
Dim var1 As String
Dim var2 As Date
End Sub";
IVBComponent component;
var vbe = MockVbeBuilder.BuildFromSingleStandardModule(inputCode, out component);
var state = MockParser.CreateAndParse(vbe.Object);
var inspection = new VariableNotAssignedInspection(state);
var inspectionResults = inspection.GetInspectionResults();
Assert.AreEqual(2, inspectionResults.Count());
}
public void UnassignedVariable_ReturnsResult_MultipleVariables_SomeAssigned()
{
const string inputCode =
@"Sub Foo()
Dim var1 as Integer
var1 = 8
Dim var2 as String
End Sub";
var vbe = MockVbeBuilder.BuildFromSingleStandardModule(inputCode, out _);
using (var state = MockParser.CreateAndParse(vbe.Object))
{
var inspection = new VariableNotAssignedInspection(state);
var inspectionResults = inspection.GetInspectionResults(CancellationToken.None);
Assert.AreEqual(1, inspectionResults.Count());
}
}
public void UnassignedVariable_QuickFixWorks()
{
const string inputCode =
@"Sub Foo()
Dim var1 as Integer
End Sub";
const string expectedCode =
@"Sub Foo()
End Sub";
var vbe = MockVbeBuilder.BuildFromSingleStandardModule(inputCode, out var component);
var state = MockParser.CreateAndParse(vbe.Object);
var inspection = new VariableNotAssignedInspection(state);
new RemoveUnassignedIdentifierQuickFix(state).Fix(inspection.GetInspectionResults().First());
Assert.AreEqual(expectedCode, state.GetRewriter(component).GetText());
}
public void UnassignedVariable_QuickFixWorks()
{
const string inputCode =
@"Sub Foo()
Dim var1 as Integer
End Sub";
const string expectedCode =
@"Sub Foo()
End Sub";
IVBComponent component;
var vbe = MockVbeBuilder.BuildFromSingleStandardModule(inputCode, out component);
var state = MockParser.CreateAndParse(vbe.Object);
var inspection = new VariableNotAssignedInspection(state);
inspection.GetInspectionResults().First().QuickFixes.First().Fix();
Assert.AreEqual(expectedCode, component.CodeModule.Content());
}
public void UnassignedVariable_MultipleVariablesOnSingleLine_QuickFixWorks()
{
const string inputCode =
@"Sub Foo()
Dim var1 As Integer, var2 As Boolean
End Sub";
const string expectedCode =
@"Sub Foo()
Dim var1 As Integer
End Sub";
var vbe = MockVbeBuilder.BuildFromSingleStandardModule(inputCode, out var component);
using (var state = MockParser.CreateAndParse(vbe.Object))
{
var inspection = new VariableNotAssignedInspection(state);
new RemoveUnassignedIdentifierQuickFix(state).Fix(
inspection.GetInspectionResults(CancellationToken.None).Single(s => s.Target.IdentifierName == "var2"));
Assert.AreEqual(expectedCode, state.GetRewriter(component).GetText());
}
}
public void UnassignedVariable_MultipleVariablesOnMultipleLines_QuickFixWorks()
{
const string inputCode =
@"Sub Foo()
Dim var1 As Integer, _
var2 As Boolean
End Sub";
const string expectedCode =
@"Sub Foo()
Dim var1 As Integer
End Sub";
IVBComponent component;
var vbe = MockVbeBuilder.BuildFromSingleStandardModule(inputCode, out component);
var state = MockParser.CreateAndParse(vbe.Object);
var inspection = new VariableNotAssignedInspection(state);
inspection.GetInspectionResults().Single(s => s.Target.IdentifierName == "var2").QuickFixes.First().Fix();
Assert.AreEqual(expectedCode, component.CodeModule.Content());
}
public void VariableNotAssigned_GivenByRefAssignment_DoesNotReturnResult()
{
const string inputCode = @"
Sub Foo()
Dim var1 As String
Bar var1
End Sub
Sub Bar(ByRef value As String)
value = ""test""
End Sub
";
var vbe = MockVbeBuilder.BuildFromSingleStandardModule(inputCode, out _);
using (var state = MockParser.CreateAndParse(vbe.Object))
{
var inspection = new VariableNotAssignedInspection(state);
var inspectionResults = inspection.GetInspectionResults(CancellationToken.None);
Assert.IsFalse(inspectionResults.Any());
}
}
public void UnassignedVariable_IgnoreQuickFixWorks()
{
const string inputCode =
@"Sub Foo()
Dim var1 as Integer
End Sub";
const string expectedCode =
@"Sub Foo()
'@Ignore VariableNotAssigned
Dim var1 as Integer
End Sub";
var vbe = MockVbeBuilder.BuildFromSingleStandardModule(inputCode, out var component);
using (var state = MockParser.CreateAndParse(vbe.Object))
{
var inspection = new VariableNotAssignedInspection(state);
new IgnoreOnceQuickFix(state, new[] { inspection }).Fix(inspection.GetInspectionResults(CancellationToken.None).First());
Assert.AreEqual(expectedCode, state.GetRewriter(component).GetText());
}
}
public void UnassignedVariable_MultipleVariablesOnSingleLine_QuickFixWorks()
{
const string inputCode =
@"Sub Foo()
Dim var1 As Integer, var2 As Boolean
End Sub";
// note the extra space after "Integer"--the VBE will remove it
const string expectedCode =
@"Sub Foo()
Dim var1 As Integer
End Sub";
//Arrange
var builder = new MockVbeBuilder();
VBComponent component;
var vbe = builder.BuildFromSingleStandardModule(inputCode, out component);
var project = vbe.Object.VBProjects.Item(0);
var module = project.VBComponents.Item(0).CodeModule;
var mockHost = new Mock <IHostApplication>();
mockHost.SetupAllProperties();
var parser = MockParser.Create(vbe.Object, new RubberduckParserState(new Mock <ISinks>().Object));
parser.Parse(new CancellationTokenSource());
if (parser.State.Status >= ParserState.Error)
{
Assert.Inconclusive("Parser Error");
}
var inspection = new VariableNotAssignedInspection(parser.State);
inspection.GetInspectionResults().Single(s => s.Target.IdentifierName == "var2").QuickFixes.First().Fix();
Assert.AreEqual(expectedCode, module.Lines());
}
public void InspectionName()
{
var inspection = new VariableNotAssignedInspection(null);
Assert.AreEqual(nameof(VariableNotAssignedInspection), inspection.Name);
}
public void InspectionType()
{
var inspection = new VariableNotAssignedInspection(null);
Assert.AreEqual(CodeInspectionType.CodeQualityIssues, inspection.InspectionType);
}
