public override void Bad(HttpRequest req, HttpResponse resp) { int data; data = int.MinValue; /* initialize data in case there are no cookies */ /* Read data from cookies */ { HttpCookieCollection cookieSources = req.Cookies; if (cookieSources != null) { /* POTENTIAL FLAW: Read data from the first cookie value */ string stringNumber = cookieSources[0].Value; try { data = int.Parse(stringNumber.Trim()); } catch (FormatException exceptNumberFormat) { IO.Logger.Log(NLog.LogLevel.Warn, exceptNumberFormat, "Number format exception reading data from cookie"); } } } Dictionary <int, int> dataDictionary = new Dictionary <int, int>(); dataDictionary.Add(0, data); dataDictionary.Add(1, data); dataDictionary.Add(2, data); CWE789_Uncontrolled_Mem_Alloc__Get_Cookies_Web_Dictionary_74b.BadSink(dataDictionary, req, resp); }
/* goodG2B() - use goodsource and badsink */ private static void GoodG2B(HttpRequest req, HttpResponse resp) { int data; /* FIX: Use a hardcoded number that won't cause underflow, overflow, divide by zero, or loss-of-precision issues */ data = 2; Dictionary <int, int> dataDictionary = new Dictionary <int, int>(); dataDictionary.Add(0, data); dataDictionary.Add(1, data); dataDictionary.Add(2, data); CWE789_Uncontrolled_Mem_Alloc__Get_Cookies_Web_Dictionary_74b.GoodG2BSink(dataDictionary, req, resp); }