/* goodG2B() - use goodsource and badsink */
private static void GoodG2B()
{
double data;
/* FIX: Use a hardcoded number that won't cause underflow, overflow, divide by zero, or loss-of-precision issues */
data = 2;
/* serialize data to a byte array */
byte[] dataSerialized = null;
try
{
BinaryFormatter bf = new BinaryFormatter();
using (var ms = new MemoryStream())
{
bf.Serialize(ms, data);
dataSerialized = ms.ToArray();
}
CWE197_Numeric_Truncation_Error__double_database_to_short_75b.GoodG2BSink(dataSerialized );
}
catch (SerializationException exceptSerialize)
{
IO.Logger.Log(NLog.LogLevel.Warn, "Serialization exception in serialization", exceptSerialize);
}
}
public override void Bad()
{
double data;
data = double.MinValue; /* Initialize data */
/* Read data from a database */
{
SqlConnection connection = null;
SqlDataReader dr = null;
try
{
/* setup the connection */
using (connection = IO.GetDBConnection())
{
connection.Open();
/* prepare and execute a (hardcoded) query */
SqlCommand command = new SqlCommand(null, connection);
command.CommandText = "select name from users where id=0";
command.Prepare();
dr = command.ExecuteReader();
/* FLAW: Read data from a database query SqlDataReader */
string stringNumber = dr.GetString(1);
if (stringNumber != null) /* avoid NPD incidental warnings */
{
try
{
data = double.Parse(stringNumber.Trim());
}
catch (FormatException exceptNumberFormat)
{
IO.Logger.Log(NLog.LogLevel.Warn, exceptNumberFormat, "Number format exception parsing data from string");
}
}
}
}
catch (SqlException exceptSql)
{
IO.Logger.Log(NLog.LogLevel.Warn, exceptSql, "Error with SQL statement");
}
finally
{
/* Close database objects */
try
{
if (dr != null)
{
dr.Close();
}
}
catch (Exception except) /* INCIDENTAL: CWE 396 Catch Generic Exception */
{
IO.Logger.Log(NLog.LogLevel.Warn, except, "Error closing SqlDataReader");
}
try
{
if (connection != null)
{
connection.Close();
}
}
catch (SqlException exceptSql)
{
IO.Logger.Log(NLog.LogLevel.Warn, exceptSql, "Error closing Connection");
}
}
}
/* serialize data to a byte array */
byte[] dataSerialized = null;
try
{
BinaryFormatter bf = new BinaryFormatter();
using (var ms = new MemoryStream())
{
bf.Serialize(ms, data);
dataSerialized = ms.ToArray();
}
CWE197_Numeric_Truncation_Error__double_database_to_short_75b.BadSink(dataSerialized );
}
catch (SerializationException exceptSerialize)
{
IO.Logger.Log(NLog.LogLevel.Warn, "Serialization exception in serialization", exceptSerialize);
}
}
