/* goodG2B() - use goodsource and badsink */ public static void GoodG2BSink(CWE190_Integer_Overflow__Byte_console_readLine_multiply_67a.Container dataContainer) { byte data = dataContainer.containerOne; if (data > 0) /* ensure we won't have an underflow */ { /* POTENTIAL FLAW: if (data*2) > byte.MaxValue, this will overflow */ byte result = (byte)(data * 2); IO.WriteLine("result: " + result); } }
/* goodB2G() - use badsource and goodsink */ public static void GoodB2GSink(CWE190_Integer_Overflow__Byte_console_readLine_multiply_67a.Container dataContainer) { byte data = dataContainer.containerOne; if (data > 0) /* ensure we won't have an underflow */ { /* FIX: Add a check to prevent an overflow from occurring */ if (data < (byte.MaxValue / 2)) { byte result = (byte)(data * 2); IO.WriteLine("result: " + result); } else { IO.WriteLine("data value is too large to perform multiplication."); } } }