public void VariableTypeNotDeclared_ReturnsResult_QuickFixWorks_Variable()
{
const string inputCode =
@"Sub Foo()
Dim var1
End Sub";
const string expectedCode =
@"Sub Foo()
Dim var1 As Variant
End Sub";
//Arrange
var builder = new MockVbeBuilder();
VBComponent component;
var vbe = builder.BuildFromSingleStandardModule(inputCode, out component);
var project = vbe.Object.VBProjects.Item(0);
var module = project.VBComponents.Item(0).CodeModule;
var mockHost = new Mock <IHostApplication>();
mockHost.SetupAllProperties();
var parser = MockParser.Create(vbe.Object, new RubberduckParserState());
parser.Parse();
if (parser.State.Status == ParserState.Error)
{
Assert.Inconclusive("Parser Error");
}
var inspection = new VariableTypeNotDeclaredInspection(parser.State);
inspection.GetInspectionResults().First().QuickFixes.First().Fix();
Assert.AreEqual(expectedCode, module.Lines());
}
public void VariableTypeNotDeclared_DoesNotReturnResult_Parameter()
{
const string inputCode =
@"Sub Foo(arg1 As Date)
End Sub";
//Arrange
var builder = new MockVbeBuilder();
VBComponent component;
var vbe = builder.BuildFromSingleStandardModule(inputCode, out component);
var mockHost = new Mock <IHostApplication>();
mockHost.SetupAllProperties();
var parser = MockParser.Create(vbe.Object, new RubberduckParserState());
parser.Parse();
if (parser.State.Status == ParserState.Error)
{
Assert.Inconclusive("Parser Error");
}
var inspection = new VariableTypeNotDeclaredInspection(parser.State);
var inspectionResults = inspection.GetInspectionResults();
Assert.AreEqual(0, inspectionResults.Count());
}
public void AnnotationListFollowedByCommentAddsAnnotationCorrectly()
{
const string inputCode = @"
Public Function GetSomething() As Long
'@Ignore VariableNotAssigned: Is followed by a comment.
Dim foo
GetSomething = foo
End Function
";
const string expectedCode = @"
Public Function GetSomething() As Long
'@Ignore VariableTypeNotDeclared, VariableNotAssigned: Is followed by a comment.
Dim foo
GetSomething = foo
End Function
";
var vbe = MockVbeBuilder.BuildFromSingleStandardModule(inputCode, out var component);
using (var state = MockParser.CreateAndParse(vbe.Object))
{
var inspection = new VariableTypeNotDeclaredInspection(state);
var inspectionResults = inspection.GetInspectionResults(CancellationToken.None);
new IgnoreOnceQuickFix(state, new[] { inspection }).Fix(inspectionResults.First());
Assert.AreEqual(expectedCode, state.GetRewriter(component).GetText());
}
}
public void VariableTypeNotDeclared_Ignored_DoesNotReturnResult()
{
const string inputCode =
@"'@Ignore VariableTypeNotDeclared
Sub Foo(arg1)
End Sub";
//Arrange
var builder = new MockVbeBuilder();
VBComponent component;
var vbe = builder.BuildFromSingleStandardModule(inputCode, out component);
var mockHost = new Mock <IHostApplication>();
mockHost.SetupAllProperties();
var parser = MockParser.Create(vbe.Object, new RubberduckParserState(new Mock <ISinks>().Object));
parser.Parse(new CancellationTokenSource());
if (parser.State.Status >= ParserState.Error)
{
Assert.Inconclusive("Parser Error");
}
var inspection = new VariableTypeNotDeclaredInspection(parser.State);
var inspectionResults = inspection.GetInspectionResults();
Assert.IsFalse(inspectionResults.Any());
}
public void VariableTypeNotDeclared_IgnoreQuickFixWorks()
{
const string inputCode =
@"Sub Foo(arg1)
End Sub";
const string expectedCode =
@"'@Ignore VariableTypeNotDeclared
Sub Foo(arg1)
End Sub";
//Arrange
var builder = new MockVbeBuilder();
VBComponent component;
var vbe = builder.BuildFromSingleStandardModule(inputCode, out component);
var project = vbe.Object.VBProjects.Item(0);
var module = project.VBComponents.Item(0).CodeModule;
var mockHost = new Mock <IHostApplication>();
mockHost.SetupAllProperties();
var parser = MockParser.Create(vbe.Object, new RubberduckParserState(new Mock <ISinks>().Object));
parser.Parse(new CancellationTokenSource());
if (parser.State.Status >= ParserState.Error)
{
Assert.Inconclusive("Parser Error");
}
var inspection = new VariableTypeNotDeclaredInspection(parser.State);
inspection.GetInspectionResults().First().QuickFixes.Single(s => s is IgnoreOnceQuickFix).Fix();
Assert.AreEqual(expectedCode, module.Lines());
}
public void VariableTypeNotDeclaredInspectionTest()
{
var code = "Private foo\n";
var parser = new Parser(_grammar);
var node = parser.Parse("CodeInspectionTests", "TestModule", code, false);
var projectNode = new ProjectNode("CodeInspectionTests", new[] { node });
var inspection = new VariableTypeNotDeclaredInspection();
var results = inspection.GetInspectionResults(projectNode);
Assert.IsTrue(results.Any(result => result.GetType() == typeof(VariableTypeNotDeclaredInspectionResult)));
}
public void VariableTypeNotDeclared_ReturnsResult_MultipleParams()
{
const string inputCode =
@"Sub Foo(arg1, arg2)
End Sub";
var vbe = MockVbeBuilder.BuildFromSingleStandardModule(inputCode, out _);
using (var state = MockParser.CreateAndParse(vbe.Object))
{
var inspection = new VariableTypeNotDeclaredInspection(state);
var inspectionResults = inspection.GetInspectionResults(CancellationToken.None);
Assert.AreEqual(2, inspectionResults.Count());
}
}
public void VariableTypeNotDeclared_Const_DoesNotReturnResult()
{
const string inputCode =
@"Sub Foo()
Const bar = 42
End Sub";
var vbe = MockVbeBuilder.BuildFromSingleStandardModule(inputCode, out _);
using (var state = MockParser.CreateAndParse(vbe.Object))
{
var inspection = new VariableTypeNotDeclaredInspection(state);
var inspectionResults = inspection.GetInspectionResults(CancellationToken.None);
Assert.IsFalse(inspectionResults.Any());
}
}
public void VariableTypeNotDeclared_ReturnsResult_MultipleVariables()
{
const string inputCode =
@"Sub Foo()
Dim var1
Dim var2
End Sub";
IVBComponent component;
var vbe = MockVbeBuilder.BuildFromSingleStandardModule(inputCode, out component);
var state = MockParser.CreateAndParse(vbe.Object);
var inspection = new VariableTypeNotDeclaredInspection(state);
var inspectionResults = inspection.GetInspectionResults();
Assert.AreEqual(2, inspectionResults.Count());
}
public void VariableTypeNotDeclared_QuickFixWorks_ParameterWithoutDefaultValue()
{
const string inputCode =
@"Sub Foo(ByVal Fizz)
End Sub";
const string expectedCode =
@"Sub Foo(ByVal Fizz As Variant)
End Sub";
var vbe = MockVbeBuilder.BuildFromSingleStandardModule(inputCode, out var component);
var state = MockParser.CreateAndParse(vbe.Object);
var inspection = new VariableTypeNotDeclaredInspection(state);
new DeclareAsExplicitVariantQuickFix(state).Fix(inspection.GetInspectionResults().First());
Assert.AreEqual(expectedCode, state.GetRewriter(component).GetText());
}
public void VariableTypeNotDeclared_QuickFixWorks_ParameterWithDefaultValue()
{
const string inputCode =
@"Sub Foo(ByVal Fizz = False)
End Sub";
const string expectedCode =
@"Sub Foo(ByVal Fizz As Variant = False)
End Sub";
IVBComponent component;
var vbe = MockVbeBuilder.BuildFromSingleStandardModule(inputCode, out component);
var state = MockParser.CreateAndParse(vbe.Object);
var inspection = new VariableTypeNotDeclaredInspection(state);
inspection.GetInspectionResults().First().QuickFixes.First().Fix();
Assert.AreEqual(expectedCode, component.CodeModule.Content());
}
public void VariableTypeNotDeclared_QuickFixWorks_SubNameContainsParameterName()
{
const string inputCode =
@"Sub Foo(Foo)
End Sub";
const string expectedCode =
@"Sub Foo(Foo As Variant)
End Sub";
var vbe = MockVbeBuilder.BuildFromSingleStandardModule(inputCode, out var component);
using (var state = MockParser.CreateAndParse(vbe.Object))
{
var inspection = new VariableTypeNotDeclaredInspection(state);
new DeclareAsExplicitVariantQuickFix(state).Fix(inspection.GetInspectionResults(CancellationToken.None).First());
Assert.AreEqual(expectedCode, state.GetRewriter(component).GetText());
}
}
public void VariableTypeNotDeclared_IgnoreQuickFixWorks()
{
const string inputCode =
@"Sub Foo(arg1)
End Sub";
const string expectedCode =
@"'@Ignore VariableTypeNotDeclared
Sub Foo(arg1)
End Sub";
var vbe = MockVbeBuilder.BuildFromSingleStandardModule(inputCode, out var component);
var state = MockParser.CreateAndParse(vbe.Object);
var inspection = new VariableTypeNotDeclaredInspection(state);
new IgnoreOnceQuickFix(state, new[] { inspection }).Fix(inspection.GetInspectionResults().First());
Assert.AreEqual(expectedCode, state.GetRewriter(component).GetText());
}