public async Task <IActionResult> CreateObservationAsync(ObservationAddDto model)
{
try
{
var requestingUser = await _userManager.FindByNameAsync(User.Identity.Name);
if (requestingUser is null)
{
_logger.LogError(LoggingEvents.GetItem, "requesting user not found");
return(StatusCode(500, "requesting user not found"));
}
var observedBirdSpecies = await _birdRepository.GetBirdAsync(model.Bird.BirdId);
if (observedBirdSpecies is null)
{
string message = $"Bird species with id '{model.BirdId}' was not found.";
_logger.LogError(LoggingEvents.GetItem, message);
return(StatusCode(500, message));
}
// date from client model is already Utc....
// model.ObservationDateTime = model.ObservationDateTime.ToLocalTime();
// var x = model.ObservationDateTime;
// var y = model.ObservationDateTime = model.ObservationDateTime.ToLocalTime();
// var z = model.ObservationDateTime = model.ObservationDateTime.ToUniversalTime();
var observation = _mapper.Map <ObservationAddDto, Observation>(model);
DateTime createdDate = _systemClock.GetNow;
observation.ApplicationUser = requestingUser;
observation.Bird = observedBirdSpecies;
observation.CreationDate = createdDate;
observation.LastUpdateDate = createdDate;
//rerun validation on observation model
if (!TryValidateModel(observation, nameof(observation)))
{
_logger.LogError(LoggingEvents.UpdateItem, "Observation model state is invalid: " + ModelStateErrorsExtensions.GetModelStateErrorMessages(ModelState));
return(StatusCode(500, "observation ModelState is invalid"));
}
_observationPositionRepository.Add(observation.Position);
_observationRepository.Add(observation);
_observationNoteRepository.AddRange(observation.Notes);
await _unitOfWork.CompleteAsync();
return(CreatedAtAction(nameof(CreateObservationAsync), _mapper.Map <Observation, ObservationDto>(observation)));
}
catch (Exception ex)
{
_logger.LogError(LoggingEvents.GetListNotFound, ex, "An error occurred creating an observation.");
return(StatusCode(500, "an unexpected error occurred"));
}
}
public async Task CreateObservationAsync_ReturnsBadRequest_OnException()
{
//Arrange
int birdId = 1;
//var model = GetTestObservationViewModel(id, birdId);
var model = new ObservationAddDto()
{
//ObservationId = id,
Bird = new BirdSummaryViewModel()
{
BirdId = birdId
},
BirdId = birdId,
Position = new ObservationPositionDto()
{
}
};
var requestingUser = GetUser("Any");
var mockUnitOfWork = new Mock <IUnitOfWork>();
var mockBirdRepo = new Mock <IBirdRepository>();
mockBirdRepo.Setup(b => b.GetBirdAsync(It.IsAny <int>()))
.ReturnsAsync(GetTestBird(birdId));
var mockUserManager = SharedFunctions.InitialiseMockUserManager();
mockUserManager.Setup(um => um.FindByNameAsync(It.IsAny <string>()))
.ReturnsAsync(requestingUser);
var mockObsRepo = new Mock <IObservationRepository>();
mockObsRepo.Setup(o => o.Add(It.IsAny <Observation>()))
.Throws(new InvalidOperationException());
var mockObjectValidator = new Mock <IObjectModelValidator>();
mockObjectValidator.Setup(o => o.Validate(It.IsAny <ActionContext>(),
It.IsAny <ValidationStateDictionary>(),
It.IsAny <string>(),
It.IsAny <Object>()));
var mockObsPositionRepo = new Mock <IObservationPositionRepository>();
var mockObsNotesRepo = new Mock <IObservationNoteRepository>();
var controller = new ObservationController(
_mapper
, _systemClock
, mockUnitOfWork.Object
, mockBirdRepo.Object
, _logger.Object
, mockUserManager.Object
, mockObsRepo.Object
, mockObsPositionRepo.Object
, mockObsNotesRepo.Object);
controller.ControllerContext = new ControllerContext()
{
HttpContext = new DefaultHttpContext()
{
User = SharedFunctions.GetTestClaimsPrincipal(requestingUser.UserName)
}
};
controller.ObjectValidator = mockObjectValidator.Object;
// Act
var result = await controller.CreateObservationAsync(model);
// Assert
var objectResult = Assert.IsType <ObjectResult>(result);
Assert.Equal(StatusCodes.Status500InternalServerError, objectResult.StatusCode);
var actual = Assert.IsType <string>(objectResult.Value);
Assert.Equal("an unexpected error occurred", actual);
}
//[InlineData(2, 1)]
//[InlineData(3, 1)]
public async Task CreateObservationAsync_ReturnsOkWithObservationViewModel_OnSuccess(int birdId)
{
//Arrange
//var model = GetTestObservationViewModel(id, birdId);
var model = new ObservationAddDto()
{
//ObservationId = id,
Bird = new BirdSummaryViewModel()
{
BirdId = birdId
},
BirdId = birdId,
Position = new ObservationPositionDto()
{
}
};
var requestingUser = GetUser("Any");
var mockUnitOfWork = new Mock <IUnitOfWork>();
mockUnitOfWork.Setup(w => w.CompleteAsync())
.Returns(Task.CompletedTask);
var mockBirdRepo = new Mock <IBirdRepository>();
mockBirdRepo.Setup(b => b.GetBirdAsync(It.IsAny <int>()))
.ReturnsAsync(GetTestBird(birdId));
var mockUserManager = SharedFunctions.InitialiseMockUserManager();
mockUserManager.Setup(um => um.FindByNameAsync(It.IsAny <string>()))
.ReturnsAsync(requestingUser);
var mockObsRepo = new Mock <IObservationRepository>();
mockObsRepo.Setup(o => o.Add(It.IsAny <Observation>()))
.Verifiable();
var mockObsNotesRepo = new Mock <IObservationNoteRepository>();
mockObsNotesRepo.Setup(o => o.Add(It.IsAny <ObservationNote>()))
.Verifiable();
var mockObsPositionRepo = new Mock <IObservationPositionRepository>();
mockObsPositionRepo.Setup(o => o.Add(It.IsAny <ObservationPosition>()))
.Verifiable();
var mockObjectValidator = new Mock <IObjectModelValidator>();
mockObjectValidator.Setup(o => o.Validate(It.IsAny <ActionContext>(),
It.IsAny <ValidationStateDictionary>(),
It.IsAny <string>(),
It.IsAny <Object>()));
var controller = new ObservationController(
_mapper
, _systemClock
, mockUnitOfWork.Object
, mockBirdRepo.Object
, _logger.Object
, mockUserManager.Object
, mockObsRepo.Object
, mockObsPositionRepo.Object
, mockObsNotesRepo.Object);
controller.ControllerContext = new ControllerContext()
{
HttpContext = new DefaultHttpContext()
{
User = SharedFunctions.GetTestClaimsPrincipal(requestingUser.UserName)
}
};
controller.ObjectValidator = mockObjectValidator.Object;
// Act
var result = await controller.CreateObservationAsync(model);
// Assert
var objectResult = Assert.IsType <CreatedAtActionResult>(result);
Assert.Equal("CreateObservationAsync", objectResult.ActionName);
Assert.Equal(StatusCodes.Status201Created, objectResult.StatusCode);
var actual = Assert.IsType <ObservationDto>(objectResult.Value);
Assert.Equal(model.BirdId, actual.BirdId);
}
//[InlineData(2, 1)]
//[InlineData(3, 2)]
public async Task CreateObservationAsync_ReturnsNotFound_WhenBirdNotFound(int birdId)
{
//Arrange
//var model = GetTestObservationViewModel(id, birdId);
var model = new ObservationAddDto()
{
//ObservationId = id,
Bird = new BirdSummaryViewModel()
{
BirdId = birdId
},
BirdId = birdId,
Position = new ObservationPositionDto()
{
}
};
var requestingUser = GetUser("Any");
var mockUnitOfWork = new Mock <IUnitOfWork>();
var mockBirdRepo = new Mock <IBirdRepository>();
mockBirdRepo.Setup(b => b.GetBirdAsync(It.IsAny <int>()))
.Returns(Task.FromResult <Bird>(null));
var mockUserManager = SharedFunctions.InitialiseMockUserManager();
mockUserManager.Setup(um => um.FindByNameAsync(It.IsAny <string>()))
.ReturnsAsync(requestingUser);
var mockObsRepo = new Mock <IObservationRepository>();
//mockObsRepo.Setup(o => o.GetObservationsAsync(It.IsAny<Expression<Func<Observation, bool>>>()))
// .ThrowsAsync(new InvalidOperationException());
var mockObsPositionRepo = new Mock <IObservationPositionRepository>();
var mockObsNotesRepo = new Mock <IObservationNoteRepository>();
var controller = new ObservationController(
_mapper
, _systemClock
, mockUnitOfWork.Object
, mockBirdRepo.Object
, _logger.Object
, mockUserManager.Object
, mockObsRepo.Object
, mockObsPositionRepo.Object
, mockObsNotesRepo.Object);
controller.ControllerContext = new ControllerContext()
{
HttpContext = new DefaultHttpContext()
{
User = SharedFunctions.GetTestClaimsPrincipal(requestingUser.UserName)
}
};
// Act
var result = await controller.CreateObservationAsync(model);
// Assert
var objectResult = Assert.IsType <ObjectResult>(result);
Assert.Equal(StatusCodes.Status500InternalServerError, objectResult.StatusCode);
var actual = Assert.IsType <string>(objectResult.Value);
Assert.Equal($"Bird species with id '{model.BirdId}' was not found.", actual);
}
