public async Task LintSolutionUseTsconfigs()
{
MockUIHierarchyItem mockSolutionHierarchyItem = new MockUIHierarchyItem()
{
Object = solution
};
UIHierarchyItem[] selectedItems = new UIHierarchyItem[] { mockSolutionHierarchyItem };
MockErrorListDataSource mockErrorListDataSource = new MockErrorListDataSource();
ErrorListDataSource.InjectMockErrorListDataSource(mockErrorListDataSource);
settings.UseTsConfig = true;
try
{
bool hasVSErrors = await LintFilesCommandBase.LintSelectedItems(false, selectedItems);
Assert.IsFalse(hasVSErrors);
Assert.IsTrue(mockErrorListDataSource.HasErrors());
Assert.AreEqual(7, mockErrorListDataSource.Snapshots.Count);
// Note file5 is referenced by a tsconfig that isn't in the project, so doesn't get included
string expected1 = Path.GetFullPath(@"../../artifacts/tsconfig/multiple/a/file1.ts");
string expected2 = Path.GetFullPath(@"../../artifacts/tsconfig/multiple/b/file2.ts");
string expected3 = Path.GetFullPath(@"../../artifacts/tsconfig/multiple/b/file3.ts");
string expected4 = Path.GetFullPath(@"../../artifacts/tsconfig/multiple/a/c/file4.ts");
//string expected5 = Path.GetFullPath(@"../../artifacts/tsconfig/none/b/file5.ts");
string expected6 = Path.GetFullPath(@"../../artifacts/tsconfig/multiple/a/c/file6.tsx");
string expected7 = Path.GetFullPath(@"../../artifacts/tsconfig/multiple/file7.ts");
string expected8 = Path.GetFullPath(@"../../artifacts/tsconfig/multiple/test.ts");
Assert.IsTrue(mockErrorListDataSource.Snapshots.Keys.Contains(expected1));
Assert.IsTrue(mockErrorListDataSource.Snapshots.Keys.Contains(expected2));
Assert.IsTrue(mockErrorListDataSource.Snapshots.Keys.Contains(expected3));
Assert.IsTrue(mockErrorListDataSource.Snapshots.Keys.Contains(expected4));
//Assert.IsTrue(mockErrorListDataSource.Snapshots.Keys.Contains(expected5));
Assert.IsTrue(mockErrorListDataSource.Snapshots.Keys.Contains(expected6));
Assert.IsTrue(mockErrorListDataSource.Snapshots.Keys.Contains(expected7));
Assert.IsTrue(mockErrorListDataSource.Snapshots.Keys.Contains(expected8));
// Similar to TslintWithTsconfigTest.LintAll, again this level of detail may be too much
Assert.AreEqual(3, mockErrorListDataSource.Snapshots[expected1].Count());
Assert.AreEqual(4, mockErrorListDataSource.Snapshots[expected2].Count());
Assert.AreEqual(3, mockErrorListDataSource.Snapshots[expected3].Count());
Assert.AreEqual(3, mockErrorListDataSource.Snapshots[expected4].Count());
//Assert.AreEqual(4, mockErrorListDataSource.Snapshots[expected5].Count());
Assert.AreEqual(11, mockErrorListDataSource.Snapshots[expected6].Count());
Assert.AreEqual(4, mockErrorListDataSource.Snapshots[expected7].Count());
Assert.AreEqual(5, mockErrorListDataSource.Snapshots[expected8].Count());
}
finally
{
ErrorListDataSource.InjectMockErrorListDataSource(null);
settings.UseTsConfig = false;
}
}
protected UIHierarchyItem[] Arrange(string solutionPath)
{
Initialize(solutionPath);
MockUIHierarchyItem mockSolutionHierarchyItem = new MockUIHierarchyItem()
{
Object = solution
};
selectedItems = new UIHierarchyItem[] { mockSolutionHierarchyItem };
mockErrorListDataSource = new MockErrorListDataSource();
ErrorListDataSource.InjectMockErrorListDataSource(mockErrorListDataSource);
return(selectedItems);
}
public async Task LintBadTslintJsonSolution()
{
MockUIHierarchyItem mockSolutionHierarchyItem = new MockUIHierarchyItem()
{
Object = solution
};
UIHierarchyItem[] selectedItems = new UIHierarchyItem[] { mockSolutionHierarchyItem };
MockErrorListDataSource mockErrorListDataSource = new MockErrorListDataSource();
ErrorListDataSource.InjectMockErrorListDataSource(mockErrorListDataSource);
settings.UseTsConfig = false;
settings.IgnoreNestedFiles = false;
try
{
bool hasVSErrors = await LintFilesCommandBase.LintSelectedItems(false, selectedItems);
Assert.IsTrue(hasVSErrors);
Assert.IsTrue(mockErrorListDataSource.HasErrors());
Assert.AreEqual(1, mockErrorListDataSource.Snapshots.Count);
CollectionAssert.AreEquivalent(new string[] { "TSLint" }, mockErrorListDataSource.Snapshots.Keys.ToArray());
var actualMsg = mockErrorListDataSource.Snapshots["TSLint"].Select(e => e.Message).First();
var expectedMsg = "Could not find custom rule directory: ./does-not-exist";
StringAssert.Contains(actualMsg, expectedMsg);
}
finally
{
ErrorListDataSource.InjectMockErrorListDataSource(null);
settings.UseTsConfig = false;
settings.IgnoreNestedFiles = true;
}
}
public async Task LintSolution()
{
MockUIHierarchyItem mockSolutionHierarchyItem = new MockUIHierarchyItem()
{
Object = solution
};
UIHierarchyItem[] selectedItems = new UIHierarchyItem[] { mockSolutionHierarchyItem };
MockErrorListDataSource mockErrorListDataSource = new MockErrorListDataSource();
ErrorListDataSource.InjectMockErrorListDataSource(mockErrorListDataSource);
settings.UseTsConfig = false;
settings.IgnoreNestedFiles = false;
try
{
bool hasVSErrors = await LintFilesCommandBase.LintSelectedItems(false, selectedItems);
Assert.IsFalse(hasVSErrors);
Assert.IsTrue(mockErrorListDataSource.HasErrors());
Assert.AreEqual(10, mockErrorListDataSource.Snapshots.Count);
// See LintFileLocationsTest.GetLintFilesForSolutionIncludeNested
string expected1 = Path.GetFullPath(@"../../artifacts/tsconfig/multiple/react-dom.d.ts");
string expected2 = Path.GetFullPath(@"../../artifacts/tsconfig/multiple/react.d.ts");
string expected3 = Path.GetFullPath(@"../../artifacts/tsconfig/multiple/test.ts");
string expected4 = Path.GetFullPath(@"../../artifacts/tsconfig/multiple/a/file1.ts");
string expected5 = Path.GetFullPath(@"../../artifacts/tsconfig/multiple/a/c/file4.ts");
string expected6 = Path.GetFullPath(@"../../artifacts/tsconfig/multiple/b/file3.ts");
string expected7 = Path.GetFullPath(@"../../artifacts/tsconfig/none/b/file5.ts");
string expected8 = Path.GetFullPath(@"../../artifacts/tsconfig/multiple/a/c/file6.tsx");
string expected9 = Path.GetFullPath(@"../../artifacts/tsconfig/multiple/file7.ts");
string expected10 = Path.GetFullPath(@"../../artifacts/tsconfig/file9.ts"); // Linked file
Assert.IsTrue(mockErrorListDataSource.Snapshots.Keys.Contains(expected1));
Assert.IsTrue(mockErrorListDataSource.Snapshots.Keys.Contains(expected2));
Assert.IsTrue(mockErrorListDataSource.Snapshots.Keys.Contains(expected3));
Assert.IsTrue(mockErrorListDataSource.Snapshots.Keys.Contains(expected4));
Assert.IsTrue(mockErrorListDataSource.Snapshots.Keys.Contains(expected5));
Assert.IsTrue(mockErrorListDataSource.Snapshots.Keys.Contains(expected6));
Assert.IsTrue(mockErrorListDataSource.Snapshots.Keys.Contains(expected7));
Assert.IsTrue(mockErrorListDataSource.Snapshots.Keys.Contains(expected8));
Assert.IsTrue(mockErrorListDataSource.Snapshots.Keys.Contains(expected9));
Assert.IsTrue(mockErrorListDataSource.Snapshots.Keys.Contains(expected10));
// May be too painful when we upgrade tslint: I think since the tslint.json is fixed it should be OK though
// 2017-08-30: tslint 5.7.0 changed no-namespace rule to 'ignore global augmentation', reduced 293->292 below
// 2017-10-30: tslint 5.8.0 no-empty-interface now disregards interfaces with generic types #3260, reduced 292 -> 283 below
// 2019-03-02: tslint 15.13.0 enabled the completed-docs rules if NOT using tsconfig.json, as here, previously only ran if
// a tsconfig.json was specified. That is it stopped being 'typed' = 'uses tslint' = 'uses type checker'.
// The rule was in tslint.json for this test, so extra test errors appeared. tslint issue #3557.
// 2019-05-31: tslint 15.17.0 treats IntrinsicAttributes, IntrinsicClassAttributes and IntrinsicElements interface names
// as failing the 'interface name must start with a capitalized I' test, version 5.13.1 didn't, +3 errors in
// expected2 (react.d.ts). interface-name rule.
// 2020-01-07: tslint 5.20.1 has stopped reporting line 2164 in react.d.ts in WebLinterTest/artifacts/
// tsconfig/multiple as being over 120 characters, in spite of the fact it clearly is, was reported in
// earlier versions, and other lines over 120 characters in that file are being correctly reported. Reduces
// errors in expected2 from 1297 to 1296. Edit: this is because of the check-strings flag for max-line-length
// introduced in 5.19.0 and set to false by default. If it is set to true the error reappears. Whether it's
// really meant to allow multiple string options on a line or this is a bug I'm not sure.
Assert.AreEqual(22, mockErrorListDataSource.Snapshots[expected1].Count());
Assert.AreEqual(1296, mockErrorListDataSource.Snapshots[expected2].Count());
Assert.AreEqual(5, mockErrorListDataSource.Snapshots[expected3].Count());
Assert.AreEqual(3, mockErrorListDataSource.Snapshots[expected4].Count());
Assert.AreEqual(3, mockErrorListDataSource.Snapshots[expected5].Count());
Assert.AreEqual(3, mockErrorListDataSource.Snapshots[expected6].Count());
Assert.AreEqual(4, mockErrorListDataSource.Snapshots[expected7].Count());
Assert.AreEqual(11, mockErrorListDataSource.Snapshots[expected8].Count());
Assert.AreEqual(4, mockErrorListDataSource.Snapshots[expected9].Count());
Assert.AreEqual(3, mockErrorListDataSource.Snapshots[expected10].Count());
// Pick an error and check we are generating all details - expected4 is file1.ts
LintingError lintingError = mockErrorListDataSource.Snapshots[expected4].First(le => le.ErrorCode == "no-empty");
Assert.AreEqual(expected4, lintingError.FileName);
Assert.AreEqual("block is empty", lintingError.Message);
Assert.AreEqual(2, lintingError.LineNumber);
Assert.AreEqual(17, lintingError.ColumnNumber);
Assert.AreEqual("https://palantir.github.io/tslint/rules/no-empty", lintingError.HelpLink);
Assert.IsFalse(lintingError.IsError);
}
finally
{
ErrorListDataSource.InjectMockErrorListDataSource(null);
settings.UseTsConfig = false;
settings.IgnoreNestedFiles = true;
}
}