public void FunctionReturnValueNotUsed_ReturnsResult_CallWithoutAssignment()
{
const string inputCode =
@"Public Function Foo(ByVal bar As String) As Integer
Foo = 42
End Function
Public Sub Bar()
Foo ""Test""
End Sub";
//Arrange
var builder = new MockVbeBuilder();
VBComponent component;
var vbe = builder.BuildFromSingleStandardModule(inputCode, out component);
var mockHost = new Mock<IHostApplication>();
mockHost.SetupAllProperties();
var parser = MockParser.Create(vbe.Object, new RubberduckParserState());
parser.Parse();
if (parser.State.Status == ParserState.Error) { Assert.Inconclusive("Parser Error"); }
var inspection = new FunctionReturnValueNotUsedInspection(parser.State);
var inspectionResults = inspection.GetInspectionResults();
Assert.AreEqual(1, inspectionResults.Count());
}
public void InspectionName()
{
const string inspectionName = "FunctionReturnValueNotUsedInspection";
var inspection = new FunctionReturnValueNotUsedInspection(null);
Assert.AreEqual(inspectionName, inspection.Name);
}
public void InspectionType()
{
var inspection = new FunctionReturnValueNotUsedInspection(null);
Assert.AreEqual(CodeInspectionType.CodeQualityIssues, inspection.InspectionType);
}
public void FunctionReturnValueNotUsed_QuickFixWorks_Interface()
{
const string inputInterfaceCode =
@"Public Function Test() As Integer
End Function";
const string expectedInterfaceCode =
@"Public Sub Test()
End Sub";
const string inputImplementationCode1 =
@"Implements IFoo
Public Function IFoo_Test() As Integer
IFoo_Test = 42
End Function";
const string expectedImplementationCode1 =
@"Implements IFoo
Public Sub IFoo_Test()
End Sub";
const string inputImplementationCode2 =
@"Implements IFoo
Public Function IFoo_Test() As Integer
IFoo_Test = 42
End Function";
const string expectedImplementationCode2 =
@"Implements IFoo
Public Sub IFoo_Test()
End Sub";
const string callSiteCode =
@"
Public Function Baz()
Dim testObj As IFoo
Set testObj = new Bar()
testObj.Test
End Function";
//Arrange
var builder = new MockVbeBuilder();
var projectBuilder = builder.ProjectBuilder("TestProject", vbext_ProjectProtection.vbext_pp_none);
projectBuilder.AddComponent("IFoo", vbext_ComponentType.vbext_ct_ClassModule, inputInterfaceCode);
projectBuilder.AddComponent("Bar", vbext_ComponentType.vbext_ct_ClassModule, inputImplementationCode1);
projectBuilder.AddComponent("Bar2", vbext_ComponentType.vbext_ct_ClassModule, inputImplementationCode2);
projectBuilder.AddComponent("TestModule", vbext_ComponentType.vbext_ct_StdModule, callSiteCode);
var vbe = projectBuilder.MockVbeBuilder().Build();
var mockHost = new Mock<IHostApplication>();
mockHost.SetupAllProperties();
var parser = MockParser.Create(vbe.Object, new RubberduckParserState());
parser.Parse();
if (parser.State.Status == ParserState.Error) { Assert.Inconclusive("Parser Error"); }
var inspection = new FunctionReturnValueNotUsedInspection(parser.State);
var inspectionResults = inspection.GetInspectionResults();
inspectionResults.First().QuickFixes.First().Fix();
var project = vbe.Object.VBProjects.Item(0);
var interfaceModule = project.VBComponents.Item(0).CodeModule;
string actualInterface = interfaceModule.Lines();
Assert.AreEqual(expectedInterfaceCode, actualInterface, "Interface");
var implementationModule1 = project.VBComponents.Item(1).CodeModule;
string actualImplementation1 = implementationModule1.Lines();
//Assert.AreEqual(expectedImplementationCode1, actualImplementation1, "Implementation1");
var implementationModule2 = project.VBComponents.Item(2).CodeModule;
string actualImplementation2 = implementationModule2.Lines();
//Assert.AreEqual(expectedImplementationCode2, actualImplementation2, "Implementation2");
}
public void FunctionReturnValueNotUsed_QuickFixWorks_NoInterface()
{
const string inputCode =
@"Public Function Foo(ByVal bar As String) As Boolean
If True Then
Foo = _
True
Else
Foo = False
End If
End Function";
const string expectedCode =
@"Public Sub Foo(ByVal bar As String)
If True Then
Else
End If
End Sub";
//Arrange
var builder = new MockVbeBuilder();
VBComponent component;
var vbe = builder.BuildFromSingleStandardModule(inputCode, out component);
var project = vbe.Object.VBProjects.Item(0);
var module = project.VBComponents.Item(0).CodeModule;
var mockHost = new Mock<IHostApplication>();
mockHost.SetupAllProperties();
var parser = MockParser.Create(vbe.Object, new RubberduckParserState());
parser.Parse();
if (parser.State.Status == ParserState.Error) { Assert.Inconclusive("Parser Error"); }
var inspection = new FunctionReturnValueNotUsedInspection(parser.State);
var inspectionResults = inspection.GetInspectionResults();
inspectionResults.First().QuickFixes.First().Fix();
string actual = module.Lines();
Assert.AreEqual(expectedCode, actual);
}
public void FunctionReturnValueNotUsed_ReturnsResult_InterfaceMember()
{
const string interfaceCode =
@"Public Function Test() As Integer
End Function";
const string implementationCode =
@"Implements IFoo
Public Function IFoo_Test() As Integer
IFoo_Test = 42
End Function";
const string callSiteCode =
@"
Public Sub Baz()
Dim testObj As IFoo
Set testObj = new Bar()
testObj.Test
End Sub";
//Arrange
var builder = new MockVbeBuilder();
var projectBuilder = builder.ProjectBuilder("TestProject", vbext_ProjectProtection.vbext_pp_none);
projectBuilder.AddComponent("IFoo", vbext_ComponentType.vbext_ct_ClassModule, interfaceCode);
projectBuilder.AddComponent("Bar", vbext_ComponentType.vbext_ct_ClassModule, implementationCode);
projectBuilder.AddComponent("TestModule", vbext_ComponentType.vbext_ct_StdModule, callSiteCode);
var vbe = projectBuilder.MockVbeBuilder().Build();
var mockHost = new Mock<IHostApplication>();
mockHost.SetupAllProperties();
var parser = MockParser.Create(vbe.Object, new RubberduckParserState());
parser.Parse();
if (parser.State.Status == ParserState.Error) { Assert.Inconclusive("Parser Error"); }
var inspection = new FunctionReturnValueNotUsedInspection(parser.State);
var inspectionResults = inspection.GetInspectionResults();
Assert.AreEqual(1, inspectionResults.Count());
}
public void FunctionReturnValueNotUsed_DoesNotReturnResult_IgnoresBuiltInFunctions()
{
const string inputCode =
@"Public Sub Dummy()
MsgBox ""Test""
Workbooks.Add
End Sub";
//Arrange
var builder = new MockVbeBuilder();
VBComponent component;
var vbe = builder.BuildFromSingleStandardModule(inputCode, out component);
var mockHost = new Mock<IHostApplication>();
mockHost.SetupAllProperties();
var parser = MockParser.Create(vbe.Object, new RubberduckParserState());
parser.Parse();
if (parser.State.Status == ParserState.Error) { Assert.Inconclusive("Parser Error"); }
var inspection = new FunctionReturnValueNotUsedInspection(parser.State);
var inspectionResults = inspection.GetInspectionResults();
Assert.AreEqual(0, inspectionResults.Count());
}