public List <User> findUserListByDepartmentId(int departmentId, string departmentName) { List <User> userList = new List <User>(); Department department = new Department(); department.Name = departmentName; // 传参,减少内部的new Department 操作 DataSet dataset = DepartmentDao.GetInstance().findUserListByDepartmentId(departmentId); if ((dataset != null) && (dataset.Tables[0].Rows.Count > 0)) { for (int i = 0; i < dataset.Tables[0].Rows.Count; i++) { User user = new User(); user.Name = dataset.Tables[0].Rows[i]["name"].ToString().Trim(); user.Id = Convert.ToInt32(dataset.Tables[0].Rows[i]["id"].ToString()); user.Department = department; if (Convert.ToInt32(dataset.Tables[0].Rows[i]["id"].ToString()) == 1) // 1 -- 男 2--女 { user.Sex = "男"; } else { user.Sex = "女"; } user.Telephone = dataset.Tables[0].Rows[i]["telephone"].ToString().Trim(); user.Remarks = dataset.Tables[0].Rows[i]["remarks"].ToString().Trim(); userList.Add(user); } } return(userList); }