private IEnumerable <TableDefinitionChanges> DetectTableDefinitionChanges(IEnumerable <TableDefinition> existingTableDefinitions, IEnumerable <TableDefinition> newTableDefinitions)
{
IList <TableDefinitionChanges> allTableDefinitionChanges = new List <TableDefinitionChanges>();
foreach (TableDefinition newTableDefinition in newTableDefinitions)
{
string tableDefinitionId = newTableDefinition.Id;
TableDefinition existingTableDefinition = existingTableDefinitions.FirstOrDefault(m => m.Id == tableDefinitionId);
TableDefinitionChanges tableDefinitionChanges = new TableDefinitionChanges
{
TableDefinition = newTableDefinition,
};
if (existingTableDefinition != null)
{
if (newTableDefinition.Name != existingTableDefinition.Name)
{
tableDefinitionChanges.ChangeTypes.Add(TableDefinitionChangeType.DefinitionName);
}
tableDefinitionChanges.FieldChanges.AddRange(DetectFieldDefinitionChanges(existingTableDefinition, newTableDefinition));
if (tableDefinitionChanges.HasChanges)
{
allTableDefinitionChanges.Add(tableDefinitionChanges);
}
}
}
return(allTableDefinitionChanges);
}
public void ProcessChanges_GivenChangeModelWithFieldNameChangesButNoRelationshipsFound_ThrowsRetriableException()
{
//Arrange
string definitionId = "df-id-1";
string specificationId = "spec-1";
DatasetDefinitionChanges datasetDefinitionChanges = new DatasetDefinitionChanges
{
Id = definitionId,
};
FieldDefinitionChanges fieldDefinitionChanges = new FieldDefinitionChanges
{
FieldDefinition = new FieldDefinition
{
Id = "field1"
}
};
fieldDefinitionChanges.ChangeTypes.Add(FieldDefinitionChangeType.FieldName);
TableDefinitionChanges tableDefinitionChanges = new TableDefinitionChanges();
tableDefinitionChanges.FieldChanges.Add(fieldDefinitionChanges);
datasetDefinitionChanges.TableDefinitionChanges.Add(tableDefinitionChanges);
string json = JsonConvert.SerializeObject(datasetDefinitionChanges);
Message message = new Message(Encoding.UTF8.GetBytes(json));
ILogger logger = CreateLogger();
IEnumerable <string> relationshipSpecificationIds = new[] { specificationId };
IDatasetsApiClient datasetRepository = CreateDatasetRepository();
datasetRepository
.GetSpecificationIdsForRelationshipDefinitionId(Arg.Is(definitionId))
.Returns(new ApiResponse <IEnumerable <string> >(HttpStatusCode.OK, relationshipSpecificationIds));
datasetRepository
.GetCurrentRelationshipsBySpecificationIdAndDatasetDefinitionId(Arg.Is(specificationId), Arg.Is(definitionId))
.Returns(new ApiResponse <IEnumerable <Common.ApiClient.DataSets.Models.DatasetSpecificationRelationshipViewModel> >(HttpStatusCode.OK, Enumerable.Empty <Common.ApiClient.DataSets.Models.DatasetSpecificationRelationshipViewModel>()));
DatasetDefinitionFieldChangesProcessor processor = CreateProcessor(logger: logger, datasetRepository: datasetRepository);
//Act
Func <Task> test = async() => await processor.Run(message);
//Assert
test
.Should()
.ThrowExactly <RetriableException>()
.Which
.Message
.Should()
.Be($"No relationships found for specificationId '{specificationId}' and dataset definition id '{definitionId}'");
}
public async Task ProcessChanges_GivenChangeModelWithFieldChangesButNoRelationshipsExist_LogsAndReturns()
{
//Arrange
string definitionId = "df-id-1";
DatasetDefinitionChanges datasetDefinitionChanges = new DatasetDefinitionChanges
{
Id = definitionId,
};
FieldDefinitionChanges fieldDefinitionChanges = new FieldDefinitionChanges();
fieldDefinitionChanges.ChangeTypes.Add(FieldDefinitionChangeType.FieldName);
TableDefinitionChanges tableDefinitionChanges = new TableDefinitionChanges();
tableDefinitionChanges.FieldChanges.Add(fieldDefinitionChanges);
datasetDefinitionChanges.TableDefinitionChanges.Add(tableDefinitionChanges);
string json = JsonConvert.SerializeObject(datasetDefinitionChanges);
Message message = new Message(Encoding.UTF8.GetBytes(json));
ILogger logger = CreateLogger();
IDatasetsApiClient datasetRepository = CreateDatasetRepository();
datasetRepository
.GetSpecificationIdsForRelationshipDefinitionId(Arg.Is(definitionId))
//.Returns(Enumerable.Empty<string>());
.Returns(new ApiResponse <IEnumerable <string> >(HttpStatusCode.OK, Enumerable.Empty <string>()));
DatasetDefinitionFieldChangesProcessor processor = CreateProcessor(logger: logger, datasetRepository: datasetRepository);
//Act
await processor.Process(message);
//Assert
logger
.Received(1)
.Information(Arg.Is($"No dataset definition specification relationships exists for definition id '{definitionId}'"));
}
async public Task SaveDefinition_GivenUpdatedYamlWithChangedIdentifierTypeFieldButAlreadyUsedInRelationship_ReturnsBadRequest()
{
//Arrange
IEnumerable <string> specificationIds = new[] { "spec-1" };
string definitionId = "9183";
string yaml = CreateRawDefinition();
byte[] byteArray = Encoding.UTF8.GetBytes(yaml);
MemoryStream stream = new MemoryStream(byteArray);
IHeaderDictionary headerDictionary = new HeaderDictionary();
headerDictionary
.Add("yaml-file", new StringValues(yamlFile));
HttpRequest request = Substitute.For <HttpRequest>();
request
.Headers
.Returns(headerDictionary);
request
.Body
.Returns(stream);
ILogger logger = CreateLogger();
IDatasetRepository datasetRepository = CreateDataSetsRepository();
datasetRepository
.GetDistinctRelationshipSpecificationIdsForDatasetDefinitionId(Arg.Is(definitionId))
.Returns(specificationIds);
datasetRepository
.GetDatasetDefinition(Arg.Is(definitionId))
.Returns(new DatasetDefinition());
DatasetDefinitionChanges datasetDefinitionChanges = new DatasetDefinitionChanges
{
Id = definitionId,
};
FieldDefinitionChanges fieldDefinitionChanges = new FieldDefinitionChanges();
fieldDefinitionChanges.ChangeTypes.Add(FieldDefinitionChangeType.IdentifierType);
TableDefinitionChanges tableDefinitionChanges = new TableDefinitionChanges();
tableDefinitionChanges.FieldChanges.Add(fieldDefinitionChanges);
datasetDefinitionChanges.TableDefinitionChanges.Add(tableDefinitionChanges);
IDefinitionChangesDetectionService definitionChangesDetectionService = CreateChangesDetectionService();
definitionChangesDetectionService
.DetectChanges(Arg.Any <DatasetDefinition>(), Arg.Any <DatasetDefinition>())
.Returns(datasetDefinitionChanges);
DefinitionsService service = CreateDefinitionsService(logger, definitionChangesDetectionService: definitionChangesDetectionService, datasetsRepository: datasetRepository);
//Act
IActionResult result = await service.SaveDefinition(request);
//Assert
result
.Should()
.BeOfType <BadRequestObjectResult>()
.Which
.Value
.Should()
.Be("Unable to change provider identifier as there are currently relationships setup against this schema");
}
public async Task ProcessChanges_GivenChangeModelWithMultipleFieldNameChanges_CallsResetCalculationForFieldDefinitionChanges()
{
//Arrange
string definitionId = "df-id-1";
string specificationId = "spec-1";
DatasetDefinitionChanges datasetDefinitionChanges = new DatasetDefinitionChanges
{
Id = definitionId,
};
FieldDefinitionChanges fieldDefinitionChanges1 = new FieldDefinitionChanges
{
FieldDefinition = new FieldDefinition
{
Id = "field1"
},
ExistingFieldDefinition = new FieldDefinition {
Name = "test field 1"
}
};
FieldDefinitionChanges fieldDefinitionChanges2 = new FieldDefinitionChanges
{
FieldDefinition = new FieldDefinition
{
Id = "field2"
},
ExistingFieldDefinition = new FieldDefinition {
Name = "test field 2"
}
};
fieldDefinitionChanges1.ChangeTypes.Add(FieldDefinitionChangeType.FieldName);
fieldDefinitionChanges2.ChangeTypes.Add(FieldDefinitionChangeType.FieldName);
TableDefinitionChanges tableDefinitionChanges = new TableDefinitionChanges();
tableDefinitionChanges.FieldChanges.AddRange(new[] { fieldDefinitionChanges1, fieldDefinitionChanges2 });
datasetDefinitionChanges.TableDefinitionChanges.Add(tableDefinitionChanges);
string json = JsonConvert.SerializeObject(datasetDefinitionChanges);
Message message = new Message(Encoding.UTF8.GetBytes(json));
ILogger logger = CreateLogger();
IEnumerable <string> relationshipSpecificationIds = new[] { specificationId };
IEnumerable <DatasetSpecificationRelationshipViewModel> relationshipViewModels = new[]
{
new DatasetSpecificationRelationshipViewModel()
};
IDatasetRepository datasetRepository = CreateDatasetRepository();
datasetRepository
.GetRelationshipSpecificationIdsByDatasetDefinitionId(Arg.Is(definitionId))
.Returns(relationshipSpecificationIds);
datasetRepository
.GetCurrentRelationshipsBySpecificationIdAndDatasetDefinitionId(Arg.Is(specificationId), Arg.Is(definitionId))
.Returns(relationshipViewModels);
ICalculationService calculationService = CreateCalculationService();
DatasetDefinitionFieldChangesProcessor processor = CreateProcessor(
logger: logger,
datasetRepository: datasetRepository,
calculationService: calculationService);
//Act
await processor.ProcessChanges(message);
//Assert
await
calculationService
.Received(1)
.ResetCalculationForFieldDefinitionChanges(Arg.Is(relationshipViewModels), Arg.Is(specificationId),
Arg.Is <IEnumerable <string> >(
m =>
m.Count() == 2 &&
m.ElementAt(0) == "test field 1" &&
m.ElementAt(1) == "test field 2"));
}
public async Task ProcessChanges_GivenChangeModelWithAggregableFieldChangesButNoAggregateParanetersFound_DoesNotResetCalculationForFieldDefinitionChanges(FieldDefinitionChangeType fieldDefinitionChangeType)
{
//Arrange
string definitionId = "df-id-1";
string specificationId = "spec-1";
IEnumerable <Calculation> calculations = new[]
{
new Calculation
{
Current = new CalculationVersion
{
SourceCode = "return 2 + Datasets.TestRelationship.TestField1"
}
}
};
DatasetDefinitionChanges datasetDefinitionChanges = new DatasetDefinitionChanges
{
Id = definitionId,
};
FieldDefinitionChanges fieldDefinitionChanges = new FieldDefinitionChanges
{
FieldDefinition = new FieldDefinition
{
Id = "field1"
},
ExistingFieldDefinition = new FieldDefinition {
Name = "test field 1"
}
};
fieldDefinitionChanges.ChangeTypes.Add(fieldDefinitionChangeType);
TableDefinitionChanges tableDefinitionChanges = new TableDefinitionChanges();
tableDefinitionChanges.FieldChanges.Add(fieldDefinitionChanges);
datasetDefinitionChanges.TableDefinitionChanges.Add(tableDefinitionChanges);
string json = JsonConvert.SerializeObject(datasetDefinitionChanges);
Message message = new Message(Encoding.UTF8.GetBytes(json));
ILogger logger = CreateLogger();
IEnumerable <string> relationshipSpecificationIds = new[] { specificationId };
IEnumerable <DatasetSpecificationRelationshipViewModel> relationshipViewModels = new[]
{
new DatasetSpecificationRelationshipViewModel
{
Name = "Test Relationship"
}
};
IDatasetRepository datasetRepository = CreateDatasetRepository();
datasetRepository
.GetRelationshipSpecificationIdsByDatasetDefinitionId(Arg.Is(definitionId))
.Returns(relationshipSpecificationIds);
datasetRepository
.GetCurrentRelationshipsBySpecificationIdAndDatasetDefinitionId(Arg.Is(specificationId), Arg.Is(definitionId))
.Returns(relationshipViewModels);
ICalculationService calculationService = CreateCalculationService();
ICalculationsRepository calculationsRepository = CreateCalculationsRepository();
calculationsRepository
.GetCalculationsBySpecificationId(Arg.Is(specificationId))
.Returns(calculations);
DatasetDefinitionFieldChangesProcessor processor = CreateProcessor(
logger: logger,
datasetRepository: datasetRepository,
calculationService: calculationService,
calculationsRepository: calculationsRepository);
//Act
await processor.ProcessChanges(message);
//Assert
await
calculationService
.DidNotReceive()
.ResetCalculationForFieldDefinitionChanges(Arg.Any <IEnumerable <DatasetSpecificationRelationshipViewModel> >(), Arg.Any <string>(), Arg.Any <IEnumerable <string> >());
}
public async Task ProcessChanges_GivenChangeModelWithAggregableFieldChanges_CallsResetCalculationForFieldDefinitionChanges(FieldDefinitionChangeType fieldDefinitionChangeType)
{
//Arrange
string definitionId = "df-id-1";
string specificationId = "spec-1";
IEnumerable <Calculation> calculations = new[]
{
new Calculation
{
Current = new CalculationVersion
{
SourceCode = "return Sum(Datasets.TestRelationship.TestField1)"
}
}
};
DatasetDefinitionChanges datasetDefinitionChanges = new DatasetDefinitionChanges
{
Id = definitionId,
};
FieldDefinitionChanges fieldDefinitionChanges = new FieldDefinitionChanges
{
FieldDefinition = new FieldDefinition
{
Id = "field1"
},
ExistingFieldDefinition = new FieldDefinition {
Name = "test field 1"
}
};
fieldDefinitionChanges.ChangeTypes.Add(fieldDefinitionChangeType);
TableDefinitionChanges tableDefinitionChanges = new TableDefinitionChanges();
tableDefinitionChanges.FieldChanges.Add(fieldDefinitionChanges);
datasetDefinitionChanges.TableDefinitionChanges.Add(tableDefinitionChanges);
string json = JsonConvert.SerializeObject(datasetDefinitionChanges);
Message message = new Message(Encoding.UTF8.GetBytes(json));
ILogger logger = CreateLogger();
IEnumerable <string> relationshipSpecificationIds = new[] { specificationId };
IEnumerable <Common.ApiClient.DataSets.Models.DatasetSpecificationRelationshipViewModel> relationshipViewModels = new[]
{
new Common.ApiClient.DataSets.Models.DatasetSpecificationRelationshipViewModel
{
Name = "Test Relationship"
}
};
IEnumerable <DatasetSpecificationRelationshipViewModel> relationshipViewModel = new[]
{
new DatasetSpecificationRelationshipViewModel
{
Name = "Test Relationship"
}
};
IDatasetsApiClient datasetRepository = CreateDatasetRepository();
datasetRepository
.GetSpecificationIdsForRelationshipDefinitionId(Arg.Is(definitionId))
.Returns(new ApiResponse <IEnumerable <string> >(HttpStatusCode.OK, relationshipSpecificationIds));
datasetRepository
.GetCurrentRelationshipsBySpecificationIdAndDatasetDefinitionId(Arg.Is(specificationId), Arg.Is(definitionId))
.Returns(new ApiResponse <IEnumerable <Common.ApiClient.DataSets.Models.DatasetSpecificationRelationshipViewModel> >(HttpStatusCode.OK, relationshipViewModels));
ICalculationService calculationService = CreateCalculationService();
ICalculationsRepository calculationsRepository = CreateCalculationsRepository();
calculationsRepository
.GetCalculationsBySpecificationId(Arg.Is(specificationId))
.Returns(calculations);
IMapper mapper = CreateMapper();
DatasetDefinitionFieldChangesProcessor processor = CreateProcessor(
logger: logger,
datasetRepository: datasetRepository,
calculationService: calculationService,
calculationsRepository: calculationsRepository,
mapper: mapper);
//Act
await processor.Run(message);
//Assert
await
calculationService
.Received(1)
.ResetCalculationForFieldDefinitionChanges(Arg.Is <IEnumerable <Models.Datasets.ViewModels.DatasetSpecificationRelationshipViewModel> >(_ => _.First().Id == relationshipViewModel.First().Id), Arg.Is(specificationId), Arg.Is <IEnumerable <string> >(m => m.First() == "test field 1"));
}
