public async Task MsbuildRestore_PackageReferenceDependencyCsProjAsync()
{
// Arrange
using (var pathContext = new SimpleTestPathContext())
{
// Set up solution, project, and packages
var solution = new SimpleTestSolutionContext(pathContext.SolutionRoot);
var net461 = NuGetFramework.Parse("net461");
var projectA = new SimpleTestProjectContext(
"a",
ProjectStyle.PackageReference,
pathContext.SolutionRoot);
projectA.Frameworks.Add(new SimpleTestProjectFrameworkContext(net461));
var packageX = new SimpleTestPackageContext()
{
Id = "x",
Version = "1.0.0"
};
packageX.Files.Clear();
projectA.AddPackageToAllFrameworks(packageX);
packageX.AddFile("lib/net461/a.dll");
solution.Projects.Add(projectA);
solution.Create(pathContext.SolutionRoot);
var configAPath = Path.Combine(Path.GetDirectoryName(projectA.ProjectPath), "NuGet.Config");
var configText =
$@"<?xml version=""1.0"" encoding=""utf-8""?>
<configuration>
<packageSources>
<add key=""LocalSource"" value=""{pathContext.PackageSource}"" />
</packageSources>
</configuration>";
using (var writer = new StreamWriter(configAPath))
{
writer.Write(configText);
}
await SimpleTestPackageUtility.CreateFolderFeedV3Async(
pathContext.PackageSource,
packageX);
// Act
var result = _msbuildFixture.RunMsBuild(pathContext.WorkingDirectory, $"/t:restore {projectA.ProjectPath}", ignoreExitCode: true);
// Assert
Assert.True(result.ExitCode == 0, result.AllOutput);
var resolver = new VersionFolderPathResolver(pathContext.UserPackagesFolder);
var nupkg = NupkgMetadataFileFormat.Read(resolver.GetNupkgMetadataPath(packageX.Id, NuGetVersion.Parse(packageX.Version)), NullLogger.Instance);
Assert.Contains($"Installed x 1.0.0 from {pathContext.PackageSource} with content hash {nupkg.ContentHash}.", result.AllOutput);
Assert.Contains(configAPath, result.AllOutput);
}
}
public async Task Restore_TamperedPackageInPackagesConfig_FailsWithErrorAsync()
{
// Arrange
var nupkg = new SimpleTestPackageContext("A", "1.0.0");
var packagesConfigContent = "<?xml version=\"1.0\" encoding=\"utf-8\"?>" +
"<packages>" +
" <package id=\"X\" version=\"9.0.0\" targetFramework=\"net461\" />" +
"</packages>";
using (var pathContext = new SimpleTestPathContext())
using (var testCertificate = new X509Certificate2(_trustedTestCert.Source.Cert))
{
// Set up solution, project, and packages
var solution = new SimpleTestSolutionContext(pathContext.SolutionRoot);
var projectA = new SimpleTestProjectContext(
"a",
ProjectStyle.PackagesConfig,
pathContext.SolutionRoot);
var packageX = new SimpleTestPackageContext("X", "9.0.0");
var signedPackagePath = await SignedArchiveTestUtility.AuthorSignPackageAsync(testCertificate, packageX, pathContext.PackageSource);
SignedArchiveTestUtility.TamperWithPackage(signedPackagePath);
projectA.AddPackageToAllFrameworks(packageX);
solution.Projects.Add(projectA);
solution.Create(pathContext.SolutionRoot);
var packagesConfigPath = Path.Combine(Directory.GetParent(projectA.ProjectPath).FullName, "packages.config");
File.WriteAllBytes(packagesConfigPath, Encoding.ASCII.GetBytes(packagesConfigContent));
var args = new string[]
{
projectA.ProjectPath,
"-Source",
pathContext.PackageSource,
"-PackagesDirectory",
"./packages"
};
// Act
var result = RunRestore(_nugetExePath, pathContext, expectedExitCode: 1, additionalArgs: args);
// Assert
result.ExitCode.Should().Be(1);
result.Errors.Should().Contain(_NU3008);
result.AllOutput.Should().Contain(_NU3027);
}
}
public async Task MsbuildRestore_WithStaticGraphAndRegularRestore_ErrorLoggedWhenOutputPathNotSpecified()
{
// Arrange
using (var pathContext = new SimpleTestPathContext())
{
// Set up solution, project, and packages
var solution = new SimpleTestSolutionContext(pathContext.SolutionRoot);
var net461 = NuGetFramework.Parse("net461");
var project = new SimpleTestProjectContext("a", ProjectStyle.PackageReference, pathContext.SolutionRoot)
{
ProjectExtensionsPath = string.Empty,
Properties =
{
// When these two properties are not defined, restore should fail with a clear error and not crash
["MSBuildProjectExtensionsPath"] = string.Empty,
["RestoreOutputPath"] = string.Empty
},
SetMSBuildProjectExtensionsPath = false,
SingleTargetFramework = true
};
project.Frameworks.Add(new SimpleTestProjectFrameworkContext(net461));
var packageX = new SimpleTestPackageContext
{
Id = "x",
Version = "1.0.0"
};
packageX.Files.Clear();
project.AddPackageToAllFrameworks(packageX);
packageX.AddFile("lib/net461/a.dll");
solution.Projects.Add(project);
solution.Create(pathContext.SolutionRoot);
await SimpleTestPackageUtility.CreateFolderFeedV3Async(
pathContext.PackageSource,
packageX);
// Restore the project with a PackageReference which generates assets
var result = _msbuildFixture.RunMsBuild(pathContext.WorkingDirectory, $"/t:restore /p:RestoreUseStaticGraphEvaluation=true {project.ProjectPath}", ignoreExitCode: true);
result.Success.Should().BeFalse(because: result.AllOutput);
result.AllOutput.Should().Contain($"error : Invalid restore input. Missing required property 'OutputPath' for project type 'PackageReference'. Input files: {project.ProjectPath}.");
}
}
public async Task MsbuildRestore_StaticGraphEvaluation_CleanupAssetsForUnsupportedProjectsAsync(bool cleanupAssetsForUnsupportedProjects)
{
// Arrange
using (var pathContext = new SimpleTestPathContext())
{
// Set up solution, project, and packages
var solution = new SimpleTestSolutionContext(pathContext.SolutionRoot);
var net461 = NuGetFramework.Parse("net461");
var projectA = new SimpleTestProjectContext(
"a",
ProjectStyle.PackageReference,
pathContext.SolutionRoot);
projectA.Frameworks.Add(new SimpleTestProjectFrameworkContext(net461));
var packageX = new SimpleTestPackageContext()
{
Id = "x",
Version = "1.0.0"
};
packageX.Files.Clear();
projectA.AddPackageToAllFrameworks(packageX);
packageX.AddFile("lib/net461/a.dll");
solution.Projects.Add(projectA);
solution.Create(pathContext.SolutionRoot);
var configAPath = Path.Combine(Path.GetDirectoryName(projectA.ProjectPath), "NuGet.Config");
var configText =
$@"<?xml version=""1.0"" encoding=""utf-8""?>
<configuration>
<packageSources>
<add key=""LocalSource"" value=""{pathContext.PackageSource}"" />
</packageSources>
</configuration>";
using (var writer = new StreamWriter(configAPath))
{
writer.Write(configText);
}
await SimpleTestPackageUtility.CreateFolderFeedV3Async(
pathContext.PackageSource,
packageX);
// Restore the project with a PackageReference which generates assets
var result = _msbuildFixture.RunMsBuild(pathContext.WorkingDirectory, $"/t:restore /p:RestoreUseStaticGraphEvaluation=true /p:RestoreCleanupAssetsForUnsupportedProjects={cleanupAssetsForUnsupportedProjects} {projectA.ProjectPath}", ignoreExitCode: true);
Assert.True(result.ExitCode == 0, result.AllOutput);
var assets = new[]
{
projectA.AssetsFileOutputPath,
projectA.PropsOutput,
projectA.TargetsOutput,
projectA.CacheFileOutputPath,
};
foreach (var asset in assets)
{
Assert.True(File.Exists(asset), result.AllOutput);
}
// Recreate the project with Unknown project style and no PackageReferences
projectA = new SimpleTestProjectContext(
"a",
ProjectStyle.Unknown,
pathContext.SolutionRoot);
projectA.Frameworks.Add(new SimpleTestProjectFrameworkContext(net461));
projectA.Save();
// Restore the project with a PackageReference which generates assets
result = _msbuildFixture.RunMsBuild(pathContext.WorkingDirectory, $"/t:restore /p:RestoreUseStaticGraphEvaluation=true /p:RestoreCleanupAssetsForUnsupportedProjects={cleanupAssetsForUnsupportedProjects} {projectA.ProjectPath}", ignoreExitCode: true);
// Assert
Assert.True(result.ExitCode == 0, result.AllOutput);
foreach (var asset in assets)
{
if (cleanupAssetsForUnsupportedProjects)
{
Assert.False(File.Exists(asset), result.AllOutput);
}
else
{
Assert.True(File.Exists(asset), result.AllOutput);
}
}
}
}
public async Task MsbuildRestore_PR_PackageSourceMapping_WithNotEnoughRestoreSourceProperty_Fails()
{
// Arrange
using var pathContext = new SimpleTestPathContext();
// Set up solution, project, and packages
var solution = new SimpleTestSolutionContext(pathContext.SolutionRoot);
var workingPath = pathContext.WorkingDirectory;
var opensourceRepositoryPath = Path.Combine(workingPath, "PublicRepository");
Directory.CreateDirectory(opensourceRepositoryPath);
var privateRepositoryPath = Path.Combine(workingPath, "PrivateRepository");
Directory.CreateDirectory(privateRepositoryPath);
var net461 = NuGetFramework.Parse("net461");
var projectA = new SimpleTestProjectContext(
"a",
ProjectStyle.PackageReference,
pathContext.SolutionRoot);
projectA.Frameworks.Add(new SimpleTestProjectFrameworkContext(net461));
// Add only 1 repository as RestoreSources
projectA.Properties.Add("RestoreSources", $"{opensourceRepositoryPath}");
var packageOpenSourceA = new SimpleTestPackageContext("Contoso.Opensource.A", "1.0.0");
packageOpenSourceA.AddFile("lib/net461/openA.dll");
var packageOpenSourceContosoMvc = new SimpleTestPackageContext("Contoso.MVC.ASP", "1.0.0"); // Package Id conflict with internally created package
packageOpenSourceContosoMvc.AddFile("lib/net461/openA.dll");
var packageContosoMvcReal = new SimpleTestPackageContext("Contoso.MVC.ASP", "1.0.0");
packageContosoMvcReal.AddFile("lib/net461/realA.dll");
projectA.AddPackageToAllFrameworks(packageOpenSourceA);
projectA.AddPackageToAllFrameworks(packageOpenSourceContosoMvc);
solution.Projects.Add(projectA);
solution.Create(pathContext.SolutionRoot);
// SimpleTestPathContext adds a NuGet.Config with a repositoryPath,
// so we go ahead and replace that config before running MSBuild.
var configAPath = Path.Combine(Path.GetDirectoryName(projectA.ProjectPath), "NuGet.Config");
var configText =
$@"<?xml version=""1.0"" encoding=""utf-8""?>
<configuration>
<packageSources>
<!--To inherit the global NuGet package sources remove the <clear/> line below -->
<clear />
<add key=""PublicRepository"" value=""{opensourceRepositoryPath}"" />
<add key=""PrivateRepository"" value=""{privateRepositoryPath}"" />
</packageSources>
<packageSourceMapping>
<packageSource key=""PublicRepository"">
<package pattern=""Contoso.Opensource.*"" />
</packageSource>
<packageSource key=""PrivateRepository"">
<package pattern=""Contoso.MVC.*"" /> <!--Contoso.MVC.ASP package exist in both repository but it'll restore from this one -->
</packageSource>
</packageSourceMapping>
</configuration>";
using (var writer = new StreamWriter(configAPath))
{
writer.Write(configText);
}
await SimpleTestPackageUtility.CreateFolderFeedV3Async(
opensourceRepositoryPath,
packageOpenSourceA,
packageOpenSourceContosoMvc);
await SimpleTestPackageUtility.CreateFolderFeedV3Async(
privateRepositoryPath,
packageContosoMvcReal);
// Act
var r = _msbuildFixture.RunMsBuild(pathContext.WorkingDirectory, $"/t:restore -v:d {pathContext.SolutionRoot}", ignoreExitCode: true);
// Assert
Assert.True(r.ExitCode == 1);
Assert.Contains($"Package source mapping match not found for package ID 'Contoso.MVC.ASP'.", r.Output);
Assert.Contains($"Package source mapping matches found for package ID 'Contoso.Opensource.A' are: 'PublicRepository'", r.Output);
}