public void ProcessChanges_GivenChangeModelWithFieldNameChangesButNoRelationshipsFound_ThrowsRetriableException()
{
//Arrange
string definitionId = "df-id-1";
string specificationId = "spec-1";
DatasetDefinitionChanges datasetDefinitionChanges = new DatasetDefinitionChanges
{
Id = definitionId,
};
FieldDefinitionChanges fieldDefinitionChanges = new FieldDefinitionChanges
{
FieldDefinition = new FieldDefinition
{
Id = "field1"
}
};
fieldDefinitionChanges.ChangeTypes.Add(FieldDefinitionChangeType.FieldName);
TableDefinitionChanges tableDefinitionChanges = new TableDefinitionChanges();
tableDefinitionChanges.FieldChanges.Add(fieldDefinitionChanges);
datasetDefinitionChanges.TableDefinitionChanges.Add(tableDefinitionChanges);
string json = JsonConvert.SerializeObject(datasetDefinitionChanges);
Message message = new Message(Encoding.UTF8.GetBytes(json));
ILogger logger = CreateLogger();
IEnumerable <string> relationshipSpecificationIds = new[] { specificationId };
IDatasetRepository datasetRepository = CreateDatasetRepository();
datasetRepository
.GetRelationshipSpecificationIdsByDatasetDefinitionId(Arg.Is(definitionId))
.Returns(relationshipSpecificationIds);
datasetRepository
.GetCurrentRelationshipsBySpecificationIdAndDatasetDefinitionId(Arg.Is(specificationId), Arg.Is(definitionId))
.Returns(Enumerable.Empty <DatasetSpecificationRelationshipViewModel>());
DatasetDefinitionFieldChangesProcessor processor = CreateProcessor(logger: logger, datasetRepository: datasetRepository);
//Act
Func <Task> test = async() => await processor.ProcessChanges(message);
//Assert
test
.Should()
.ThrowExactly <RetriableException>()
.Which
.Message
.Should()
.Be($"No relationships found for specificationId '{specificationId}' and dataset definition id '{definitionId}'");
}
public async Task ProcessChanges_GivenChangeModelWithFieldChangesButNoRelationshipsExist_LogsAndReturns()
{
//Arrange
string definitionId = "df-id-1";
DatasetDefinitionChanges datasetDefinitionChanges = new DatasetDefinitionChanges
{
Id = definitionId,
};
FieldDefinitionChanges fieldDefinitionChanges = new FieldDefinitionChanges();
fieldDefinitionChanges.ChangeTypes.Add(FieldDefinitionChangeType.FieldName);
TableDefinitionChanges tableDefinitionChanges = new TableDefinitionChanges();
tableDefinitionChanges.FieldChanges.Add(fieldDefinitionChanges);
datasetDefinitionChanges.TableDefinitionChanges.Add(tableDefinitionChanges);
string json = JsonConvert.SerializeObject(datasetDefinitionChanges);
Message message = new Message(Encoding.UTF8.GetBytes(json));
ILogger logger = CreateLogger();
IDatasetRepository datasetRepository = CreateDatasetRepository();
datasetRepository
.GetRelationshipSpecificationIdsByDatasetDefinitionId(Arg.Is(definitionId))
.Returns(Enumerable.Empty <string>());
DatasetDefinitionFieldChangesProcessor processor = CreateProcessor(logger: logger, datasetRepository: datasetRepository);
//Act
await processor.ProcessChanges(message);
//Assert
logger
.Received(1)
.Information(Arg.Is($"No dataset definition specification relationships exists for definition id '{definitionId}'"));
}
public async Task ProcessChanges_GivenChangeModelWithMultipleFieldNameChanges_CallsResetCalculationForFieldDefinitionChanges()
{
//Arrange
string definitionId = "df-id-1";
string specificationId = "spec-1";
DatasetDefinitionChanges datasetDefinitionChanges = new DatasetDefinitionChanges
{
Id = definitionId,
};
FieldDefinitionChanges fieldDefinitionChanges1 = new FieldDefinitionChanges
{
FieldDefinition = new FieldDefinition
{
Id = "field1"
},
ExistingFieldDefinition = new FieldDefinition {
Name = "test field 1"
}
};
FieldDefinitionChanges fieldDefinitionChanges2 = new FieldDefinitionChanges
{
FieldDefinition = new FieldDefinition
{
Id = "field2"
},
ExistingFieldDefinition = new FieldDefinition {
Name = "test field 2"
}
};
fieldDefinitionChanges1.ChangeTypes.Add(FieldDefinitionChangeType.FieldName);
fieldDefinitionChanges2.ChangeTypes.Add(FieldDefinitionChangeType.FieldName);
TableDefinitionChanges tableDefinitionChanges = new TableDefinitionChanges();
tableDefinitionChanges.FieldChanges.AddRange(new[] { fieldDefinitionChanges1, fieldDefinitionChanges2 });
datasetDefinitionChanges.TableDefinitionChanges.Add(tableDefinitionChanges);
string json = JsonConvert.SerializeObject(datasetDefinitionChanges);
Message message = new Message(Encoding.UTF8.GetBytes(json));
ILogger logger = CreateLogger();
IEnumerable <string> relationshipSpecificationIds = new[] { specificationId };
IEnumerable <DatasetSpecificationRelationshipViewModel> relationshipViewModels = new[]
{
new DatasetSpecificationRelationshipViewModel()
};
IDatasetRepository datasetRepository = CreateDatasetRepository();
datasetRepository
.GetRelationshipSpecificationIdsByDatasetDefinitionId(Arg.Is(definitionId))
.Returns(relationshipSpecificationIds);
datasetRepository
.GetCurrentRelationshipsBySpecificationIdAndDatasetDefinitionId(Arg.Is(specificationId), Arg.Is(definitionId))
.Returns(relationshipViewModels);
ICalculationService calculationService = CreateCalculationService();
DatasetDefinitionFieldChangesProcessor processor = CreateProcessor(
logger: logger,
datasetRepository: datasetRepository,
calculationService: calculationService);
//Act
await processor.ProcessChanges(message);
//Assert
await
calculationService
.Received(1)
.ResetCalculationForFieldDefinitionChanges(Arg.Is(relationshipViewModels), Arg.Is(specificationId),
Arg.Is <IEnumerable <string> >(
m =>
m.Count() == 2 &&
m.ElementAt(0) == "test field 1" &&
m.ElementAt(1) == "test field 2"));
}
public async Task ProcessChanges_GivenChangeModelWithAggregableFieldChangesButNoAggregateParanetersFound_DoesNotResetCalculationForFieldDefinitionChanges(FieldDefinitionChangeType fieldDefinitionChangeType)
{
//Arrange
string definitionId = "df-id-1";
string specificationId = "spec-1";
IEnumerable <Calculation> calculations = new[]
{
new Calculation
{
Current = new CalculationVersion
{
SourceCode = "return 2 + Datasets.TestRelationship.TestField1"
}
}
};
DatasetDefinitionChanges datasetDefinitionChanges = new DatasetDefinitionChanges
{
Id = definitionId,
};
FieldDefinitionChanges fieldDefinitionChanges = new FieldDefinitionChanges
{
FieldDefinition = new FieldDefinition
{
Id = "field1"
},
ExistingFieldDefinition = new FieldDefinition {
Name = "test field 1"
}
};
fieldDefinitionChanges.ChangeTypes.Add(fieldDefinitionChangeType);
TableDefinitionChanges tableDefinitionChanges = new TableDefinitionChanges();
tableDefinitionChanges.FieldChanges.Add(fieldDefinitionChanges);
datasetDefinitionChanges.TableDefinitionChanges.Add(tableDefinitionChanges);
string json = JsonConvert.SerializeObject(datasetDefinitionChanges);
Message message = new Message(Encoding.UTF8.GetBytes(json));
ILogger logger = CreateLogger();
IEnumerable <string> relationshipSpecificationIds = new[] { specificationId };
IEnumerable <DatasetSpecificationRelationshipViewModel> relationshipViewModels = new[]
{
new DatasetSpecificationRelationshipViewModel
{
Name = "Test Relationship"
}
};
IDatasetRepository datasetRepository = CreateDatasetRepository();
datasetRepository
.GetRelationshipSpecificationIdsByDatasetDefinitionId(Arg.Is(definitionId))
.Returns(relationshipSpecificationIds);
datasetRepository
.GetCurrentRelationshipsBySpecificationIdAndDatasetDefinitionId(Arg.Is(specificationId), Arg.Is(definitionId))
.Returns(relationshipViewModels);
ICalculationService calculationService = CreateCalculationService();
ICalculationsRepository calculationsRepository = CreateCalculationsRepository();
calculationsRepository
.GetCalculationsBySpecificationId(Arg.Is(specificationId))
.Returns(calculations);
DatasetDefinitionFieldChangesProcessor processor = CreateProcessor(
logger: logger,
datasetRepository: datasetRepository,
calculationService: calculationService,
calculationsRepository: calculationsRepository);
//Act
await processor.ProcessChanges(message);
//Assert
await
calculationService
.DidNotReceive()
.ResetCalculationForFieldDefinitionChanges(Arg.Any <IEnumerable <DatasetSpecificationRelationshipViewModel> >(), Arg.Any <string>(), Arg.Any <IEnumerable <string> >());
}
public async Task ProcessChanges(Message message)
{
Guard.ArgumentNotNull(message, nameof(message));
if (!_featureToggle.IsProcessDatasetDefinitionFieldChangesEnabled())
{
return;
}
DatasetDefinitionChanges datasetDefinitionChanges = message.GetPayloadAsInstanceOf <DatasetDefinitionChanges>();
_logger.Information("Checking for dataset definition changes before proceeding");
if (datasetDefinitionChanges == null)
{
throw new NonRetriableException("Message does not contain a valid dataset definition change model");
}
if (!datasetDefinitionChanges.HasChanges)
{
_logger.Information($"No dataset definition field changes for definition id '{datasetDefinitionChanges.Id}'");
return;
}
IEnumerable <FieldDefinitionChanges> fieldChanges = datasetDefinitionChanges.TableDefinitionChanges.SelectMany(m => m.FieldChanges);
if (fieldChanges.IsNullOrEmpty())
{
_logger.Information($"No dataset definition field changes for definition id '{datasetDefinitionChanges.Id}'");
return;
}
IEnumerable <string> relationshipSpecificationIds = await _datasetRepositoryPolicy.ExecuteAsync(() => _datasetRepository.GetRelationshipSpecificationIdsByDatasetDefinitionId(datasetDefinitionChanges.Id));
if (relationshipSpecificationIds.IsNullOrEmpty())
{
_logger.Information($"No dataset definition specification relationships exists for definition id '{datasetDefinitionChanges.Id}'");
return;
}
await ProcessFieldChanges(datasetDefinitionChanges.Id, fieldChanges, relationshipSpecificationIds);
}