public Task <FilteredCompletionModel?> UpdateCompletionListAsync( IAsyncCompletionSession session, AsyncCompletionSessionDataSnapshot data, CancellationToken cancellationToken) { var updater = new CompletionListUpdater(session, data, _recentItemsManager, _globalOptions); return(Task.FromResult(updater.UpdateCompletionList(cancellationToken))); }
public async Task <FilteredCompletionModel?> UpdateCompletionListAsync( IAsyncCompletionSession session, AsyncCompletionSessionDataSnapshot data, CancellationToken cancellationToken) { var stopwatch = SharedStopwatch.StartNew(); try { var sessionData = CompletionSessionData.GetOrCreateSessionData(session); // As explained in more details in the comments for `CompletionSource.GetCompletionContextAsync`, expanded items might // not be provided upon initial trigger of completion to reduce typing delays, even if they are supposed to be included by default. // While we do not expect to run in to this scenario very often, we'd still want to minimize the impact on user experience of this feature // as best as we could when it does occur. So the solution we came up with is this: if we decided to not include expanded items (because the // computation is running too long,) we will let it run in the background as long as the completion session is still active. Then whenever // any user input that would cause the completion list to refresh, we will check the state of this background task and add expanded items as part // of the update if they are available. // There is a `CompletionContext.IsIncomplete` flag, which is only supported in LSP mode at the moment. Therefore we opt to handle the checking // and combining the items in Roslyn until the `IsIncomplete` flag is fully supported in classic mode. if (sessionData.CombinedSortedList.HasValue) { // Always use the previously saved combined list if available. data = new AsyncCompletionSessionDataSnapshot(sessionData.CombinedSortedList.Value, data.Snapshot, data.Trigger, data.InitialTrigger, data.SelectedFilters, data.IsSoftSelected, data.DisplaySuggestionItem, data.Defaults); } else if (sessionData.ExpandedItemsTask != null) { var task = sessionData.ExpandedItemsTask; if (task.Status == TaskStatus.RanToCompletion) { // Make sure the task is removed when Adding expanded items, // so duplicated items won't be added in subsequent list updates. sessionData.ExpandedItemsTask = null; var(expandedContext, _) = await task.ConfigureAwait(false); if (expandedContext.Items.Length > 0) { // Here we rely on the implementation detail of `CompletionItem.CompareTo`, which always put expand items after regular ones. var itemsBuilder = ImmutableArray.CreateBuilder <VSCompletionItem>(expandedContext.Items.Length + data.InitialSortedList.Length); itemsBuilder.AddRange(data.InitialSortedList); itemsBuilder.AddRange(expandedContext.Items); var combinedList = itemsBuilder.MoveToImmutable(); // Add expanded items into a combined list, and save it to be used for future updates during the same session. sessionData.CombinedSortedList = combinedList; var combinedFilterStates = FilterSet.CombineFilterStates(expandedContext.Filters, data.SelectedFilters); data = new AsyncCompletionSessionDataSnapshot(combinedList, data.Snapshot, data.Trigger, data.InitialTrigger, combinedFilterStates, data.IsSoftSelected, data.DisplaySuggestionItem, data.Defaults); } AsyncCompletionLogger.LogSessionWithDelayedImportCompletionIncludedInUpdate(); } } var updater = new CompletionListUpdater(session.ApplicableToSpan, sessionData, data, _recentItemsManager, _globalOptions); return(updater.UpdateCompletionList(cancellationToken)); } finally { AsyncCompletionLogger.LogItemManagerUpdateDataPoint((int)stopwatch.Elapsed.TotalMilliseconds, isCanceled: cancellationToken.IsCancellationRequested); } }