/* goodG2B() - use GoodSource and BadSink */ private static void GoodG2B() { int count; /* FIX: Use a hardcoded number that won't cause underflow, overflow, divide by zero, or loss-of-precision issues */ count = 2; Hashtable countHashtable = new Hashtable(5); countHashtable.Add(0, count); countHashtable.Add(1, count); countHashtable.Add(2, count); CWE400_Uncontrolled_Resource_Consumption__NetClient_for_loop_72b.GoodG2BSink(countHashtable); }
public override void Bad() { int count; count = int.MinValue; /* Initialize count */ /* read input from WebClient */ { try { string stringNumber = ""; using (WebClient client = new WebClient()) { using (StreamReader sr = new StreamReader(client.OpenRead("http://www.example.org/"))) { /* POTENTIAL FLAW: Read count from a web server with WebClient */ /* This will be reading the first "line" of the response body, * which could be very long if there are no newlines in the HTML */ stringNumber = sr.ReadLine(); } } if (stringNumber != null) // avoid NPD incidental warnings { try { count = int.Parse(stringNumber.Trim()); } catch (FormatException exceptNumberFormat) { IO.Logger.Log(NLog.LogLevel.Warn, exceptNumberFormat, "Number format exception parsing count from string"); } } } catch (IOException exceptIO) { IO.Logger.Log(NLog.LogLevel.Warn, exceptIO, "Error with stream reading"); } } Hashtable countHashtable = new Hashtable(5); countHashtable.Add(0, count); countHashtable.Add(1, count); countHashtable.Add(2, count); CWE400_Uncontrolled_Resource_Consumption__NetClient_for_loop_72b.BadSink(countHashtable); }