/* goodG2B() - use GoodSource and BadSink */ private static void GoodG2B() { int data; /* FIX: Use a hardcoded number that won't cause underflow, overflow, divide by zero, or loss-of-precision issues */ data = 2; Hashtable dataHashtable = new Hashtable(5); dataHashtable.Add(0, data); dataHashtable.Add(1, data); dataHashtable.Add(2, data); CWE191_Integer_Underflow__int_NetClient_sub_72b.GoodG2BSink(dataHashtable); }
/* goodB2G() - use BadSource and GoodSink */ private static void GoodB2G() { int data; data = int.MinValue; /* Initialize data */ /* read input from WebClient */ { try { string stringNumber = ""; using (WebClient client = new WebClient()) { using (StreamReader sr = new StreamReader(client.OpenRead("http://www.example.org/"))) { /* POTENTIAL FLAW: Read data from a web server with WebClient */ /* This will be reading the first "line" of the response body, * which could be very long if there are no newlines in the HTML */ stringNumber = sr.ReadLine(); } } if (stringNumber != null) // avoid NPD incidental warnings { try { data = int.Parse(stringNumber.Trim()); } catch (FormatException exceptNumberFormat) { IO.Logger.Log(NLog.LogLevel.Warn, exceptNumberFormat, "Number format exception parsing data from string"); } } } catch (IOException exceptIO) { IO.Logger.Log(NLog.LogLevel.Warn, exceptIO, "Error with stream reading"); } } Hashtable dataHashtable = new Hashtable(5); dataHashtable.Add(0, data); dataHashtable.Add(1, data); dataHashtable.Add(2, data); CWE191_Integer_Underflow__int_NetClient_sub_72b.GoodB2GSink(dataHashtable); }