public PullRequestReviewAuthoringViewModelDesigner()
{
PullRequestModel = new PullRequestDetailModel
{
Number = 419,
Title = "Fix a ton of potential crashers, odd code and redundant calls in ModelService",
Author = new ActorModel {
Login = "******"
},
UpdatedAt = DateTimeOffset.Now - TimeSpan.FromDays(2),
};
Files = new PullRequestFilesViewModelDesigner();
FileComments = new[]
{
new PullRequestReviewFileCommentViewModelDesigner
{
Body = @"These should probably be properties. Most likely they should be readonly properties. I know that makes creating instances of these not look as nice as using property initializers when constructing an instance, but if these properties should never be mutated after construction, then it guides future consumers to the right behavior.
However, if you're two-way binding these properties to a UI, then ignore the readonly part and make them properties. But in that case they should probably be reactive properties (or implement INPC).",
RelativePath = "src/GitHub.Exports.Reactive/ViewModels/IPullRequestListViewModel.cs",
},
new PullRequestReviewFileCommentViewModelDesigner
{
Body = "While I have no problems with naming a variable ass I think we should probably avoid swear words in case Microsoft runs their Policheck tool against this code.",
RelativePath = "src/GitHub.App/ViewModels/PullRequestListViewModel.cs",
},
};
}
public PullRequestDetailViewModelDesigner()
{
var repoPath = @"C:\Repo";
Model = new PullRequestDetailModel
{
Number = 419,
Title = "Error handling/bubbling from viewmodels to views to viewhosts",
Author = new ActorModel {
Login = "******"
},
UpdatedAt = DateTimeOffset.Now.Subtract(TimeSpan.FromDays(3)),
};
SourceBranchDisplayName = "shana/error-handling";
TargetBranchDisplayName = "master";
Body = @"Adds a way to surface errors from the view model to the view so that view hosts can get to them.
ViewModels are responsible for handling the UI on the view they control, but they shouldn't be handling UI for things outside of the view. In this case, we're showing errors in VS outside the view, and that should be handled by the section that is hosting the view.
This requires that errors be propagated from the viewmodel to the view and from there to the host via the IView interface, since hosts don't usually know what they're hosting.
";
var gitHubDir = new PullRequestDirectoryNode("GitHub");
var modelsDir = new PullRequestDirectoryNode("Models");
var repositoriesDir = new PullRequestDirectoryNode("Repositories");
var itrackingBranch = new PullRequestFileNode(repoPath, @"GitHub\Models\ITrackingBranch.cs", "abc", PullRequestFileStatus.Modified, null);
var oldBranchModel = new PullRequestFileNode(repoPath, @"GitHub\Models\OldBranchModel.cs", "abc", PullRequestFileStatus.Removed, null);
var concurrentRepositoryConnection = new PullRequestFileNode(repoPath, @"GitHub\Repositories\ConcurrentRepositoryConnection.cs", "abc", PullRequestFileStatus.Added, null);
repositoriesDir.Files.Add(concurrentRepositoryConnection);
modelsDir.Directories.Add(repositoriesDir);
modelsDir.Files.Add(itrackingBranch);
modelsDir.Files.Add(oldBranchModel);
gitHubDir.Directories.Add(modelsDir);
Reviews = new[]
{
new PullRequestReviewSummaryViewModel
{
Id = "id1",
User = new ActorViewModel {
Login = "******"
},
State = PullRequestReviewState.Pending,
FileCommentCount = 0,
},
new PullRequestReviewSummaryViewModel
{
Id = "id",
User = new ActorViewModel {
Login = "******"
},
State = PullRequestReviewState.Approved,
FileCommentCount = 5,
},
new PullRequestReviewSummaryViewModel
{
Id = "id3",
User = new ActorViewModel {
Login = "******"
},
State = PullRequestReviewState.ChangesRequested,
FileCommentCount = 5,
},
new PullRequestReviewSummaryViewModel
{
},
};
Files = new PullRequestFilesViewModelDesigner();
Checks = Array.Empty <PullRequestCheckViewModelDesigner>();
}
