public void ProcedureShouldBeFunction_DoesNotReturnResult_EventImplementation() { //Input const string inputCode1 = @"Public Event Foo(ByRef arg1 As Integer)"; const string inputCode2 = @"Private WithEvents abc As Class1 Private Sub abc_Foo(ByRef arg1 As Integer) End Sub"; //Arrange var builder = new MockVbeBuilder(); var project = builder.ProjectBuilder("TestProject1", vbext_ProjectProtection.vbext_pp_none) .AddComponent("Class1", vbext_ComponentType.vbext_ct_ClassModule, inputCode1) .AddComponent("Class2", vbext_ComponentType.vbext_ct_ClassModule, inputCode2) .Build(); var vbe = builder.AddProject(project).Build(); var mockHost = new Mock <IHostApplication>(); mockHost.SetupAllProperties(); var parser = MockParser.Create(vbe.Object, new RubberduckParserState()); parser.Parse(); if (parser.State.Status == ParserState.Error) { Assert.Inconclusive("Parser Error"); } var inspection = new ProcedureCanBeWrittenAsFunctionInspection(parser.State); var inspectionResults = inspection.GetInspectionResults(); Assert.AreEqual(0, inspectionResults.Count()); }
public void ProcedureShouldBeFunction_QuickFixWorks() { const string inputCode = @"Private Sub Foo(ByRef arg1 As Integer) End Sub"; const string expectedCode = @"Private Function Foo(ByVal arg1 As Integer) As Integer Foo = arg1 End Function"; //Arrange var builder = new MockVbeBuilder(); VBComponent component; var vbe = builder.BuildFromSingleStandardModule(inputCode, out component); var project = vbe.Object.VBProjects.Item(0); var module = project.VBComponents.Item(0).CodeModule; var mockHost = new Mock <IHostApplication>(); mockHost.SetupAllProperties(); var parser = MockParser.Create(vbe.Object, new RubberduckParserState()); parser.Parse(); if (parser.State.Status == ParserState.Error) { Assert.Inconclusive("Parser Error"); } var inspection = new ProcedureCanBeWrittenAsFunctionInspection(parser.State); var inspectionResults = inspection.GetInspectionResults(); inspectionResults.First().QuickFixes.First().Fix(); Assert.AreEqual(expectedCode, module.Lines()); }
public void ProcedureShouldBeFunction_QuickFixWorks_UpdatesCallsAbove() { const string inputCode = @"Sub Goo(ByVal a As Integer) Dim fizz As Integer Foo fizz End Sub Private Sub Foo(ByRef arg1 As Integer) End Sub"; const string expectedCode = @"Sub Goo(ByVal a As Integer) Dim fizz As Integer fizz = Foo(fizz) End Sub Private Function Foo(ByVal arg1 As Integer) As Integer Foo = arg1 End Function"; var vbe = MockVbeBuilder.BuildFromSingleStandardModule(inputCode, out var component); using (var state = MockParser.CreateAndParse(vbe.Object)) { var inspection = new ProcedureCanBeWrittenAsFunctionInspection(state); var inspector = InspectionsHelper.GetInspector(inspection); var inspectionResults = inspector.FindIssuesAsync(state, CancellationToken.None).Result; new ChangeProcedureToFunctionQuickFix(state).Fix(inspectionResults.First()); Assert.AreEqual(expectedCode, state.GetRewriter(component).GetText()); } }
public void ProcedureShouldBeFunction_QuickFixWorks_NoAsTypeClauseInParam() { const string inputCode = @"Private Sub Foo(ByRef arg1) arg1 = 42 End Sub"; const string expectedCode = @"Private Function Foo(ByVal arg1) As Variant arg1 = 42 Foo = arg1 End Function"; var vbe = MockVbeBuilder.BuildFromSingleStandardModule(inputCode, out var component); using (var state = MockParser.CreateAndParse(vbe.Object)) { var inspection = new ProcedureCanBeWrittenAsFunctionInspection(state); var inspector = InspectionsHelper.GetInspector(inspection); var inspectionResults = inspector.FindIssuesAsync(state, CancellationToken.None).Result; new ChangeProcedureToFunctionQuickFix(state).Fix(inspectionResults.First()); Assert.AreEqual(expectedCode, state.GetRewriter(component).GetText()); } }
public void ProcedureShouldBeFunction_IgnoreQuickFixWorks() { const string inputCode = @"Private Sub Foo(ByRef arg1 As Integer) arg1 = 42 End Sub"; const string expectedCode = @"'@Ignore ProcedureCanBeWrittenAsFunction Private Sub Foo(ByRef arg1 As Integer) arg1 = 42 End Sub"; var vbe = MockVbeBuilder.BuildFromSingleStandardModule(inputCode, out var component); using (var state = MockParser.CreateAndParse(vbe.Object)) { var inspection = new ProcedureCanBeWrittenAsFunctionInspection(state); var inspector = InspectionsHelper.GetInspector(inspection); var inspectionResults = inspector.FindIssuesAsync(state, CancellationToken.None).Result; new IgnoreOnceQuickFix(state, new[] { inspection }).Fix(inspectionResults.First()); Assert.AreEqual(expectedCode, state.GetRewriter(component).GetText()); } }
public void ProcedureShouldBeFunction_IgnoreQuickFixWorks() { const string inputCode = @"Private Sub Foo(ByRef arg1 As Integer) End Sub"; const string expectedCode = @"'@Ignore ProcedureCanBeWrittenAsFunction Private Sub Foo(ByRef arg1 As Integer) End Sub"; var settings = new Mock <IGeneralConfigService>(); var config = GetTestConfig(); settings.Setup(x => x.LoadConfiguration()).Returns(config); IVBComponent component; var vbe = MockVbeBuilder.BuildFromSingleStandardModule(inputCode, out component); var state = MockParser.CreateAndParse(vbe.Object); var inspection = new ProcedureCanBeWrittenAsFunctionInspection(state); var inspector = new Inspector(settings.Object, new IInspection[] { inspection }); var inspectionResults = inspector.FindIssuesAsync(state, CancellationToken.None).Result; inspectionResults.First().QuickFixes.Single(s => s is IgnoreOnceQuickFix).Fix(); Assert.AreEqual(expectedCode, component.CodeModule.Content()); }
public void ProcedureShouldBeFunction_ReturnsResult_MultipleSubs() { const string inputCode = @"Private Sub Foo(ByRef foo As Boolean) End Sub Private Sub Goo(ByRef foo As Integer) End Sub"; var settings = new Mock <IGeneralConfigService>(); var config = GetTestConfig(); settings.Setup(x => x.LoadConfiguration()).Returns(config); IVBComponent component; var vbe = MockVbeBuilder.BuildFromSingleStandardModule(inputCode, out component); var state = MockParser.CreateAndParse(vbe.Object); var inspection = new ProcedureCanBeWrittenAsFunctionInspection(state); var inspector = new Inspector(settings.Object, new IInspection[] { inspection }); var inspectionResults = inspector.FindIssuesAsync(state, CancellationToken.None).Result; Assert.AreEqual(2, inspectionResults.Count()); }
public void ProcedureShouldBeFunction_DoesNotReturnResult_Function() { const string inputCode = @"Private Function Foo(ByRef bar As Integer) As Integer Foo = bar End Function"; //Arrange var builder = new MockVbeBuilder(); VBComponent component; var vbe = builder.BuildFromSingleStandardModule(inputCode, out component); var mockHost = new Mock <IHostApplication>(); mockHost.SetupAllProperties(); var parser = MockParser.Create(vbe.Object, new RubberduckParserState()); parser.Parse(); if (parser.State.Status == ParserState.Error) { Assert.Inconclusive("Parser Error"); } var inspection = new ProcedureCanBeWrittenAsFunctionInspection(parser.State); var inspectionResults = inspection.GetInspectionResults(); Assert.AreEqual(0, inspectionResults.Count()); }
public void ProcedureShouldBeFunction_DoesNotReturnResult_Function() { const string inputCode = @"Private Function Foo(ByRef bar As Integer) As Integer Foo = bar End Function"; //Arrange var settings = new Mock <IGeneralConfigService>(); var config = GetTestConfig(); settings.Setup(x => x.LoadConfiguration()).Returns(config); var builder = new MockVbeBuilder(); VBComponent component; var vbe = builder.BuildFromSingleStandardModule(inputCode, out component); var mockHost = new Mock <IHostApplication>(); mockHost.SetupAllProperties(); var parser = MockParser.Create(vbe.Object, new RubberduckParserState(new Mock <ISinks>().Object)); parser.Parse(new CancellationTokenSource()); if (parser.State.Status >= ParserState.Error) { Assert.Inconclusive("Parser Error"); } var inspection = new ProcedureCanBeWrittenAsFunctionInspection(parser.State); var inspector = new Inspector(settings.Object, new IInspection[] { inspection }); var inspectionResults = inspector.FindIssuesAsync(parser.State, CancellationToken.None).Result; Assert.AreEqual(0, inspectionResults.Count()); }
public void ProcedureShouldBeFunction_DoesNotReturnResult_EventImplementation() { //Input const string inputCode1 = @"Public Event Foo(ByRef arg1 As Integer)"; const string inputCode2 = @"Private WithEvents abc As Class1 Private Sub abc_Foo(ByRef arg1 As Integer) End Sub"; var settings = new Mock <IGeneralConfigService>(); var config = GetTestConfig(); settings.Setup(x => x.LoadConfiguration()).Returns(config); var builder = new MockVbeBuilder(); var project = builder.ProjectBuilder("TestProject1", ProjectProtection.Unprotected) .AddComponent("Class1", ComponentType.ClassModule, inputCode1) .AddComponent("Class2", ComponentType.ClassModule, inputCode2) .Build(); var vbe = builder.AddProject(project).Build(); var state = MockParser.CreateAndParse(vbe.Object); var inspection = new ProcedureCanBeWrittenAsFunctionInspection(state); var inspector = new Inspector(settings.Object, new IInspection[] { inspection }); var inspectionResults = inspector.FindIssuesAsync(state, CancellationToken.None).Result; Assert.AreEqual(0, inspectionResults.Count()); }
public void InspectionName() { const string inspectionName = "ProcedureCanBeWrittenAsFunctionInspection"; var inspection = new ProcedureCanBeWrittenAsFunctionInspection(null); Assert.AreEqual(inspectionName, inspection.Name); }
public void ProcedureShouldBeFunction_QuickFixWorks_DoesNotInterfereWithBody_BodyOnSingleLine() { const string inputCode = @"Private Sub Foo(ByRef arg1 As Integer): arg1 = 6: Goo arg1: End Sub Sub Goo(ByVal a As Integer) End Sub"; const string expectedCode = @"Private Function Foo(ByVal arg1 As Integer) As Integer: arg1 = 6: Goo arg1: Foo = arg1 End Function Sub Goo(ByVal a As Integer) End Sub"; var vbe = MockVbeBuilder.BuildFromSingleStandardModule(inputCode, out var component); var state = MockParser.CreateAndParse(vbe.Object); var inspection = new ProcedureCanBeWrittenAsFunctionInspection(state); var inspector = InspectionsHelper.GetInspector(inspection); var inspectionResults = inspector.FindIssuesAsync(state, CancellationToken.None).Result; new ChangeProcedureToFunctionQuickFix(state).Fix(inspectionResults.First()); Assert.AreEqual(expectedCode, state.GetRewriter(component).GetText()); }
public void ProcedureShouldBeFunction_DoesNotReturnResult_EventImplementation() { //Input const string inputCode1 = @"Public Event Foo(ByRef arg1 As Integer)"; const string inputCode2 = @"Private WithEvents abc As Class1 Private Sub abc_Foo(ByRef arg1 As Integer) End Sub"; var builder = new MockVbeBuilder(); var project = builder.ProjectBuilder("TestProject1", ProjectProtection.Unprotected) .AddComponent("Class1", ComponentType.ClassModule, inputCode1) .AddComponent("Class2", ComponentType.ClassModule, inputCode2) .Build(); var vbe = builder.AddProject(project).Build(); using (var state = MockParser.CreateAndParse(vbe.Object)) { var inspection = new ProcedureCanBeWrittenAsFunctionInspection(state); var inspector = InspectionsHelper.GetInspector(inspection); var inspectionResults = inspector.FindIssuesAsync(state, CancellationToken.None).Result; Assert.AreEqual(0, inspectionResults.Count()); } }
public void ProcedureShouldBeFunction_QuickFixWorks_UpdatesCallsBelow() { const string inputCode = @"Private Sub Foo(ByRef arg1 As Integer) End Sub Sub Goo(ByVal a As Integer) Dim fizz As Integer Foo fizz End Sub"; const string expectedCode = @"Private Function Foo(ByVal arg1 As Integer) As Integer Foo = arg1 End Function Sub Goo(ByVal a As Integer) Dim fizz As Integer fizz = Foo(fizz) End Sub"; //Arrange var settings = new Mock <IGeneralConfigService>(); var config = GetTestConfig(); settings.Setup(x => x.LoadConfiguration()).Returns(config); var builder = new MockVbeBuilder(); VBComponent component; var vbe = builder.BuildFromSingleStandardModule(inputCode, out component); var project = vbe.Object.VBProjects.Item(0); var module = project.VBComponents.Item(0).CodeModule; var mockHost = new Mock <IHostApplication>(); mockHost.SetupAllProperties(); var parser = MockParser.Create(vbe.Object, new RubberduckParserState(new Mock <ISinks>().Object)); parser.Parse(new CancellationTokenSource()); if (parser.State.Status >= ParserState.Error) { Assert.Inconclusive("Parser Error"); } var inspection = new ProcedureCanBeWrittenAsFunctionInspection(parser.State); var inspector = new Inspector(settings.Object, new IInspection[] { inspection }); var inspectionResults = inspector.FindIssuesAsync(parser.State, CancellationToken.None).Result; inspectionResults.First().QuickFixes.First().Fix(); Assert.AreEqual(expectedCode, module.Lines()); }
public void ProcedureShouldBeFunction_DoesNotReturnsResult_MultipleByValParams() { const string inputCode = @"Private Sub Foo(ByVal foo As Integer, ByVal goo As Integer) End Sub"; var vbe = MockVbeBuilder.BuildFromSingleStandardModule(inputCode, out _); var state = MockParser.CreateAndParse(vbe.Object); var inspection = new ProcedureCanBeWrittenAsFunctionInspection(state); var inspector = InspectionsHelper.GetInspector(inspection); var inspectionResults = inspector.FindIssuesAsync(state, CancellationToken.None).Result; Assert.AreEqual(0, inspectionResults.Count()); }
public void ProcedureShouldBeFunction_Ignored_DoesNotReturnResult() { const string inputCode = @"'@Ignore ProcedureCanBeWrittenAsFunction Private Sub Foo(ByRef foo As Boolean) End Sub"; var vbe = MockVbeBuilder.BuildFromSingleStandardModule(inputCode, out _); var state = MockParser.CreateAndParse(vbe.Object); var inspection = new ProcedureCanBeWrittenAsFunctionInspection(state); var inspector = InspectionsHelper.GetInspector(inspection); var inspectionResults = inspector.FindIssuesAsync(state, CancellationToken.None).Result; Assert.IsFalse(inspectionResults.Any()); }
public void ProcedureShouldBeFunction_ReturnsResult() { const string inputCode = @"Private Sub Foo(ByRef foo As Boolean) foo = 42 End Sub"; var vbe = MockVbeBuilder.BuildFromSingleStandardModule(inputCode, out _); using (var state = MockParser.CreateAndParse(vbe.Object)) { var inspection = new ProcedureCanBeWrittenAsFunctionInspection(state); var inspector = InspectionsHelper.GetInspector(inspection); var inspectionResults = inspector.FindIssuesAsync(state, CancellationToken.None).Result; Assert.AreEqual(1, inspectionResults.Count()); } }
public void ProcedureShouldBeFunction_DoesNotReturnResult_Function() { const string inputCode = @"Private Function Foo(ByRef bar As Integer) As Integer Foo = bar End Function"; var vbe = MockVbeBuilder.BuildFromSingleStandardModule(inputCode, out _); using (var state = MockParser.CreateAndParse(vbe.Object)) { var inspection = new ProcedureCanBeWrittenAsFunctionInspection(state); var inspector = InspectionsHelper.GetInspector(inspection); var inspectionResults = inspector.FindIssuesAsync(state, CancellationToken.None).Result; Assert.AreEqual(0, inspectionResults.Count()); } }
public void ProcedureShouldBeFunction_DoesNotReturnResult_InterfaceImplementation() { //Input const string inputCode1 = @"Public Sub DoSomething(ByRef a As Integer) End Sub"; const string inputCode2 = @"Implements IClass1 Private Sub IClass1_DoSomething(ByRef a As Integer) End Sub"; //Arrange var settings = new Mock <IGeneralConfigService>(); var config = GetTestConfig(); settings.Setup(x => x.LoadConfiguration()).Returns(config); var builder = new MockVbeBuilder(); var project = builder.ProjectBuilder("TestProject1", vbext_ProjectProtection.vbext_pp_none) .AddComponent("IClass1", vbext_ComponentType.vbext_ct_ClassModule, inputCode1) .AddComponent("Class1", vbext_ComponentType.vbext_ct_ClassModule, inputCode2) .Build(); var vbe = builder.AddProject(project).Build(); var mockHost = new Mock <IHostApplication>(); mockHost.SetupAllProperties(); var parser = MockParser.Create(vbe.Object, new RubberduckParserState(new Mock <ISinks>().Object)); parser.Parse(new CancellationTokenSource()); if (parser.State.Status >= ParserState.Error) { Assert.Inconclusive("Parser Error"); } var inspection = new ProcedureCanBeWrittenAsFunctionInspection(parser.State); var inspector = new Inspector(settings.Object, new IInspection[] { inspection }); var inspectionResults = inspector.FindIssuesAsync(parser.State, CancellationToken.None).Result; Assert.AreEqual(0, inspectionResults.Count()); }
public void ProcedureShouldBeFunction_QuickFixWorks_DoesNotInterfereWithBody_BodyOnSingleLine_BodyHasStringLiteralContainingColon() { const string inputCode = @"Private Sub Foo(ByRef arg1 As Integer): arg1 = 6: Goo ""test: test"": End Sub Sub Goo(ByVal a As String) End Sub"; const string expectedCode = @"Private Function Foo(ByVal arg1 As Integer) As Integer arg1 = 6 Goo ""test: test"" Foo = arg1 End Function Sub Goo(ByVal a As String) End Sub"; var settings = new Mock <IGeneralConfigService>(); var config = GetTestConfig(); settings.Setup(x => x.LoadConfiguration()).Returns(config); IVBComponent component; var vbe = MockVbeBuilder.BuildFromSingleStandardModule(inputCode, out component); var state = MockParser.CreateAndParse(vbe.Object); var inspection = new ProcedureCanBeWrittenAsFunctionInspection(state); var inspector = new Inspector(settings.Object, new IInspection[] { inspection }); var inspectionResults = inspector.FindIssuesAsync(state, CancellationToken.None).Result; inspectionResults.First().QuickFixes.First().Fix(); Assert.AreEqual(expectedCode, component.CodeModule.Content()); }
public void InspectionType() { var inspection = new ProcedureCanBeWrittenAsFunctionInspection(null); Assert.AreEqual(CodeInspectionType.LanguageOpportunities, inspection.InspectionType); }