public async Task <DeviceModel> UpdateDeviceFromDeviceInfoPacketAsync(DeviceModel device)
{
if (device == null)
{
throw new ArgumentNullException("device");
}
// Get original device document
DeviceModel existingDevice = await this.GetDeviceAsync(device.IoTHub.ConnectionDeviceId);
SupportedMethodsHelper.AddSupportedMethodsFromReportedProperty(device, existingDevice.Twin);
// Save the command history, original created date, and system properties (if any) of the existing device
if (existingDevice.DeviceProperties != null)
{
DeviceProperties deviceProperties = device.DeviceProperties;
deviceProperties.CreatedTime = existingDevice.DeviceProperties.CreatedTime;
existingDevice.DeviceProperties = deviceProperties;
}
device.CommandHistory = existingDevice.CommandHistory;
// Copy the existing system properties, or initialize them if they do not exist
if (existingDevice.SystemProperties != null)
{
device.SystemProperties = existingDevice.SystemProperties;
}
else
{
device.SystemProperties = null;
}
// If there is Telemetry or Command objects from device, replace instead of merge
if (device.Telemetry != null)
{
existingDevice.Telemetry = device.Telemetry;
}
if (device.Commands != null)
{
existingDevice.Commands = device.Commands;
}
return(await _deviceRegistryCrudRepository.UpdateDeviceAsync(existingDevice));
}
public void GenerateSupportedMethodsReportedPropertyTest()
{
var commands = new List <Command>()
{
// Method with parameters
new Command("method1", DeliveryType.Method, "desc1", new List <Parameter>()
{
new Parameter("p1", "string"),
new Parameter("p2", "int")
}),
// Command, should be ignored
new Command("command1", DeliveryType.Method, "desc1", new List <Parameter>()
{
new Parameter("p1", "int"),
new Parameter("p2", "string")
}),
// Method without parameters
new Command("method2", DeliveryType.Method, "desc2"),
// Method name with _
new Command("method_3", DeliveryType.Method, "desc3"),
// Method without name, should be ignored
new Command("", DeliveryType.Method, "desc2"),
// parameter with no type, should be ignored
new Command("method4", DeliveryType.Method, "desc1", new List <Parameter>()
{
new Parameter("p1", ""),
new Parameter("p2", "int")
}),
};
var property = new TwinCollection();
SupportedMethodsHelper.CreateSupportedMethodReport(property, commands, null);
JObject supportedMethods = property["SupportedMethods"] as JObject;
Assert.Equal(supportedMethods.Count, commands.Where(c => c.DeliveryType == DeliveryType.Method).Count() - 2);
Assert.Equal(supportedMethods["method1--p1-string--p2-int"].ToString(), "desc1");
Assert.Equal(supportedMethods["command1--p1-int--p2-string"].ToString(), "desc1");
Assert.Equal(supportedMethods["method2"].ToString(), "desc2");
Assert.Equal(supportedMethods["method_3"].ToString(), "desc3");
supportedMethods[""] = "desc2";
supportedMethods["method4--p1---p2-int"] = "desc1";
var device = new DeviceModel();
var twin = new Twin();
twin.Properties.Reported["SupportedMethods"] = supportedMethods;
SupportedMethodsHelper.AddSupportedMethodsFromReportedProperty(device, twin);
Assert.Equal(supportedMethods.Count - 2, device.Commands.Count);
foreach (var command in device.Commands)
{
var srcCommand = commands.FirstOrDefault(c => c.Name == command.Name);
Assert.Equal(command.Name, srcCommand.Name);
Assert.Equal(command.Description, srcCommand.Description);
Assert.Equal(command.Parameters.Count, srcCommand.Parameters.Count);
foreach (var parameter in command.Parameters)
{
var srcParameter = srcCommand.Parameters.FirstOrDefault(p => p.Name == parameter.Name);
Assert.Equal(parameter.Name, srcParameter.Name);
Assert.Equal(parameter.Type, srcParameter.Type);
}
}
}
