public void Validate_GivenCoreProviderVersionUpdatesUseLatestForNonFDZProviderSource_ValidIsFalse()
{
//Arrange
SpecificationCreateModel model = CreateModel();
model.CoreProviderVersionUpdates = CoreProviderVersionUpdates.UseLatest;
ISpecificationsRepository repository = CreateSpecificationsRepository();
IPoliciesApiClient policiesApiClient = CreatePoliciesApiClient(ProviderSource.CFS);
SpecificationCreateModelValidator validator = CreateValidator(repository, policiesApiClient: policiesApiClient);
//Act
ValidationResult result = validator.Validate(model);
//Assert
result
.IsValid
.Should()
.BeFalse();
result
.Errors
.Count
.Should()
.Be(1);
result
.Errors.Select(x => x.ErrorMessage)
.Should()
.Contain("CoreProviderVersionUpdates - UseLatest is not valid for provider source - CFS");
}
public void Validate_GivenFundingPeriodId_FundingPeriodDoesntExist_ValidIsFalse()
{
//Arrange
SpecificationCreateModel model = CreateModel();
IPoliciesApiClient policiesApiClient = Substitute.For <IPoliciesApiClient>();
policiesApiClient
.GetFundingPeriodById(Arg.Is("1819"))
.Returns(new ApiResponse <PolicyModels.FundingPeriod>(HttpStatusCode.OK, new PolicyModels.FundingPeriod()));
policiesApiClient
.GetFundingConfiguration(Arg.Is(fundingStreamId), Arg.Is(fundingPeriodId))
.Returns(new ApiResponse <PolicyModels.FundingConfig.FundingConfiguration>(HttpStatusCode.OK, new PolicyModels.FundingConfig.FundingConfiguration()));
SpecificationCreateModelValidator validator = CreateValidator(policiesApiClient: policiesApiClient);
//Act
ValidationResult result = validator.Validate(model);
//Assert
result
.IsValid
.Should()
.BeFalse();
result
.Errors.Select(x => x.PropertyName == "FundingPeriodId" && x.ErrorMessage == "Funding period not found")
.Count()
.Should()
.Be(1);
}
public void Validate_GivenEmptyProviderSnapshotId_ValidIsFalse()
{
//Arrange
SpecificationCreateModel model = CreateModel();
IPoliciesApiClient policiesApiClient = Substitute.For <IPoliciesApiClient>();
policiesApiClient
.GetFundingPeriodById(Arg.Any <string>())
.Returns(new ApiResponse <PolicyModels.FundingPeriod>(HttpStatusCode.OK, new PolicyModels.FundingPeriod()));
policiesApiClient
.GetFundingConfiguration(Arg.Any <string>(), Arg.Any <string>())
.Returns(new ApiResponse <PolicyModels.FundingConfig.FundingConfiguration>(HttpStatusCode.OK, new PolicyModels.FundingConfig.FundingConfiguration {
ProviderSource = ProviderSource.FDZ
}));
SpecificationCreateModelValidator validator = CreateValidator(policiesApiClient: policiesApiClient);
//Act
ValidationResult result = validator.Validate(model);
//Assert
result
.IsValid
.Should()
.BeFalse();
result
.Errors
.Count
.Should()
.Be(1);
}
public async Task <IActionResult> SpecificationsCommands([FromBody] SpecificationCreateModel specificationCreateModel)
{
Reference user = Request.GetUser();
string correlationId = ControllerContext.HttpContext.Request.GetCorrelationId();
return(await _specService.CreateSpecification(specificationCreateModel, user, correlationId));
}
public async Task SpecificationsService_CreateSpecification_WhenInvalidInputProvided_ThenValidationErrorReturned()
{
// Arrange
ValidationResult validationResult = new ValidationResult();
validationResult.Errors.Add(new ValidationFailure("fundingStreamId", "Test"));
IValidator <SpecificationCreateModel> validator = CreateSpecificationValidator(validationResult);
SpecificationsService specificationsService = CreateService(specificationCreateModelvalidator: validator);
SpecificationCreateModel specificationCreateModel = new SpecificationCreateModel()
{
Name = "Specification Name",
Description = "Specification Description",
FundingPeriodId = null,
FundingStreamIds = new List <string>()
{
},
};
string json = JsonConvert.SerializeObject(specificationCreateModel);
byte[] byteArray = Encoding.UTF8.GetBytes(json);
MemoryStream stream = new MemoryStream(byteArray);
HttpContext context = Substitute.For <HttpContext>();
HttpRequest request = Substitute.For <HttpRequest>();
request
.Body
.Returns(stream);
request
.HttpContext
.Returns(context);
// Act
IActionResult result = await specificationsService.CreateSpecification(request);
// Assert
result
.Should()
.BeOfType <BadRequestObjectResult>()
.Which
.Value
.Should()
.BeOfType <SerializableError>()
.Which
.Should()
.HaveCount(1);
await validator
.Received(1)
.ValidateAsync(Arg.Any <SpecificationCreateModel>());
}
public void Validate_GivenValidModel_ValidIsTrue()
{
//Arrange
SpecificationCreateModel model = CreateModel();
SpecificationCreateModelValidator validator = CreateValidator();
//Act
ValidationResult result = validator.Validate(model);
//Assert
result
.IsValid
.Should()
.BeTrue();
}
public void Validate_GivenFundingPeriodId_FundingPeriodIsNotEmpty_ValidIsTrue()
{
//Arrange
SpecificationCreateModel model = CreateModel();
//model.FundingPeriodId = string.Empty;
IPoliciesApiClient policiesApiClient = CreatePoliciesApiClient();
SpecificationCreateModelValidator validator = CreateValidator(policiesApiClient: policiesApiClient);
//Act
ValidationResult result = validator.Validate(model);
//Assert
result
.IsValid
.Should()
.BeTrue();
}
public void Validate_GivenCoreProviderVersionUpdatesUseLatestForFDZProviderSource_ValidIsTrue()
{
//Arrange
SpecificationCreateModel model = CreateModel();
model.CoreProviderVersionUpdates = CoreProviderVersionUpdates.UseLatest;
model.ProviderSnapshotId = 1;
ISpecificationsRepository repository = CreateSpecificationsRepository();
IPoliciesApiClient policiesApiClient = CreatePoliciesApiClient(ProviderSource.FDZ);
SpecificationCreateModelValidator validator = CreateValidator(repository, policiesApiClient: policiesApiClient);
//Act
ValidationResult result = validator.Validate(model);
//Assert
result
.IsValid
.Should()
.BeTrue();
}
public void Validate_GivenEmptyFundingPeriodId_ValidIsFalse()
{
//Arrange
SpecificationCreateModel model = CreateModel();
model.FundingPeriodId = string.Empty;
SpecificationCreateModelValidator validator = CreateValidator();
//Act
ValidationResult result = validator.Validate(model);
//Assert
result
.IsValid
.Should()
.BeFalse();
result
.Errors
.Count
.Should()
.Be(1);
}
public void Validate_GivenProviderVersionIdDoesntExist_ValidIsFalse()
{
//Arrange
SpecificationCreateModel model = CreateModel();
IProvidersApiClient providersApiClient = CreateProviderApiClient(HttpStatusCode.NotFound);
SpecificationCreateModelValidator validator = CreateValidator(providersApiClient: providersApiClient);
//Act
ValidationResult result = validator.Validate(model);
//Assert
result
.IsValid
.Should()
.BeFalse();
result
.Errors.Select(x => x.PropertyName == "ProviderVersionId" && x.ErrorMessage == "Provider version id selected does not exist")
.Count()
.Should()
.Be(1);
}
public void Validate_GivenEmptyProviderVersionId_ValidIsFalse()
{
//Arrange
SpecificationCreateModel model = CreateModel();
model.ProviderVersionId = string.Empty;
SpecificationCreateModelValidator validator = CreateValidator();
//Act
ValidationResult result = validator.Validate(model);
//Assert
result
.IsValid
.Should()
.BeFalse();
result
.Errors.Select(x => x.PropertyName == "ProviderVersionId" && x.ErrorCode == "NotEmptyValidator")
.Count()
.Should()
.Be(1);
}
public void Validate_GivenNameAlreadyExists_ValidIsFalse()
{
//Arrange
SpecificationCreateModel model = CreateModel();
ISpecificationsRepository repository = CreateSpecificationsRepository(true);
SpecificationCreateModelValidator validator = CreateValidator(repository);
//Act
ValidationResult result = validator.Validate(model);
//Assert
result
.IsValid
.Should()
.BeFalse();
result
.Errors
.Count
.Should()
.Be(1);
}
public void Validate_GivenEmptyDescription_ValidIsTrue()
{
//Arrange
SpecificationCreateModel model = CreateModel();
model.Description = string.Empty;
SpecificationCreateModelValidator validator = CreateValidator();
//Act
ValidationResult result = validator.Validate(model);
//Assert
result
.IsValid
.Should()
.BeTrue();
result
.Errors
.Count
.Should()
.Be(0);
}
public async Task SpecificationsService_CreateSpecification_WhenValidInputProvided_ThenSpecificationIsCreated()
{
// Arrange
const string fundingStreamId = "fs1";
const string fundingPeriodId = "fp1";
ISpecificationsRepository specificationsRepository = CreateSpecificationsRepository();
ISearchRepository <SpecificationIndex> searchRepository = CreateSearchRepository();
IMapper mapper = CreateImplementedMapper();
IVersionRepository <SpecificationVersion> versionRepository = CreateVersionRepository();
SpecificationsService specificationsService = CreateService(
specificationsRepository: specificationsRepository,
searchRepository: searchRepository,
mapper: mapper,
specificationVersionRepository: versionRepository);
SpecificationCreateModel specificationCreateModel = new SpecificationCreateModel()
{
Name = "Specification Name",
Description = "Specification Description",
FundingPeriodId = "fp1",
FundingStreamIds = new List <string>()
{
fundingStreamId
},
};
string json = JsonConvert.SerializeObject(specificationCreateModel);
byte[] byteArray = Encoding.UTF8.GetBytes(json);
MemoryStream stream = new MemoryStream(byteArray);
ClaimsPrincipal principle = new ClaimsPrincipal(new[]
{
new ClaimsIdentity(new [] { new Claim(ClaimTypes.Sid, UserId), new Claim(ClaimTypes.Name, Username) })
});
HttpContext context = Substitute.For <HttpContext>();
context
.User
.Returns(principle);
HttpRequest request = Substitute.For <HttpRequest>();
request
.Body
.Returns(stream);
request
.HttpContext
.Returns(context);
specificationsRepository
.GetSpecificationByQuery(Arg.Any <Expression <Func <Specification, bool> > >())
.Returns((Specification)null);
Period fundingPeriod = new Period()
{
Id = fundingPeriodId,
Name = "Funding Period 1"
};
specificationsRepository
.GetPeriodById(Arg.Is(fundingPeriodId))
.Returns(fundingPeriod);
FundingStream fundingStream = new FundingStream()
{
Id = fundingStreamId,
Name = "Funding Stream 1",
AllocationLines = new List <AllocationLine>(),
};
specificationsRepository
.GetFundingStreamById(Arg.Is(fundingStreamId))
.Returns(fundingStream);
DateTime createdDate = new DateTime(2018, 1, 2, 5, 6, 2);
SpecificationVersion specificationVersion = new SpecificationVersion()
{
Description = "Specification Description",
FundingPeriod = new Reference("fp1", "Funding Period 1"),
Date = createdDate,
PublishStatus = Models.Versioning.PublishStatus.Draft,
FundingStreams = new List <Reference>()
{
new Reference(FundingStreamId, "Funding Stream 1")
},
Name = "Specification Name",
Version = 1,
SpecificationId = SpecificationId
};
versionRepository
.CreateVersion(Arg.Any <SpecificationVersion>())
.Returns(specificationVersion);
DocumentEntity <Specification> createdSpecification = new DocumentEntity <Specification>()
{
Content = new Specification()
{
Name = "Specification Name",
Id = "createdSpec",
Current = specificationVersion
},
};
specificationsRepository
.CreateSpecification(Arg.Is <Specification>(
s => s.Name == specificationCreateModel.Name &&
s.Current.Description == specificationCreateModel.Description &&
s.Current.FundingPeriod.Id == fundingPeriodId))
.Returns(createdSpecification);
// Act
IActionResult result = await specificationsService.CreateSpecification(request);
// Assert
result
.Should()
.BeOfType <OkObjectResult>()
.Which
.Value
.Should()
.BeOfType <SpecificationCurrentVersion>()
.And
.NotBeNull();
await specificationsRepository
.Received(1)
.CreateSpecification(Arg.Is <Specification>(
s => s.Name == specificationCreateModel.Name &&
s.Current.Description == specificationCreateModel.Description &&
s.Current.FundingPeriod.Id == fundingPeriodId));
await searchRepository
.Received(1)
.Index(Arg.Is <List <SpecificationIndex> >(c =>
c.Count() == 1 &&
!string.IsNullOrWhiteSpace(c.First().Id) &&
c.First().Name == specificationCreateModel.Name
));
await versionRepository
.Received(1)
.SaveVersion(Arg.Is <SpecificationVersion>(
m => !string.IsNullOrWhiteSpace(m.EntityId) &&
m.PublishStatus == Models.Versioning.PublishStatus.Draft &&
m.Description == "Specification Description" &&
m.FundingPeriod.Id == "fp1" &&
m.FundingPeriod.Name == "Funding Period 1" &&
m.FundingStreams.Any() &&
m.Name == "Specification Name" &&
m.Version == 1
));
}
public async Task SpecificationsService_CreateSpecification_WhenFundingStreamIDIsProvidedButDoesNotExist_ThenPreConditionFailedReturned()
{
// Arrange
const string fundingStreamId = "fs1";
const string fundingStreamNotFoundId = "notfound";
const string fundingPeriodId = "fp1";
ISpecificationsRepository specificationsRepository = CreateSpecificationsRepository();
ISearchRepository <SpecificationIndex> searchRepository = CreateSearchRepository();
IMapper mapper = CreateImplementedMapper();
SpecificationsService specificationsService = CreateService(
specificationsRepository: specificationsRepository,
searchRepository: searchRepository,
mapper: mapper);
SpecificationCreateModel specificationCreateModel = new SpecificationCreateModel()
{
Name = "Specification Name",
Description = "Specification Description",
FundingPeriodId = "fp1",
FundingStreamIds = new List <string>()
{
fundingStreamId, fundingStreamNotFoundId,
},
};
string json = JsonConvert.SerializeObject(specificationCreateModel);
byte[] byteArray = Encoding.UTF8.GetBytes(json);
MemoryStream stream = new MemoryStream(byteArray);
ClaimsPrincipal principle = new ClaimsPrincipal(new[]
{
new ClaimsIdentity(new [] { new Claim(ClaimTypes.Sid, UserId), new Claim(ClaimTypes.Name, Username) })
});
HttpContext context = Substitute.For <HttpContext>();
context
.User
.Returns(principle);
HttpRequest request = Substitute.For <HttpRequest>();
request
.Body
.Returns(stream);
request
.HttpContext
.Returns(context);
specificationsRepository
.GetSpecificationByQuery(Arg.Any <Expression <Func <Specification, bool> > >())
.Returns((Specification)null);
Period fundingPeriod = new Period()
{
Id = fundingPeriodId,
Name = "Funding Period 1"
};
specificationsRepository
.GetPeriodById(Arg.Is(fundingPeriodId))
.Returns(fundingPeriod);
FundingStream fundingStream = new FundingStream()
{
Id = fundingStreamId,
Name = "Funding Stream 1",
AllocationLines = new List <AllocationLine>(),
};
specificationsRepository
.GetFundingStreamById(Arg.Is(fundingStreamId))
.Returns(fundingStream);
specificationsRepository
.GetFundingStreamById(Arg.Is(fundingStreamNotFoundId))
.Returns((FundingStream)null);
// Act
IActionResult result = await specificationsService.CreateSpecification(request);
// Assert
result
.Should()
.BeOfType <PreconditionFailedResult>()
.Which
.Value
.Should()
.Be("Unable to find funding stream with ID 'notfound'.");
await specificationsRepository
.Received(1)
.GetFundingStreamById(Arg.Is(fundingStreamNotFoundId));
await specificationsRepository
.Received(1)
.GetFundingStreamById(Arg.Is(fundingStreamId));
}
