public DummyMemberObject DTOToDummyMemberObject(MemberDTO_Create memberDTO)
{
MembershipLevelEnum memberShipLevel = GetMemberShipLevel(memberDTO);
return(new DummyMemberObject()
{
FirstName = memberDTO.FirstName,
LastName = memberDTO.LastName,
MembershipLevel = memberShipLevel,
Address = _addressMapper.DTOToAddress(memberDTO.Address),
LicensePlate = _licensePlateMapper.DTOListToLicensePlateObject(memberDTO.LicensePlate),
PhoneNumber = _phoneNumpberMapper.DTOListToPhoneNumpberObject(memberDTO.PhoneNumber)
});
}
private static MembershipLevelEnum GetMemberShipLevel(MemberDTO_Create memberDTO)
{
MembershipLevelEnum memberShipLevel;
try
{
memberShipLevel = (MembershipLevelEnum)Enum.Parse(typeof(MembershipLevelEnum), memberDTO.MembershipLevel);
}
catch
{
memberShipLevel = MembershipLevelEnum.Bronze;
}
return(memberShipLevel);
}
private static MembershipLevelEnum GetMemberShipLevel(MemberDTO_Create memberDTO)
{
MembershipLevelEnum memberShipLevel;
try
{
//Please use TryParse to handle incorrect parsing
//Try-catch creates a virtual sandbox for your code, this creates compiler overhead, try to avoid this
memberShipLevel = (MembershipLevelEnum)Enum.Parse(typeof(MembershipLevelEnum), memberDTO.MembershipLevel);
}
catch
{
memberShipLevel = MembershipLevelEnum.Bronze;
}
return(memberShipLevel);
}
public void GivenCreateMemberFromMemberDTOCreate_WhenGivenAMemberDTOCreate_ThenCreateAMember()
{
var memstub = Substitute.For <IMemberServices>();
CityDTO cityDTO = new CityDTO {
ZIP = 2050, CityName = "Antwerpen", CountryName = "Belgium"
};
AddressDTO addressDTO = new AddressDTO {
StreetName = "test", StreetNumber = "5", CityDTO = cityDTO
};
MemberDTO_Create newMemDTOO = new MemberDTO_Create()
{
FirstName = "lars", LastName = "ff", Address = addressDTO
};
var newMapper = new MemberMapper(new AddressMapper(new CityMapper(memstub)), new MembershipLevelMapper(), new LicensePlateMapper(), new PhoneNumpberMapper());
var result = newMapper.DTOToDummyMemberObject(newMemDTOO);
Assert.IsType <DummyMemberObject>(result);
}
public ActionResult <MemberDTO_Return> CreateMember(MemberDTO_Create memberDTO)
{
var dummyMember = _memberMapper.DTOToDummyMemberObject(memberDTO);
var member = _memberService.CreateNewMember(dummyMember);
if (member == null)
{
return(BadRequest("Not valid"));
}
var result = _memberService.AddPhonenumersAndLicensPlatesToMember(dummyMember, member);
if (!result)
{
return(BadRequest("Not valid"));
}
return(Ok(_memberMapper.MemberToDTOReturn(member)));
}
public ActionResult <MemberDTO_Return> CreateMember(MemberDTO_Create memberDTO)
{
var dummyMember = _memberMapper.DTOToDummyMemberObject(memberDTO);
var member = _memberService.CreateNewMember(dummyMember);
if (member == null)
{
//Good, but state what is wrong: BadRequest("Member could not be created")
return(BadRequest("Not valid"));
}
var result = _memberService.AddPhonenumersAndLicensPlatesToMember(dummyMember, member);
if (!result)
{
//Good, but state what is wrong: BadRequest("Member's subdata could not be created")
//Better yet, do everything in one method and SaveChanges to create an atomic save (all or nothing)
return(BadRequest("Not valid"));
}
return(Ok(_memberMapper.MemberToDTOReturn(member)));
}
