private static LibraryDependency ToPackageLibraryDependency(PackageReference reference, bool isCpvmEnabled)
{
var dependency = new LibraryDependency
{
AutoReferenced = MSBuildStringUtility.IsTrue(GetReferenceMetadataValue(reference, ProjectItemProperties.IsImplicitlyDefined)),
GeneratePathProperty = MSBuildStringUtility.IsTrue(GetReferenceMetadataValue(reference, ProjectItemProperties.GeneratePathProperty)),
Aliases = GetReferenceMetadataValue(reference, ProjectItemProperties.Aliases, defaultValue: null),
LibraryRange = new LibraryRange(
name: reference.Name,
versionRange: ToVersionRange(reference.Version, isCpvmEnabled),
typeConstraint: LibraryDependencyTarget.Package)
};
MSBuildRestoreUtility.ApplyIncludeFlags(
dependency,
GetReferenceMetadataValue(reference, ProjectItemProperties.IncludeAssets),
GetReferenceMetadataValue(reference, ProjectItemProperties.ExcludeAssets),
GetReferenceMetadataValue(reference, ProjectItemProperties.PrivateAssets));
// Add warning suppressions
foreach (var code in MSBuildStringUtility.GetNuGetLogCodes(GetReferenceMetadataValue(reference, ProjectItemProperties.NoWarn)))
{
dependency.NoWarn.Add(code);
}
return(dependency);
}
/// <summary>
/// Gets the package references for the specified project.
/// </summary>
/// <param name="project">The <see cref="ProjectInstance" /> to get package references for.</param>
/// <returns>A <see cref="List{LibraryDependency}" /> containing the package references for the specified project.</returns>
internal static List <LibraryDependency> GetPackageReferences(IMSBuildProject project)
{
// Get the distinct PackageReference items, ignoring duplicates
var packageReferenceItems = project.GetItems("PackageReference").Distinct(ProjectItemInstanceEvaluatedIncludeComparer.Instance).ToList();
var libraryDependencies = new List <LibraryDependency>(packageReferenceItems.Count);
foreach (var packageReferenceItem in packageReferenceItems)
{
string version = packageReferenceItem.GetProperty("Version");
libraryDependencies.Add(new LibraryDependency
{
AutoReferenced = packageReferenceItem.IsPropertyTrue("IsImplicitlyDefined"),
GeneratePathProperty = packageReferenceItem.IsPropertyTrue("GeneratePathProperty"),
IncludeType = GetLibraryIncludeFlags(packageReferenceItem.GetProperty("IncludeAssets"), LibraryIncludeFlags.All) & ~GetLibraryIncludeFlags(packageReferenceItem.GetProperty("ExcludeAssets"), LibraryIncludeFlags.None),
LibraryRange = new LibraryRange(
packageReferenceItem.Identity,
!string.IsNullOrWhiteSpace(version) ? VersionRange.Parse(version) : VersionRange.All,
LibraryDependencyTarget.Package),
NoWarn = MSBuildStringUtility.GetNuGetLogCodes(packageReferenceItem.GetProperty("NoWarn")).ToList(),
SuppressParent = GetLibraryIncludeFlags(packageReferenceItem.GetProperty("PrivateAssets"), LibraryIncludeFlagUtils.DefaultSuppressParent)
});
}
return(libraryDependencies);
}
private static LibraryDependency ToPackageLibraryDependency(IVsReferenceItem item, bool cpvmEnabled)
{
if (!TryGetVersionRange(item, out VersionRange versionRange))
{
versionRange = cpvmEnabled ? null : VersionRange.All;
}
var dependency = new LibraryDependency
{
LibraryRange = new LibraryRange(
name: item.Name,
versionRange: versionRange,
typeConstraint: LibraryDependencyTarget.Package),
// Mark packages coming from the SDK as AutoReferenced
AutoReferenced = GetPropertyBoolOrFalse(item, "IsImplicitlyDefined"),
GeneratePathProperty = GetPropertyBoolOrFalse(item, "GeneratePathProperty"),
Aliases = GetPropertyValueOrNull(item, "Aliases"),
};
// Add warning suppressions
foreach (var code in MSBuildStringUtility.GetNuGetLogCodes(GetPropertyValueOrNull(item, ProjectBuildProperties.NoWarn)))
{
dependency.NoWarn.Add(code);
}
MSBuildRestoreUtility.ApplyIncludeFlags(
dependency,
includeAssets: GetPropertyValueOrNull(item, ProjectBuildProperties.IncludeAssets),
excludeAssets: GetPropertyValueOrNull(item, ProjectBuildProperties.ExcludeAssets),
privateAssets: GetPropertyValueOrNull(item, ProjectBuildProperties.PrivateAssets));
return(dependency);
}
private static LibraryDependency ToPackageLibraryDependency(IVsReferenceItem item)
{
var dependency = new LibraryDependency
{
LibraryRange = new LibraryRange(
name: item.Name,
versionRange: GetVersionRange(item),
typeConstraint: LibraryDependencyTarget.Package),
// Mark packages coming from the SDK as AutoReferenced
AutoReferenced = GetPropertyBoolOrFalse(item, "IsImplicitlyDefined"),
};
// Add warning suppressions
foreach (var code in MSBuildStringUtility.GetNuGetLogCodes(GetPropertyValueOrNull(item, NoWarn)))
{
dependency.NoWarn.Add(code);
}
MSBuildRestoreUtility.ApplyIncludeFlags(
dependency,
includeAssets: GetPropertyValueOrNull(item, IncludeAssets),
excludeAssets: GetPropertyValueOrNull(item, ExcludeAssets),
privateAssets: GetPropertyValueOrNull(item, PrivateAssets));
return(dependency);
}
private static LibraryDependency ToPackageLibraryDependency(PackageReference reference)
{
var dependency = new LibraryDependency
{
LibraryRange = new LibraryRange(
name: reference.Name,
versionRange: VersionRange.Parse(reference.Version),
typeConstraint: LibraryDependencyTarget.Package)
};
MSBuildRestoreUtility.ApplyIncludeFlags(
dependency,
GetReferenceMetadataValue(reference, ProjectItemProperties.IncludeAssets),
GetReferenceMetadataValue(reference, ProjectItemProperties.ExcludeAssets),
GetReferenceMetadataValue(reference, ProjectItemProperties.PrivateAssets));
dependency.AutoReferenced = MSBuildStringUtility.IsTrue(GetReferenceMetadataValue(reference, ProjectItemProperties.IsImplicitlyDefined));
// Add warning suppressions
foreach (var code in MSBuildStringUtility.GetNuGetLogCodes(GetReferenceMetadataValue(reference, ProjectItemProperties.NoWarn)))
{
dependency.NoWarn.Add(code);
}
return(dependency);
}
public void DependencyNodeEqualityFails_NodesHaveDifferentProjectWideWarningProperties(
string firstNoWarn,
string secondNoWarn)
{
// Arrange
var packageId1 = "test_id1";
var packageId2 = "test_id2";
// Arrange
var firstProjectWideNoWarn = new HashSet <NuGetLogCode>(MSBuildStringUtility.GetNuGetLogCodes(firstNoWarn));
var firstPackageSpecificNoWarn = new Dictionary <string, HashSet <NuGetLogCode> >
{
{ packageId1, new HashSet <NuGetLogCode> {
NuGetLogCode.NU1601, NuGetLogCode.NU1108
} },
{ packageId2, new HashSet <NuGetLogCode> {
NuGetLogCode.NU1601, NuGetLogCode.NU1701
} }
};
var secondProjectWideNoWarn = new HashSet <NuGetLogCode>(MSBuildStringUtility.GetNuGetLogCodes(secondNoWarn));
var secondPackageSpecificNoWarn = new Dictionary <string, HashSet <NuGetLogCode> >
{
{ packageId1, new HashSet <NuGetLogCode> {
NuGetLogCode.NU1601, NuGetLogCode.NU1108
} },
{ packageId2, new HashSet <NuGetLogCode> {
NuGetLogCode.NU1601, NuGetLogCode.NU1701
} }
};
var first = new TransitiveNoWarnUtils.DependencyNode(
id: "test",
isProject: true,
nodeWarningProperties: new TransitiveNoWarnUtils.NodeWarningProperties(
firstProjectWideNoWarn,
firstPackageSpecificNoWarn
));
var second = new TransitiveNoWarnUtils.DependencyNode(
id: "test",
isProject: true,
nodeWarningProperties: new TransitiveNoWarnUtils.NodeWarningProperties(
secondProjectWideNoWarn,
secondPackageSpecificNoWarn
));
// Act
var seen = new HashSet <TransitiveNoWarnUtils.DependencyNode>
{
first,
second
};
// Assert
seen.Count.Should().Be(2);
}
/// <summary>
/// Create warning properties from the msbuild property strings.
/// </summary>
public static WarningProperties GetWarningProperties(string treatWarningsAsErrors, string warningsAsErrors, string noWarn)
{
var props = new WarningProperties()
{
AllWarningsAsErrors = MSBuildStringUtility.IsTrue(treatWarningsAsErrors)
};
props.WarningsAsErrors.UnionWith(MSBuildStringUtility.GetNuGetLogCodes(warningsAsErrors));
props.NoWarn.UnionWith(MSBuildStringUtility.GetNuGetLogCodes(noWarn));
return(props);
}
public void NodeWarningPropertiesIsSubSetOf_WithEqualProjectWideNoWarns_Succeeds(
string noWarn)
{
// Arrange
var first = new TransitiveNoWarnUtils.NodeWarningProperties(
noWarn == null ? null : MSBuildStringUtility.GetNuGetLogCodes(noWarn).ToHashSet(),
null);
var second = new TransitiveNoWarnUtils.NodeWarningProperties(
noWarn == null ? null : MSBuildStringUtility.GetNuGetLogCodes(noWarn).ToHashSet(),
null);
// Act
var result = first.IsSubSetOf(second);
// Assert
result.Should().Be(true);
}
public void NodeWarningPropertiesIsSubSetOf_WithSecondProjectWideNoWarnNotASubsetOfFirst_Fails(
string firstNoWarn,
string secondNoWarn)
{
// Arrange
var first = new TransitiveNoWarnUtils.NodeWarningProperties(
firstNoWarn == null ? null : MSBuildStringUtility.GetNuGetLogCodes(firstNoWarn).ToHashSet(),
null);
var second = new TransitiveNoWarnUtils.NodeWarningProperties(
MSBuildStringUtility.GetNuGetLogCodes(secondNoWarn).ToHashSet(),
null);
// Act
var result = first.IsSubSetOf(second);
// Assert
result.Should().Be(false);
}
public void MergeProjectWideWarningProperties_MergesNonEmptyCollections(
string firstNoWarn,
string secondNoWarn,
string expectedNoWarn)
{
// Arrange
var first = new HashSet <NuGetLogCode>(MSBuildStringUtility.GetNuGetLogCodes(firstNoWarn));
var second = new HashSet <NuGetLogCode>(MSBuildStringUtility.GetNuGetLogCodes(secondNoWarn));
var expected = new HashSet <NuGetLogCode>(MSBuildStringUtility.GetNuGetLogCodes(expectedNoWarn));
// Act
var merged = TransitiveNoWarnUtils.MergeCodes(first, second);
// Assert
merged.Should().NotBeNull();
merged.Should().BeEquivalentTo(expected);
}
internal static WarningProperties GetProjectWideWarningProperties(IEnumerable targetFrameworks)
{
return(WarningProperties.GetWarningProperties(
treatWarningsAsErrors: GetSingleOrDefaultPropertyValue(targetFrameworks, ProjectBuildProperties.TreatWarningsAsErrors, e => e),
warningsAsErrors: GetSingleOrDefaultNuGetLogCodes(targetFrameworks, ProjectBuildProperties.WarningsAsErrors, e => MSBuildStringUtility.GetNuGetLogCodes(e)),
noWarn: GetSingleOrDefaultNuGetLogCodes(targetFrameworks, ProjectBuildProperties.NoWarn, e => MSBuildStringUtility.GetNuGetLogCodes(e))));
}
private static PackageSpec ToPackageSpec(ProjectNames projectNames, IVsProjectRestoreInfo projectRestoreInfo)
{
var tfis = projectRestoreInfo
.TargetFrameworks
.Cast <IVsTargetFrameworkInfo>()
.Select(ToTargetFrameworkInformation)
.ToArray();
var projectFullPath = Path.GetFullPath(projectNames.FullName);
var projectDirectory = Path.GetDirectoryName(projectFullPath);
// TODO: Remove temporary integration code NuGet/Home#3810
// Initialize OTF and CT values when original value of OTF property is not provided.
var originalTargetFrameworks = tfis
.Select(tfi => tfi.FrameworkName.GetShortFolderName())
.ToArray();
var crossTargeting = originalTargetFrameworks.Length > 1;
// if "TargetFrameworks" property presents in the project file prefer the raw value.
if (!string.IsNullOrWhiteSpace(projectRestoreInfo.OriginalTargetFrameworks))
{
originalTargetFrameworks = MSBuildStringUtility.Split(
projectRestoreInfo.OriginalTargetFrameworks);
// cross-targeting is always ON even in case of a single tfm in the list.
crossTargeting = true;
}
var outputPath = Path.GetFullPath(
Path.Combine(
projectDirectory,
projectRestoreInfo.BaseIntermediatePath));
var projectName = GetPackageId(projectNames, projectRestoreInfo.TargetFrameworks);
var packageSpec = new PackageSpec(tfis)
{
Name = projectName,
Version = GetPackageVersion(projectRestoreInfo.TargetFrameworks),
FilePath = projectFullPath,
RestoreMetadata = new ProjectRestoreMetadata
{
ProjectName = projectName,
ProjectUniqueName = projectFullPath,
ProjectPath = projectFullPath,
OutputPath = outputPath,
ProjectStyle = ProjectStyle.PackageReference,
TargetFrameworks = projectRestoreInfo.TargetFrameworks
.Cast <IVsTargetFrameworkInfo>()
.Select(item => ToProjectRestoreMetadataFrameworkInfo(item, projectDirectory))
.ToList(),
OriginalTargetFrameworks = originalTargetFrameworks,
CrossTargeting = crossTargeting,
// Read project properties for settings. ISettings values will be applied later since
// this value is put in the nomination cache and ISettings could change.
PackagesPath = GetRestoreProjectPath(projectRestoreInfo.TargetFrameworks),
FallbackFolders = GetRestoreFallbackFolders(projectRestoreInfo.TargetFrameworks).AsList(),
Sources = GetRestoreSources(projectRestoreInfo.TargetFrameworks)
.Select(e => new PackageSource(e))
.ToList(),
ProjectWideWarningProperties = WarningProperties.GetWarningProperties(
treatWarningsAsErrors: GetSingleOrDefaultPropertyValue(projectRestoreInfo.TargetFrameworks, TreatWarningsAsErrors, e => e),
warningsAsErrors: GetSingleOrDefaultNuGetLogCodes(projectRestoreInfo.TargetFrameworks, WarningsAsErrors, e => MSBuildStringUtility.GetNuGetLogCodes(e)),
noWarn: GetSingleOrDefaultNuGetLogCodes(projectRestoreInfo.TargetFrameworks, NoWarn, e => MSBuildStringUtility.GetNuGetLogCodes(e))),
CacheFilePath = NoOpRestoreUtilities.GetProjectCacheFilePath(cacheRoot: outputPath, projectPath: projectFullPath)
},
RuntimeGraph = GetRuntimeGraph(projectRestoreInfo),
RestoreSettings = new ProjectRestoreSettings()
{
HideWarningsAndErrors = true
}
};
return(packageSpec);
}
/// <summary>
/// Create warning properties from the msbuild property strings.
/// </summary>
public static WarningProperties GetWarningProperties(string treatWarningsAsErrors, string warningsAsErrors, string noWarn)
{
return(GetWarningProperties(treatWarningsAsErrors, MSBuildStringUtility.GetNuGetLogCodes(warningsAsErrors), (MSBuildStringUtility.GetNuGetLogCodes(noWarn))));
}