public void Name()
{
// arrange
var parser = new InspectCodeParser();
// act
var name = parser.Name;
// assert
Assert.Equal("InspectCode", name);
}
public void CanParse(string xmlContent, bool expectedResult)
{
// arrange
var doc = XDocument.Parse(xmlContent);
var parser = new InspectCodeParser();
// act
var result = parser.CanParse(doc);
// assert
Assert.Equal(expectedResult, result);
}
public void CanParse_LoadingException()
{
// arrange
var parser = new InspectCodeParser();
parser.FileSystem = new MockFileSystem(new Dictionary <string, MockFileData>
{
{ "wrongreport.xml", new MockFileData("<Report ToolsVersion=\"8.2\"></Rport>") },
});
// act
var exception = Assert.Throws <Exceptions.LoadingReportException>(() => parser.CanParse("wrongreport.xml"));
// assert
Assert.Equal(3, exception.ExitCode);
Assert.Equal("An exception happened when loading the report 'wrongreport.xml'", exception.Message);
Assert.NotNull(exception.InnerException);
}
public void CanParse(string reportPath, bool expectedResult)
{
// arrange
var parser = new InspectCodeParser();
parser.FileSystem = new MockFileSystem(new Dictionary <string, MockFileData>
{
{ "inspectcodereport.xml", new MockFileData(TestUtilities.GetEmbeddedResourceContent("inspectcodereport.xml")) },
{ "inspectcodereport_2016.2.xml", new MockFileData(TestUtilities.GetEmbeddedResourceContent("inspectcodereport_2016.2.xml")) },
{ "emptyreport.xml", new MockFileData("<Report ToolsVersion=\"8.2\"></Report>") },
{ "onlyissues.xml", new MockFileData("<IssueTypes></IssueTypes>") },
{ "falsereport.xml", new MockFileData("{<IssueTypes></IssueTypes>") },
});
// act
var result = parser.CanParse(reportPath);
// assert
Assert.Equal(expectedResult, result);
}
public void Parse_SlnInSubFolder()
{
// arrange
var report = XDocument.Parse(TestUtilities.GetEmbeddedResourceContent("inspectcodereport.xml"));
report.Root.Element("Information").Element("Solution").Value = Path.Combine("src", "Vika.sln");
var fileSystem = new MockFileSystem(new Dictionary <string, MockFileData>
{
{ "inspectcodereport.xml", new MockFileData(report.ToString()) },
{ Path.Combine("src", @"NVika\BuildServers\AppVeyor.cs"), new MockFileData(TestUtilities.GetEmbeddedResourceContent("AppVeyor.txt")) }
});
var parser = new InspectCodeParser();
parser.FileSystem = fileSystem;
// act
var result = parser.Parse("inspectcodereport.xml");
// assert
Assert.Equal(41, result.Count());
var issue = result.First();
Assert.Equal("Constraints Violations", issue.Category);
Assert.Equal("Inconsistent Naming", issue.Description);
Assert.Equal(Path.Combine("src", @"NVika\BuildServers\AppVeyor.cs"), issue.FilePath);
Assert.Null(issue.HelpUri);
Assert.Equal(15u, issue.Line);
Assert.Equal("Name '_appVeyorAPIUrl' does not match rule 'Instance fields (private)'. Suggested name is '_appVeyorApiUrl'.", issue.Message);
Assert.Equal("InconsistentNaming", issue.Name);
Assert.Equal(32u, issue.Offset.Start);
Assert.Equal(47u, issue.Offset.End);
Assert.Equal("NVika", issue.Project);
Assert.Equal(IssueSeverity.Warning, issue.Severity);
Assert.Equal("InspectCode", issue.Source);
}
public void Parse(XDocument report)
{
// arrange
var parser = new InspectCodeParser();
// act
var result = parser.Parse(report);
// assert
Assert.Equal(53, result.Count());
var issue = result.First();
Assert.Equal("Constraints Violations", issue.Category);
Assert.Equal("Inconsistent Naming", issue.Description);
Assert.Equal(@"NVika\BuildServerCommand.cs", issue.FilePath);
Assert.Null(issue.HelpUri);
Assert.Equal(14u, issue.Line);
Assert.Equal("Name 'reportPath' does not match rule 'Instance fields (private)'. Suggested name is '_reportPath'.", issue.Message);
Assert.Equal("InconsistentNaming", issue.Name);
Assert.Equal(319u, issue.Offset.Start);
Assert.Equal(329u, issue.Offset.End);
Assert.Equal("NVika", issue.Project);
Assert.Equal(IssueSeverity.Warning, issue.Severity);
Assert.Equal("InspectCode", issue.Source);
issue = result.Skip(49).First();
Assert.Equal("Redundancies in Symbol Declarations", issue.Category);
Assert.Equal("Type or type member is never used: Non-private accessibility", issue.Description);
Assert.Equal(@"NVika.Tests\Class1.cs", issue.FilePath);
Assert.Null(issue.HelpUri);
Assert.Equal(8u, issue.Line);
Assert.Equal("Class 'Class1' is never used", issue.Message);
Assert.Equal("UnusedMember.Global", issue.Name);
Assert.Equal(135u, issue.Offset.Start);
Assert.Equal(141u, issue.Offset.End);
Assert.Equal("NVika.Tests", issue.Project);
Assert.Equal(IssueSeverity.Suggestion, issue.Severity);
Assert.Equal("InspectCode", issue.Source);
issue = result.Skip(50).First();
Assert.Equal("Redundancies in Code", issue.Category);
Assert.Equal("Redundant using directive", issue.Description);
Assert.Equal(@"NVika.Tests\Properties\AssemblyInfo.cs", issue.FilePath);
Assert.Equal("http://confluence.jetbrains.net/display/ReSharper/Redundant+using+directive", issue.HelpUri.AbsoluteUri);
Assert.Equal(2u, issue.Line);
Assert.Equal("Using directive is not required by the code and can be safely removed", issue.Message);
Assert.Equal("RedundantUsingDirective", issue.Name);
Assert.Equal(26u, issue.Offset.Start);
Assert.Equal(64u, issue.Offset.End);
Assert.Equal("NVika.Tests", issue.Project);
Assert.Equal(IssueSeverity.Warning, issue.Severity);
Assert.Equal("InspectCode", issue.Source);
issue = result.Skip(51).First();
Assert.Equal("C# Compiler Errors", issue.Category);
Assert.Equal("", issue.Description);
Assert.Equal(@"NVika.Tests\Class1.cs", issue.FilePath);
Assert.Null(issue.HelpUri);
Assert.Equal(42u, issue.Line);
Assert.Equal("Some compiler error", issue.Message);
Assert.Equal("CSharpErrors", issue.Name);
Assert.Null(issue.Offset);
Assert.Equal("NVika.Tests", issue.Project);
Assert.Equal(IssueSeverity.Error, issue.Severity);
Assert.Equal("InspectCode", issue.Source);
issue = result.Last();
Assert.Equal("Common Practices and Code Improvements", issue.Category);
Assert.Equal("Make constructor in abstract class protected", issue.Description);
Assert.Equal(@"NVika\Parsers\Issue.cs", issue.FilePath);
Assert.Equal("http://confluence.jetbrains.net/display/ReSharper/Make+constructor+in+abstract+class+protected", issue.HelpUri.AbsoluteUri);
Assert.Equal(43u, issue.Line);
Assert.Equal("Using directive is not required by the code and can be safely removed", issue.Message);
Assert.Equal("PublicConstructorInAbstractClassHint", issue.Name);
Assert.NotNull(issue.Offset);
Assert.Null(issue.Offset.Start);
Assert.Null(issue.Offset.End);
Assert.Equal("NVika.Tests", issue.Project);
Assert.Equal(IssueSeverity.Hint, issue.Severity);
Assert.Equal("InspectCode", issue.Source);
}
public void Parse(XDocument report)
{
// arrange
var fileSystem = new MockFileSystem(new Dictionary <string, MockFileData>
{
{ @"NVika\BuildServers\AppVeyor.cs", new MockFileData(GetEmbeddedResourceContent("AppVeyor.txt")) },
{ @"NVika\BuildServers\LocalBuildServer.cs", new MockFileData(GetEmbeddedResourceContent("LocalBuildServer.txt")) },
{ @"NVika\ParseReportCommand.cs", new MockFileData(GetEmbeddedResourceContent("ParseReportCommand.txt")) },
{ @"NVika\Parsers\InspectCodeParser.cs", new MockFileData(GetEmbeddedResourceContent("InspectCodeParser.txt")) },
{ @"NVika\Program.cs", new MockFileData(GetEmbeddedResourceContent("Program.txt")) },
});
var parser = new InspectCodeParser(fileSystem);
// act
var result = parser.Parse(report);
// assert
Assert.Equal(41, result.Count());
var issue = result.First();
Assert.Equal("Constraints Violations", issue.Category);
Assert.Equal("Inconsistent Naming", issue.Description);
Assert.Equal(@"NVika\BuildServers\AppVeyor.cs", issue.FilePath);
Assert.Null(issue.HelpUri);
Assert.Equal(15u, issue.Line);
Assert.Equal("Name '_appVeyorAPIUrl' does not match rule 'Instance fields (private)'. Suggested name is '_appVeyorApiUrl'.", issue.Message);
Assert.Equal("InconsistentNaming", issue.Name);
Assert.Equal(32u, issue.Offset.Start);
Assert.Equal(47u, issue.Offset.End);
Assert.Equal("NVika", issue.Project);
Assert.Equal(IssueSeverity.Warning, issue.Severity);
Assert.Equal("InspectCode", issue.Source);
issue = result.Skip(7).First();
Assert.Equal("Common Practices and Code Improvements", issue.Category);
Assert.Equal("Convert local variable or field to constant: Private accessibility", issue.Description);
Assert.Equal(@"NVika\BuildServers\LocalBuildServer.cs", issue.FilePath);
Assert.Null(issue.HelpUri);
Assert.Equal(9u, issue.Line);
Assert.Equal("Convert to constant", issue.Message);
Assert.Equal("ConvertToConstant.Local", issue.Name);
Assert.Equal(30u, issue.Offset.Start);
Assert.Equal(42u, issue.Offset.End);
Assert.Equal("NVika", issue.Project);
Assert.Equal(IssueSeverity.Suggestion, issue.Severity);
Assert.Equal("InspectCode", issue.Source);
issue = result.Skip(21).First();
Assert.Equal("Redundancies in Code", issue.Category);
Assert.Equal("Redundant 'this.' qualifier", issue.Description);
Assert.Equal(@"NVika\ParseReportCommand.cs", issue.FilePath);
Assert.Null(issue.HelpUri);
Assert.Equal(33u, issue.Line);
Assert.Equal("Qualifier 'this.' is redundant", issue.Message);
Assert.Equal("RedundantThisQualifier", issue.Name);
Assert.Equal(12u, issue.Offset.Start);
Assert.Equal(17u, issue.Offset.End);
Assert.Equal("NVika", issue.Project);
Assert.Equal(IssueSeverity.Warning, issue.Severity);
Assert.Equal("InspectCode", issue.Source);
issue = result.Skip(33).First();
Assert.Equal("Language Usage Opportunities", issue.Category);
Assert.Equal("Loop can be converted into LINQ-expression", issue.Description);
Assert.Equal(@"NVika\Parsers\InspectCodeParser.cs", issue.FilePath);
Assert.Equal("http://confluence.jetbrains.net/display/ReSharper/Loop+can+be+converted+into+a+LINQ+expression", issue.HelpUri.AbsoluteUri);
Assert.Equal(27u, issue.Line);
Assert.Equal("Loop can be converted into LINQ-expression", issue.Message);
Assert.Equal("LoopCanBeConvertedToQuery", issue.Name);
Assert.Equal(12u, issue.Offset.Start);
Assert.Equal(19u, issue.Offset.End);
Assert.Equal("NVika", issue.Project);
Assert.Equal(IssueSeverity.Suggestion, issue.Severity);
Assert.Equal("InspectCode", issue.Source);
issue = result.Skip(38).First();
Assert.Equal("Potential Code Quality Issues", issue.Category);
Assert.Equal("Auto-implemented property accessor is never used: Private accessibility", issue.Description);
Assert.Equal(@"NVika\Parsers\InspectCodeParser.cs", issue.FilePath);
Assert.Null(issue.HelpUri);
Assert.Equal(1u, issue.Line);
Assert.Equal("Auto-implemented property accessor is never used", issue.Message);
Assert.Equal("UnusedAutoPropertyAccessor.Local", issue.Name);
Assert.Equal(0u, issue.Offset.Start);
Assert.Equal(5u, issue.Offset.End);
Assert.Equal("NVika", issue.Project);
Assert.Equal(IssueSeverity.Error, issue.Severity);
Assert.Equal("InspectCode", issue.Source);
issue = result.Skip(39).First();
Assert.Equal("Redundancies in Code", issue.Category);
Assert.Equal("Redundant 'case' label", issue.Description);
Assert.Equal(@"NVika\Parsers\InspectCodeParser.cs", issue.FilePath);
Assert.Null(issue.HelpUri);
Assert.Null(issue.Line);
Assert.Equal("Redundant case label", issue.Message);
Assert.Equal("RedundantCaseLabel", issue.Name);
Assert.Null(issue.Offset);
Assert.Equal("NVika", issue.Project);
Assert.Equal(IssueSeverity.Hint, issue.Severity);
Assert.Equal("InspectCode", issue.Source);
issue = result.Last();
Assert.Equal("Common Practices and Code Improvements", issue.Category);
Assert.Equal("Parameter type can be IEnumerable<T>: Non-private accessibility", issue.Description);
Assert.Equal(@"NVika\Program.cs", issue.FilePath);
Assert.Null(issue.HelpUri);
Assert.Equal(35u, issue.Line);
Assert.Equal("Parameter can be of type 'IEnumerable<string>'", issue.Message);
Assert.Equal("ParameterTypeCanBeEnumerable.Global", issue.Name);
Assert.NotNull(issue.Offset);
Assert.Equal(25u, issue.Offset.Start);
Assert.Equal(33u, issue.Offset.End);
Assert.Equal("NVika", issue.Project);
Assert.Equal(IssueSeverity.Suggestion, issue.Severity);
Assert.Equal("InspectCode", issue.Source);
}
