public void EmptyArrayCSharp()
{
const string ArrayEmptySource =
@"namespace System { public class Array { public static T[] Empty<T>() { return null; } } }";
const string Source = @"
[System.Runtime.CompilerServices.Dynamic(new bool[0])] // no
class C
{
unsafe void M1()
{
int[] arr1 = new int[0]; // yes
byte[] arr2 = { }; // yes
C[] arr3 = new C[] { }; // yes
string[] arr4 = new string[] { null }; // no
double[] arr5 = new double[1]; // no
int[] arr6 = new[] { 1 }; // no
int[][] arr7 = new int[0][]; // yes
int[][][][] arr8 = new int[0][][][]; // yes
int[,] arr9 = new int[0,0]; // no
int[][,] arr10 = new int[0][,]; // yes
int[][,] arr11 = new int[1][,]; // no
int[,][] arr12 = new int[0,0][]; // no
int*[] arr13 = new int*[0]; // no
List<int> list1 = new List<int>() { } // no
}
}";
const string FixedSource = @"
[System.Runtime.CompilerServices.Dynamic(new bool[0])] // no
class C
{
unsafe void M1()
{
int[] arr1 = System.Array.Empty<int>(); // yes
byte[] arr2 = System.Array.Empty<byte>(); // yes
C[] arr3 = System.Array.Empty<C>(); // yes
string[] arr4 = new string[] { null }; // no
double[] arr5 = new double[1]; // no
int[] arr6 = new[] { 1 }; // no
int[][] arr7 = System.Array.Empty<int[]>(); // yes
int[][][][] arr8 = System.Array.Empty<int[][][]>(); // yes
int[,] arr9 = new int[0,0]; // no
int[][,] arr10 = System.Array.Empty<int[,]>(); // yes
int[][,] arr11 = new int[1][,]; // no
int[,][] arr12 = new int[0,0][]; // no
int*[] arr13 = new int*[0]; // no
List<int> list1 = new List<int>() { } // no
}
}";
VerifyCSharp(Source); // no diagnostics until building against a core lib that has Array.Empty<T>
VerifyCSharp(Source + ArrayEmptySource, new[]
{
GetCSharpResultAt(7, 22, EmptyArrayDiagnosticAnalyzer.UseArrayEmptyDescriptor),
GetCSharpResultAt(8, 23, EmptyArrayDiagnosticAnalyzer.UseArrayEmptyDescriptor),
GetCSharpResultAt(9, 20, EmptyArrayDiagnosticAnalyzer.UseArrayEmptyDescriptor),
GetCSharpResultAt(13, 24, EmptyArrayDiagnosticAnalyzer.UseArrayEmptyDescriptor),
GetCSharpResultAt(14, 28, EmptyArrayDiagnosticAnalyzer.UseArrayEmptyDescriptor),
GetCSharpResultAt(16, 26, EmptyArrayDiagnosticAnalyzer.UseArrayEmptyDescriptor)
});
VerifyCSharpFix(
ArrayEmptySource + Source,
ArrayEmptySource + FixedSource,
allowNewCompilerDiagnostics: true);
VerifyCSharpFix(
"using System;\r\n" + ArrayEmptySource + Source,
"using System;\r\n" + ArrayEmptySource + FixedSource.Replace("System.Array.Empty", "Array.Empty"),
allowNewCompilerDiagnostics: true);
}
public void EmptyArrayVisualBasic()
{
const string ArrayEmptySource = @"
Namespace System
Public Class Array
Public Shared Function Empty(Of T)() As T()
Return Nothing
End Function
End Class
End Namespace
";
const string Source = @"
<System.Runtime.CompilerServices.Dynamic(new Boolean(-1) {})> _
Class C
Sub M1()
Dim arr1 As Integer() = New Integer(-1) { } ' yes
Dim arr2 As Byte() = { } ' yes
Dim arr3 As C() = New C(-1) { } ' yes
Dim arr4 As String() = New String() { Nothing } ' no
Dim arr5 As Double() = New Double(1) { } ' no
Dim arr6 As Integer() = { -1 } ' no
Dim arr7 as Integer()() = New Integer(-1)() { } ' yes
Dim arr8 as Integer()()()() = New Integer( -1)()()() { } ' yes
Dim arr9 as Integer(,) = New Integer(-1,-1) { } ' no
Dim arr10 as Integer()(,) = New Integer(-1)(,) { } ' yes
Dim arr11 as Integer()(,) = New Integer(1)(,) { } ' no
Dim arr12 as Integer(,)() = New Integer(-1,-1)() { } ' no
Dim arr13 as Integer() = New Integer(0) { } ' no
Dim list1 as List(Of Integer) = New List(Of Integer) From { } ' no
End Sub
End Class";
const string FixedSource = @"
<System.Runtime.CompilerServices.Dynamic(new Boolean(-1) {})> _
Class C
Sub M1()
Dim arr1 As Integer() = System.Array.Empty(Of Integer) ' yes
Dim arr2 As Byte() = System.Array.Empty(Of Byte) ' yes
Dim arr3 As C() = System.Array.Empty(Of C) ' yes
Dim arr4 As String() = New String() { Nothing } ' no
Dim arr5 As Double() = New Double(1) { } ' no
Dim arr6 As Integer() = { -1 } ' no
Dim arr7 as Integer()() = System.Array.Empty(Of Integer()) ' yes
Dim arr8 as Integer()()()() = System.Array.Empty(Of Integer()()()) ' yes
Dim arr9 as Integer(,) = New Integer(-1,-1) { } ' no
Dim arr10 as Integer()(,) = System.Array.Empty(Of Integer(,)) ' yes
Dim arr11 as Integer()(,) = New Integer(1)(,) { } ' no
Dim arr12 as Integer(,)() = New Integer(-1,-1)() { } ' no
Dim arr13 as Integer() = New Integer(0) { } ' no
Dim list1 as List(Of Integer) = New List(Of Integer) From { } ' no
End Sub
End Class";
VerifyBasic(Source);
VerifyBasic(Source + ArrayEmptySource, new[]
{
GetBasicResultAt(5, 33, EmptyArrayDiagnosticAnalyzer.UseArrayEmptyDescriptor),
GetBasicResultAt(6, 30, EmptyArrayDiagnosticAnalyzer.UseArrayEmptyDescriptor),
GetBasicResultAt(7, 27, EmptyArrayDiagnosticAnalyzer.UseArrayEmptyDescriptor),
GetBasicResultAt(11, 35, EmptyArrayDiagnosticAnalyzer.UseArrayEmptyDescriptor),
GetBasicResultAt(12, 39, EmptyArrayDiagnosticAnalyzer.UseArrayEmptyDescriptor),
GetBasicResultAt(14, 37, EmptyArrayDiagnosticAnalyzer.UseArrayEmptyDescriptor)
});
VerifyBasicFix(
ArrayEmptySource + Source,
ArrayEmptySource + FixedSource,
allowNewCompilerDiagnostics: true);
VerifyBasicFix(
"Imports System\r\n" + ArrayEmptySource + Source,
"Imports System\r\n" + ArrayEmptySource + FixedSource.Replace("System.Array.Empty", "Array.Empty"),
allowNewCompilerDiagnostics: true);
}
