public void EncapsulatePublicField_WithLetter()
{
//Input
const string inputCode =
@"Public fizz As Integer";
var selection = new Selection(1, 1, 1, 1);
//Expectation
const string expectedCode =
@"Private fizz As Integer
Public Property Get Name() As Integer
Name = fizz
End Property
Public Property Let Name(ByVal value As Integer)
fizz = value
End Property
";
//Arrange
var builder = new MockVbeBuilder();
VBComponent component;
var vbe = builder.BuildFromSingleStandardModule(inputCode, out component);
var project = vbe.Object.VBProjects.Item(0);
var module = project.VBComponents.Item(0).CodeModule;
var codePaneFactory = new CodePaneWrapperFactory();
var mockHost = new Mock<IHostApplication>();
mockHost.SetupAllProperties();
var parser = MockParser.Create(vbe.Object, new RubberduckParserState());
parser.Parse();
if (parser.State.Status == ParserState.Error) { Assert.Inconclusive("Parser Error"); }
var qualifiedSelection = new QualifiedSelection(new QualifiedModuleName(component), selection);
var model = new EncapsulateFieldModel(parser.State, qualifiedSelection)
{
ImplementLetSetterType = true,
ImplementSetSetterType = false,
ParameterName = "value",
PropertyName = "Name"
};
//SetupFactory
var factory = SetupFactory(model);
//Act
var refactoring = new EncapsulateFieldRefactoring(factory.Object, new ActiveCodePaneEditor(vbe.Object, codePaneFactory));
refactoring.Refactor(qualifiedSelection);
//Assert
Assert.AreEqual(expectedCode, module.Lines());
}
public void ExtractMethod_PrivateFunction()
{
const string inputCode = @"
Private Sub Foo()
Dim x As Integer
x = 1 + 2
End Sub";
const string expectedCode = @"
Private Sub Foo()
x = Bar()
End Sub
Private Function Bar() As Integer
Dim x As Integer
x = 1 + 2
Bar = x
End Function
";
var codePaneFactory = new CodePaneWrapperFactory();
var builder = new MockVbeBuilder();
VBComponent component;
var vbe = builder.BuildFromSingleStandardModule(inputCode, out component);
var module = component.CodeModule;
var mockHost = new Mock<IHostApplication>();
mockHost.SetupAllProperties();
var editor = new ActiveCodePaneEditor(module.VBE, codePaneFactory);
var parser = MockParser.Create(vbe.Object, new RubberduckParserState());
parser.Parse();
if (parser.State.Status == ParserState.Error) { Assert.Inconclusive("Parser Error"); }
var qualifiedSelection = new QualifiedSelection(new QualifiedModuleName(module.Parent), new Selection(4, 1, 4, 20));
var model = new ExtractMethodModel(editor, parser.State.AllDeclarations, qualifiedSelection);
model.Method.Accessibility = Accessibility.Private;
model.Method.MethodName = "Bar";
model.Method.ReturnValue = new ExtractedParameter("Integer", ExtractedParameter.PassedBy.ByVal, "x");
model.Method.Parameters = new List<ExtractedParameter>();
var factory = SetupFactory(model);
//act
var refactoring = new ExtractMethodRefactoring(factory.Object, editor);
refactoring.Refactor(qualifiedSelection);
//assert
Assert.AreEqual(expectedCode, module.Lines());
}
public void RenameRefactoring_RenameSub()
{
//Input
const string inputCode =
@"Private Sub Foo()
End Sub";
var selection = new Selection(1, 15, 1, 15);
//Expectation
const string expectedCode =
@"Private Sub Goo()
End Sub";
//Arrange
var builder = new MockVbeBuilder();
VBComponent component;
var vbe = builder.BuildFromSingleStandardModule(inputCode, out component);
var project = vbe.Object.VBProjects.Item(0);
var module = project.VBComponents.Item(0).CodeModule;
var codePaneFactory = new CodePaneWrapperFactory();
var mockHost = new Mock<IHostApplication>();
mockHost.SetupAllProperties();
var parser = MockParser.Create(vbe.Object, new RubberduckParserState());
parser.Parse();
if (parser.State.Status == ParserState.Error) { Assert.Inconclusive("Parser Error"); }
var qualifiedSelection = new QualifiedSelection(new QualifiedModuleName(component), selection);
var model = new RenameModel(vbe.Object, parser.State, qualifiedSelection, null) { NewName = "Goo" };
//SetupFactory
var factory = SetupFactory(model);
//Act
var refactoring = new RenameRefactoring(factory.Object, new ActiveCodePaneEditor(vbe.Object, codePaneFactory), null, parser.State);
refactoring.Refactor(qualifiedSelection);
//Assert
var actual = module.Lines();
Assert.AreEqual(expectedCode, actual);
}
public void ReorderParams_SwapPositions()
{
//Input
const string inputCode =
@"Private Sub Foo(ByVal arg1 As Integer, ByVal arg2 As String)
End Sub";
var selection = new Selection(1, 23, 1, 27);
//Expectation
const string expectedCode =
@"Private Sub Foo(ByVal arg2 As String, ByVal arg1 As Integer)
End Sub";
//Arrange
var builder = new MockVbeBuilder();
VBComponent component;
var vbe = builder.BuildFromSingleStandardModule(inputCode, out component);
var project = vbe.Object.VBProjects.Item(0);
var module = project.VBComponents.Item(0).CodeModule;
var codePaneFactory = new CodePaneWrapperFactory();
var mockHost = new Mock<IHostApplication>();
mockHost.SetupAllProperties();
var parser = MockParser.Create(vbe.Object, new RubberduckParserState());
parser.Parse();
if (parser.State.Status == ParserState.Error) { Assert.Inconclusive("Parser Error"); }
var qualifiedSelection = new QualifiedSelection(new QualifiedModuleName(component), selection);
//set up model
var model = new ReorderParametersModel(parser.State, qualifiedSelection, null);
model.Parameters.Reverse();
var factory = SetupFactory(model);
//act
var refactoring = new ReorderParametersRefactoring(factory.Object, new ActiveCodePaneEditor(vbe.Object, codePaneFactory), null);
refactoring.Refactor(qualifiedSelection);
//assert
Assert.AreEqual(expectedCode, module.Lines());
}
public void MoveCloserToUsageRefactoring_Field()
{
//Input
const string inputCode =
@"Private bar As Boolean
Private Sub Foo()
bar = True
End Sub";
var selection = new Selection(1, 1, 1, 1);
//Expectation
const string expectedCode =
@"Private Sub Foo()
Dim bar As Boolean
bar = True
End Sub";
//Arrange
var builder = new MockVbeBuilder();
VBComponent component;
var vbe = builder.BuildFromSingleStandardModule(inputCode, out component);
var project = vbe.Object.VBProjects.Item(0);
var module = project.VBComponents.Item(0).CodeModule;
var codePaneFactory = new CodePaneWrapperFactory();
var mockHost = new Mock<IHostApplication>();
mockHost.SetupAllProperties();
var parser = MockParser.Create(vbe.Object, new RubberduckParserState());
parser.Parse();
if (parser.State.Status == ParserState.Error) { Assert.Inconclusive("Parser Error"); }
var qualifiedSelection = new QualifiedSelection(new QualifiedModuleName(component), selection);
//Act
var refactoring = new MoveCloserToUsageRefactoring(parser.State, new ActiveCodePaneEditor(vbe.Object, codePaneFactory), null);
refactoring.Refactor(qualifiedSelection);
//Assert
Assert.AreEqual(expectedCode, module.Lines());
}
public void RemoveParams_ModelIsNull()
{
//Input
const string inputCode =
@"Private fizz As Variant";
var selection = new Selection(1, 1, 1, 1);
//Arrange
var builder = new MockVbeBuilder();
VBComponent component;
var vbe = builder.BuildFromSingleStandardModule(inputCode, out component);
var module = component.CodeModule;
var codePaneFactory = new CodePaneWrapperFactory();
var mockHost = new Mock<IHostApplication>();
mockHost.SetupAllProperties();
var parser = MockParser.Create(vbe.Object, new RubberduckParserState());
parser.Parse();
if (parser.State.Status == ParserState.Error) { Assert.Inconclusive("Parser Error"); }
var qualifiedSelection = new QualifiedSelection(new QualifiedModuleName(component), selection);
//SetupFactory
var factory = SetupFactory(null);
//Act
var refactoring = new EncapsulateFieldRefactoring(factory.Object, new ActiveCodePaneEditor(vbe.Object, codePaneFactory));
refactoring.Refactor(qualifiedSelection);
//Assert
Assert.AreEqual(inputCode, module.Lines());
}
public void RemoveParams_PresenterIsNull()
{
//Input
const string inputCode =
@"Private fizz As Variant";
//Arrange
var builder = new MockVbeBuilder();
VBComponent component;
var vbe = builder.BuildFromSingleStandardModule(inputCode, out component);
var module = component.CodeModule;
var codePaneFactory = new CodePaneWrapperFactory();
var mockHost = new Mock<IHostApplication>();
mockHost.SetupAllProperties();
var parser = MockParser.Create(vbe.Object, new RubberduckParserState());
parser.Parse();
if (parser.State.Status == ParserState.Error) { Assert.Inconclusive("Parser Error"); }
var editor = new Mock<IActiveCodePaneEditor>();
editor.Setup(e => e.GetSelection()).Returns((QualifiedSelection?)null);
var factory = new EncapsulateFieldPresenterFactory(parser.State, editor.Object, null);
//act
var refactoring = new EncapsulateFieldRefactoring(factory, new ActiveCodePaneEditor(vbe.Object, codePaneFactory));
refactoring.Refactor();
Assert.AreEqual(inputCode, module.Lines());
}
public void GivenReferencedPublicField_UpdatesReferenceToNewProperty()
{
//Input
const string code_class1 =
@"Public fizz As Integer
Sub Foo()
fizz = 1
End Sub";
const string code_class2 =
@"Sub Foo()
Dim c As Class1
c.fizz = 0
Bar c.fizz
End Sub
Sub Bar(ByVal v As Integer)
End Sub";
var selection = new Selection(1, 1, 1, 1);
//Expectation
const string expectedCode1 =
@"Private fizz As Integer
Public Property Get Name() As Integer
Name = fizz
End Property
Public Property Let Name(ByVal value As Integer)
fizz = value
End Property
Sub Foo()
Name = 1
End Sub";
const string expectedCode2 =
@"Sub Foo()
Dim c As Class1
c.Name = 0
Bar c.Name
End Sub
Sub Bar(ByVal v As Integer)
End Sub";
//Arrange
var builder = new MockVbeBuilder();
var project = builder.ProjectBuilder("TestProject1", vbext_ProjectProtection.vbext_pp_none)
.AddComponent("Class1", vbext_ComponentType.vbext_ct_ClassModule, code_class1)
.AddComponent("Class2", vbext_ComponentType.vbext_ct_ClassModule, code_class2)
.Build();
var vbe = builder.AddProject(project).Build();
var component = project.Object.VBComponents.Item(0);
vbe.Setup(v => v.ActiveCodePane).Returns(component.CodeModule.CodePane);
var codePaneFactory = new CodePaneWrapperFactory();
var mockHost = new Mock<IHostApplication>();
mockHost.SetupAllProperties();
var parser = MockParser.Create(vbe.Object, new RubberduckParserState());
parser.Parse();
if (parser.State.Status == ParserState.Error) { Assert.Inconclusive("Parser Error"); }
var qualifiedSelection = new QualifiedSelection(new QualifiedModuleName(component), selection);
var module1 = project.Object.VBComponents.Item(0).CodeModule;
var module2 = project.Object.VBComponents.Item(1).CodeModule;
var model = new EncapsulateFieldModel(parser.State, qualifiedSelection)
{
ImplementLetSetterType = true,
ImplementSetSetterType = false,
ParameterName = "value",
PropertyName = "Name"
};
//SetupFactory
var factory = SetupFactory(model);
//Act
var refactoring = new EncapsulateFieldRefactoring(factory.Object, new ActiveCodePaneEditor(vbe.Object, codePaneFactory));
refactoring.Refactor(qualifiedSelection);
var actualCode1 = module1.Lines();
var actualCode2 = module2.Lines();
//Assert
Assert.AreEqual(expectedCode1, actualCode1);
Assert.AreEqual(expectedCode2, actualCode2);
}
public void RenameRefactoring_RenameCodeModule()
{
const string newName = "RenameModule";
//Input
const string inputCode =
@"Private Sub Foo(ByVal a As Integer, ByVal b As String)
End Sub";
var selection = new Selection(3, 27, 3, 27);
//Arrange
var builder = new MockVbeBuilder();
var project = builder.ProjectBuilder("TestProject1", vbext_ProjectProtection.vbext_pp_none)
.AddComponent("Class1", vbext_ComponentType.vbext_ct_ClassModule, inputCode)
.Build();
var vbe = builder.AddProject(project).Build();
var component = project.Object.VBComponents.Item(0);
var codePaneFactory = new CodePaneWrapperFactory();
var mockHost = new Mock<IHostApplication>();
mockHost.SetupAllProperties();
var parser = MockParser.Create(vbe.Object, new RubberduckParserState());
parser.Parse();
if (parser.State.Status == ParserState.Error) { Assert.Inconclusive("Parser Error"); }
var qualifiedSelection = new QualifiedSelection(new QualifiedModuleName(component), selection);
var model = new RenameModel(vbe.Object, parser.State, qualifiedSelection, null) { NewName = newName };
model.Target = model.Declarations.FirstOrDefault(i => i.DeclarationType == DeclarationType.Class && i.IdentifierName == "Class1");
//SetupFactory
var factory = SetupFactory(model);
//Act
var refactoring = new RenameRefactoring(factory.Object, new ActiveCodePaneEditor(vbe.Object, codePaneFactory), null, parser.State);
refactoring.Refactor(model.Target);
//Assert
Assert.AreSame(newName, component.CodeModule.Name);
}
public void IntroduceParameterRefactoring_PassInTarget()
{
//Input
const string inputCode =
@"Private Sub Foo()
Dim bar As Boolean
End Sub";
var selection = new Selection(2, 10, 2, 13);
//Expectation
const string expectedCode =
@"Private Sub Foo(ByVal bar As Boolean)
End Sub";
//Arrange
var builder = new MockVbeBuilder();
VBComponent component;
var vbe = builder.BuildFromSingleStandardModule(inputCode, out component);
var project = vbe.Object.VBProjects.Item(0);
var module = project.VBComponents.Item(0).CodeModule;
var codePaneFactory = new CodePaneWrapperFactory();
var mockHost = new Mock<IHostApplication>();
mockHost.SetupAllProperties();
var parser = MockParser.Create(vbe.Object, new RubberduckParserState());
parser.Parse();
if (parser.State.Status == ParserState.Error) { Assert.Inconclusive("Parser Error"); }
var qualifiedSelection = new QualifiedSelection(new QualifiedModuleName(component), selection);
//Act
var refactoring = new IntroduceParameterRefactoring(parser.State, new ActiveCodePaneEditor(vbe.Object, codePaneFactory), null);
refactoring.Refactor(parser.State.AllUserDeclarations.FindVariable(qualifiedSelection));
//Assert
Assert.AreEqual(expectedCode, module.Lines());
}
public void RenameRefactoring_RenameSub_ConflictingNames_Accept()
{
//Input
const string inputCode =
@"Private Sub Foo()
Dim Goo As Integer
End Sub";
var selection = new Selection(1, 14, 1, 14);
//Expectation
const string expectedCode =
@"Private Sub Goo()
Dim Goo As Integer
End Sub";
//Arrange
var builder = new MockVbeBuilder();
VBComponent component;
var vbe = builder.BuildFromSingleStandardModule(inputCode, out component);
var project = vbe.Object.VBProjects.Item(0);
var module = project.VBComponents.Item(0).CodeModule;
var codePaneFactory = new CodePaneWrapperFactory();
var mockHost = new Mock<IHostApplication>();
mockHost.SetupAllProperties();
var parser = MockParser.Create(vbe.Object, new RubberduckParserState());
parser.Parse();
if (parser.State.Status == ParserState.Error) { Assert.Inconclusive("Parser Error"); }
var qualifiedSelection = new QualifiedSelection(new QualifiedModuleName(component), selection);
var model = new RenameModel(vbe.Object, parser.State, qualifiedSelection, null) { NewName = "Goo" };
//SetupFactory
var factory = SetupFactory(model);
var messageBox = new Mock<IMessageBox>();
messageBox.Setup(
m =>
m.Show(It.IsAny<string>(), It.IsAny<string>(), It.IsAny<MessageBoxButtons>(),
It.IsAny<MessageBoxIcon>())).Returns(DialogResult.Yes);
//Act
var refactoring = new RenameRefactoring(factory.Object, new ActiveCodePaneEditor(vbe.Object, codePaneFactory), messageBox.Object, parser.State);
refactoring.Refactor(qualifiedSelection);
//Assert
Assert.AreEqual(expectedCode, module.Lines());
}
public void IntroduceFieldRefactoring_InvalidSelection()
{
//Input
const string inputCode =
@"Private bar As Boolean
Private Sub Foo()
bar = True
End Sub";
var selection = new Selection(2, 15, 2, 15);
//Arrange
var builder = new MockVbeBuilder();
VBComponent component;
var vbe = builder.BuildFromSingleStandardModule(inputCode, out component);
var project = vbe.Object.VBProjects.Item(0);
var module = project.VBComponents.Item(0).CodeModule;
var codePaneFactory = new CodePaneWrapperFactory();
var mockHost = new Mock<IHostApplication>();
mockHost.SetupAllProperties();
var parser = MockParser.Create(vbe.Object, new RubberduckParserState());
parser.Parse();
if (parser.State.Status == ParserState.Error) { Assert.Inconclusive("Parser Error"); }
var messageBox = new Mock<IMessageBox>();
messageBox.Setup(m => m.Show(It.IsAny<string>(), It.IsAny<string>(), It.IsAny<MessageBoxButtons>(), It.IsAny<MessageBoxIcon>()))
.Returns(DialogResult.OK);
var qualifiedSelection = new QualifiedSelection(new QualifiedModuleName(component), selection);
//Act
var refactoring = new MoveCloserToUsageRefactoring(parser.State, new ActiveCodePaneEditor(vbe.Object, codePaneFactory), messageBox.Object);
refactoring.Refactor(qualifiedSelection);
messageBox.Verify(m =>
m.Show(It.IsAny<string>(), It.IsAny<string>(), It.IsAny<MessageBoxButtons>(),
It.IsAny<MessageBoxIcon>()), Times.Once);
Assert.AreEqual(inputCode, module.Lines());
}
public void MoveCloserToUsageRefactoring_ReferenceIsSeparatedWithColon()
{
//Input
const string inputCode =
@"Private bar As Boolean
Private Sub Foo(): Baz True, True, bar: End Sub
Private Sub Baz(ByVal bat As Boolean, ByVal bas As Boolean, ByVal bac As Boolean): End Sub";
var selection = new Selection(1, 1, 1, 1);
// Yeah, this code is a mess. That is why we got the SmartIndenter
const string expectedCode =
@"Private Sub Foo()
Dim bar As Boolean
Baz True, True, bar
End Sub
Private Sub Baz(ByVal bat As Boolean, ByVal bas As Boolean, ByVal bac As Boolean): End Sub";
//Arrange
var builder = new MockVbeBuilder();
VBComponent component;
var vbe = builder.BuildFromSingleStandardModule(inputCode, out component);
var project = vbe.Object.VBProjects.Item(0);
var module = project.VBComponents.Item(0).CodeModule;
var codePaneFactory = new CodePaneWrapperFactory();
var mockHost = new Mock<IHostApplication>();
mockHost.SetupAllProperties();
var parser = MockParser.Create(vbe.Object, new RubberduckParserState());
parser.Parse();
if (parser.State.Status == ParserState.Error) { Assert.Inconclusive("Parser Error"); }
var qualifiedSelection = new QualifiedSelection(new QualifiedModuleName(component), selection);
//Act
var refactoring = new MoveCloserToUsageRefactoring(parser.State, new ActiveCodePaneEditor(vbe.Object, codePaneFactory), null);
refactoring.Refactor(qualifiedSelection);
//Assert
Assert.AreEqual(expectedCode, module.Lines());
}
public void Presenter_NullTargetReturnsNullModel()
{
//Input
const string inputCode =
@"
Private Sub Foo(ByVal arg1 As Integer, ByVal arg2 As String)
End Sub";
var selection = Selection.Home;
//Arrange
var builder = new MockVbeBuilder();
var projectBuilder = builder.ProjectBuilder("TestProject1", vbext_ProjectProtection.vbext_pp_none);
projectBuilder.AddComponent("Module1", vbext_ComponentType.vbext_ct_StdModule, inputCode);
var project = projectBuilder.Build();
builder.AddProject(project);
var vbe = builder.Build();
var codePaneFactory = new CodePaneWrapperFactory();
var mockHost = new Mock<IHostApplication>();
mockHost.SetupAllProperties();
var parser = MockParser.Create(vbe.Object, new RubberduckParserState());
parser.Parse();
if (parser.State.Status == ParserState.Error) { Assert.Inconclusive("Parser Error"); }
var codePane = project.Object.VBComponents.Item(0).CodeModule.CodePane;
var ext = codePaneFactory.Create(codePane);
ext.Selection = selection;
var qualifiedSelection = new QualifiedSelection(new QualifiedModuleName(codePane.CodeModule.Parent), selection);
var editor = new Mock<IActiveCodePaneEditor>();
editor.Setup(e => e.GetSelection()).Returns(qualifiedSelection);
var factory = new EncapsulateFieldPresenterFactory(parser.State, editor.Object, null);
var presenter = factory.Create();
Assert.AreEqual(null, presenter.Show());
}
public void ReorderParametersRefactoring_EventParamsSwapped_DifferentParamNames_TwoHandlers()
{
//Input
const string inputCode1 =
@"Public Event Foo(ByVal arg1 As Integer, ByVal arg2 As String)";
const string inputCode2 =
@"Private WithEvents abc As Class1
Private Sub abc_Foo(ByVal i As Integer, ByVal s As String)
End Sub";
const string inputCode3 =
@"Private WithEvents abc As Class1
Private Sub abc_Foo(ByVal v1 As Integer, ByVal v2 As String)
End Sub";
var selection = new Selection(1, 15, 1, 15);
//Expectation
const string expectedCode1 =
@"Public Event Foo(ByVal arg2 As String, ByVal arg1 As Integer)";
const string expectedCode2 =
@"Private WithEvents abc As Class1
Private Sub abc_Foo(ByVal s As String, ByVal i As Integer)
End Sub"; // note: IDE removes excess spaces
const string expectedCode3 =
@"Private WithEvents abc As Class1
Private Sub abc_Foo(ByVal v2 As String, ByVal v1 As Integer)
End Sub"; // note: IDE removes excess spaces
//Arrange
var builder = new MockVbeBuilder();
var project = builder.ProjectBuilder("TestProject1", vbext_ProjectProtection.vbext_pp_none)
.AddComponent("Class1", vbext_ComponentType.vbext_ct_ClassModule, inputCode1)
.AddComponent("Class2", vbext_ComponentType.vbext_ct_ClassModule, inputCode2)
.AddComponent("Class3", vbext_ComponentType.vbext_ct_ClassModule, inputCode3)
.Build();
var vbe = builder.AddProject(project).Build();
var component = project.Object.VBComponents.Item(0);
var codePaneFactory = new CodePaneWrapperFactory();
var mockHost = new Mock<IHostApplication>();
mockHost.SetupAllProperties();
var parser = MockParser.Create(vbe.Object, new RubberduckParserState());
parser.Parse();
if (parser.State.Status == ParserState.Error) { Assert.Inconclusive("Parser Error"); }
var qualifiedSelection = new QualifiedSelection(new QualifiedModuleName(component), selection);
var module1 = project.Object.VBComponents.Item(0).CodeModule;
var module2 = project.Object.VBComponents.Item(1).CodeModule;
var module3 = project.Object.VBComponents.Item(2).CodeModule;
//Specify Params to remove
var model = new ReorderParametersModel(parser.State, qualifiedSelection, null);
model.Parameters.Reverse();
//SetupFactory
var factory = SetupFactory(model);
//Act
var refactoring = new ReorderParametersRefactoring(factory.Object, new ActiveCodePaneEditor(vbe.Object, codePaneFactory), null);
refactoring.Refactor(qualifiedSelection);
//Assert
Assert.AreEqual(expectedCode1, module1.Lines());
Assert.AreEqual(expectedCode2, module2.Lines());
Assert.AreEqual(expectedCode3, module3.Lines());
}
public void ReorderParametersRefactoring_InterfaceParamsSwapped_AcceptPrompt()
{
//Input
const string inputCode1 =
@"Implements IClass1
Private Sub IClass1_DoSomething(ByVal a As Integer, ByVal b As String)
End Sub";
const string inputCode2 =
@"Public Sub DoSomething(ByVal a As Integer, ByVal b As String)
End Sub";
var selection = new Selection(3, 23, 3, 27);
//Expectation
const string expectedCode1 =
@"Implements IClass1
Private Sub IClass1_DoSomething(ByVal b As String, ByVal a As Integer)
End Sub"; // note: IDE removes excess spaces
const string expectedCode2 =
@"Public Sub DoSomething(ByVal b As String, ByVal a As Integer)
End Sub";
//Arrange
var builder = new MockVbeBuilder();
var project = builder.ProjectBuilder("TestProject1", vbext_ProjectProtection.vbext_pp_none)
.AddComponent("Class1", vbext_ComponentType.vbext_ct_ClassModule, inputCode1)
.AddComponent("IClass1", vbext_ComponentType.vbext_ct_ClassModule, inputCode2)
.Build();
var vbe = builder.AddProject(project).Build();
var component = project.Object.VBComponents.Item(0);
var codePaneFactory = new CodePaneWrapperFactory();
var mockHost = new Mock<IHostApplication>();
mockHost.SetupAllProperties();
var parser = MockParser.Create(vbe.Object, new RubberduckParserState());
parser.Parse();
if (parser.State.Status == ParserState.Error) { Assert.Inconclusive("Parser Error"); }
var qualifiedSelection = new QualifiedSelection(new QualifiedModuleName(component), selection);
var module1 = project.Object.VBComponents.Item(0).CodeModule;
var module2 = project.Object.VBComponents.Item(1).CodeModule;
var messageBox = new Mock<IMessageBox>();
messageBox.Setup(
m => m.Show(It.IsAny<string>(), It.IsAny<string>(), It.IsAny<MessageBoxButtons>(), It.IsAny<MessageBoxIcon>()))
.Returns(DialogResult.Yes);
//Specify Params to remove
var model = new ReorderParametersModel(parser.State, qualifiedSelection, messageBox.Object);
model.Parameters.Reverse();
//SetupFactory
var factory = SetupFactory(model);
//Act
var refactoring = new ReorderParametersRefactoring(factory.Object, new ActiveCodePaneEditor(vbe.Object, codePaneFactory), null);
refactoring.Refactor(qualifiedSelection);
//Assert
Assert.AreEqual(expectedCode1, module1.Lines());
Assert.AreEqual(expectedCode2, module2.Lines());
}
public void ReorderParams_RefactorDeclaration_FailsInvalidTarget()
{
//Input
const string inputCode =
@"Private Sub Foo(ByVal arg1 As Integer, ByVal arg2 As String)
End Sub";
var selection = new Selection(1, 23, 1, 27);
//Arrange
var builder = new MockVbeBuilder();
VBComponent component;
var vbe = builder.BuildFromSingleStandardModule(inputCode, out component);
var codePaneFactory = new CodePaneWrapperFactory();
var mockHost = new Mock<IHostApplication>();
mockHost.SetupAllProperties();
var parser = MockParser.Create(vbe.Object, new RubberduckParserState());
parser.Parse();
if (parser.State.Status == ParserState.Error) { Assert.Inconclusive("Parser Error"); }
var qualifiedSelection = new QualifiedSelection(new QualifiedModuleName(component), selection);
//set up model
var model = new ReorderParametersModel(parser.State, qualifiedSelection, null);
model.Parameters.Reverse();
var factory = SetupFactory(model);
//act
var refactoring = new ReorderParametersRefactoring(factory.Object, new ActiveCodePaneEditor(vbe.Object, codePaneFactory), null);
//assert
try
{
refactoring.Refactor(
model.Declarations.FirstOrDefault(
i => i.DeclarationType == Rubberduck.Parsing.Symbols.DeclarationType.Module));
}
catch (ArgumentException e)
{
Assert.AreEqual("Invalid declaration type", e.Message);
return;
}
Assert.Fail();
}
public void Factory_SelectionIsNull()
{
//Input
const string inputCode =
@"Private Sub Foo()
End Sub";
//Arrange
var builder = new MockVbeBuilder();
VBComponent component;
var vbe = builder.BuildFromSingleStandardModule(inputCode, out component);
var project = vbe.Object.VBProjects.Item(0);
var module = project.VBComponents.Item(0).CodeModule;
var codePaneFactory = new CodePaneWrapperFactory();
var mockHost = new Mock<IHostApplication>();
mockHost.SetupAllProperties();
var parser = MockParser.Create(vbe.Object, new RubberduckParserState());
parser.Parse();
if (parser.State.Status == ParserState.Error) { Assert.Inconclusive("Parser Error"); }
var editor = new Mock<IActiveCodePaneEditor>();
editor.Setup(e => e.GetSelection()).Returns((QualifiedSelection?)null);
int startLine, startColumn, endLine, endColumn;
var codePaneMock = new Mock<CodePane>();
codePaneMock.Setup(c => c.CodeModule).Returns(module);
codePaneMock.Setup(c => c.GetSelection(out startLine, out startColumn, out endLine, out endColumn));
vbe.Setup(v => v.ActiveCodePane).Returns(codePaneMock.Object);
var factory = new RenamePresenterFactory(vbe.Object, null, parser.State, null, codePaneFactory);
var presenter = factory.Create();
Assert.AreEqual(null, presenter.Show());
}
public void RenameRefactoring_RenameEvent()
{
//Input
const string inputCode1 =
@"Public Event Foo(ByVal arg1 As Integer, ByVal arg2 As String)";
const string inputCode2 =
@"Private WithEvents abc As Class1
Private Sub abc_Foo(ByVal i As Integer, ByVal s As String)
End Sub";
var selection = new Selection(1, 16, 1, 16);
//Expectation
const string expectedCode1 =
@"Public Event Goo(ByVal arg1 As Integer, ByVal arg2 As String)";
const string expectedCode2 =
@"Private WithEvents abc As Class1
Private Sub abc_Goo(ByVal i As Integer, ByVal s As String)
End Sub";
//Arrange
var builder = new MockVbeBuilder();
var project = builder.ProjectBuilder("TestProject1", vbext_ProjectProtection.vbext_pp_none)
.AddComponent("Class1", vbext_ComponentType.vbext_ct_ClassModule, inputCode1)
.AddComponent("Class2", vbext_ComponentType.vbext_ct_ClassModule, inputCode2)
.Build();
var vbe = builder.AddProject(project).Build();
var component = project.Object.VBComponents.Item(0);
var codePaneFactory = new CodePaneWrapperFactory();
var mockHost = new Mock<IHostApplication>();
mockHost.SetupAllProperties();
var parser = MockParser.Create(vbe.Object, new RubberduckParserState());
parser.Parse();
if (parser.State.Status == ParserState.Error) { Assert.Inconclusive("Parser Error"); }
var qualifiedSelection = new QualifiedSelection(new QualifiedModuleName(component), selection);
var module1 = project.Object.VBComponents.Item(0).CodeModule;
var module2 = project.Object.VBComponents.Item(1).CodeModule;
var model = new RenameModel(vbe.Object, parser.State, qualifiedSelection, null) { NewName = "Goo" };
//SetupFactory
var factory = SetupFactory(model);
//Act
var refactoring = new RenameRefactoring(factory.Object, new ActiveCodePaneEditor(vbe.Object, codePaneFactory), null, parser.State);
refactoring.Refactor(qualifiedSelection);
//Assert
Assert.AreEqual(expectedCode1, module1.Lines());
Assert.AreEqual(expectedCode2, module2.Lines());
}
public void IntroduceFieldRefactoring_MultipleVariablesInStatement_OnOneLine_MoveFirst()
{
//Input
const string inputCode =
@"Private Sub Foo(ByVal buz As Integer, _
ByRef baz As Date)
Dim bar As Boolean, bat As Date, bap As Integer
End Sub";
var selection = new Selection(3, 10, 3, 13);
//Expectation
const string expectedCode =
@"Private bar As Boolean
Private Sub Foo(ByVal buz As Integer, _
ByRef baz As Date)
Dim bat As Date, bap As Integer
End Sub";
//Arrange
var builder = new MockVbeBuilder();
VBComponent component;
var vbe = builder.BuildFromSingleStandardModule(inputCode, out component);
var project = vbe.Object.VBProjects.Item(0);
var module = project.VBComponents.Item(0).CodeModule;
var codePaneFactory = new CodePaneWrapperFactory();
var mockHost = new Mock<IHostApplication>();
mockHost.SetupAllProperties();
var parser = MockParser.Create(vbe.Object, new RubberduckParserState());
parser.Parse();
if (parser.State.Status == ParserState.Error) { Assert.Inconclusive("Parser Error"); }
var qualifiedSelection = new QualifiedSelection(new QualifiedModuleName(component), selection);
//Act
var refactoring = new IntroduceFieldRefactoring(parser.State, new ActiveCodePaneEditor(vbe.Object, codePaneFactory), null);
refactoring.Refactor(qualifiedSelection);
//Assert
Assert.AreEqual(expectedCode, module.Lines());
}
public void ReorderParametersRefactoring_ReorderNamedParams_WithOptionalParam()
{
//Input
const string inputCode =
@"Public Sub Foo(ByVal arg1 As Integer, ByVal arg2 As String, Optional ByVal arg3 As Double)
End Sub
Public Sub Goo()
Foo arg2:=""test44"", arg1:=3
End Sub
";
var selection = new Selection(1, 23, 1, 27);
//Expectation
const string expectedCode =
@"Public Sub Foo(ByVal arg2 As String, ByVal arg1 As Integer, Optional ByVal arg3 As Double)
End Sub
Public Sub Goo()
Foo arg1:=3, arg2:=""test44""
End Sub
";
//Arrange
var builder = new MockVbeBuilder();
VBComponent component;
var vbe = builder.BuildFromSingleStandardModule(inputCode, out component);
var project = vbe.Object.VBProjects.Item(0);
var module = project.VBComponents.Item(0).CodeModule;
var codePaneFactory = new CodePaneWrapperFactory();
var mockHost = new Mock<IHostApplication>();
mockHost.SetupAllProperties();
var parser = MockParser.Create(vbe.Object, new RubberduckParserState());
parser.Parse();
if (parser.State.Status == ParserState.Error) { Assert.Inconclusive("Parser Error"); }
var qualifiedSelection = new QualifiedSelection(new QualifiedModuleName(component), selection);
//Specify Params to reorder
var model = new ReorderParametersModel(parser.State, qualifiedSelection, null);
var reorderedParams = new List<Parameter>()
{
model.Parameters[1],
model.Parameters[0],
model.Parameters[2]
};
model.Parameters = reorderedParams;
//SetupFactory
var factory = SetupFactory(model);
//Act
var refactoring = new ReorderParametersRefactoring(factory.Object, new ActiveCodePaneEditor(vbe.Object, codePaneFactory), null);
refactoring.Refactor(qualifiedSelection);
//Assert
Assert.AreEqual(expectedCode, module.Lines());
}
public void MoveCloserToUsageRefactoring_MultipleVariablesOneStatement_MoveLast()
{
//Input
const string inputCode =
@"Private Sub Foo()
Dim bar As Integer, _
bat As Boolean, _
bay As Date
bar = 4
bay = #1/13/2004#
End Sub";
var selection = new Selection(4, 16, 4, 16);
//Expectation
const string expectedCode =
@"Private Sub Foo()
Dim bar As Integer, bat As Boolean
bar = 4
Dim bay As Date
bay = #1/13/2004#
End Sub"; // note: VBE will remove extra spaces
//Arrange
var builder = new MockVbeBuilder();
VBComponent component;
var vbe = builder.BuildFromSingleStandardModule(inputCode, out component);
var project = vbe.Object.VBProjects.Item(0);
var module = project.VBComponents.Item(0).CodeModule;
var codePaneFactory = new CodePaneWrapperFactory();
var mockHost = new Mock<IHostApplication>();
mockHost.SetupAllProperties();
var parser = MockParser.Create(vbe.Object, new RubberduckParserState());
parser.Parse();
if (parser.State.Status == ParserState.Error) { Assert.Inconclusive("Parser Error"); }
var qualifiedSelection = new QualifiedSelection(new QualifiedModuleName(component), selection);
//Act
var refactoring = new MoveCloserToUsageRefactoring(parser.State, new ActiveCodePaneEditor(vbe.Object, codePaneFactory), null);
refactoring.Refactor(qualifiedSelection);
//Assert
Assert.AreEqual(expectedCode, module.Lines());
}
public void ReorderParametersRefactoring_ClientReferencesAreUpdated_ParamArray_CallOnMultiplelines()
{
//Input
const string inputCode =
@"Sub Foo(ByVal arg1 As String, ByVal arg2 As Date, ParamArray arg3())
End Sub
Public Sub Goo(ByVal arg As Date, _
ByVal arg1 As Integer, _
ByVal arg2 As Integer, _
ByVal arg3 As Integer, _
ByVal arg4 As Integer, _
ByVal arg5 As Integer, _
ByVal arg6 As Integer)
Foo ""test"", _
arg, _
test1x, _
test2x, _
test3x, _
test4x, _
test5x, _
test6x
End Sub
";
var selection = new Selection(1, 23, 1, 27);
//Expectation
const string expectedCode =
@"Sub Foo(ByVal arg2 As Date, ByVal arg1 As String, ParamArray arg3())
End Sub
Public Sub Goo(ByVal arg As Date, _
ByVal arg1 As Integer, _
ByVal arg2 As Integer, _
ByVal arg3 As Integer, _
ByVal arg4 As Integer, _
ByVal arg5 As Integer, _
ByVal arg6 As Integer)
Foo arg, ""test"", test1x, test2x, test3x, test4x, test5x, test6x
End Sub
";
//Arrange
var builder = new MockVbeBuilder();
VBComponent component;
var vbe = builder.BuildFromSingleStandardModule(inputCode, out component);
var project = vbe.Object.VBProjects.Item(0);
var module = project.VBComponents.Item(0).CodeModule;
var codePaneFactory = new CodePaneWrapperFactory();
var mockHost = new Mock<IHostApplication>();
mockHost.SetupAllProperties();
var parser = MockParser.Create(vbe.Object, new RubberduckParserState());
parser.Parse();
if (parser.State.Status == ParserState.Error) { Assert.Inconclusive("Parser Error"); }
var qualifiedSelection = new QualifiedSelection(new QualifiedModuleName(component), selection);
//Specify Params to reorder
var model = new ReorderParametersModel(parser.State, qualifiedSelection, null);
var reorderedParams = new List<Parameter>()
{
model.Parameters[1],
model.Parameters[0],
model.Parameters[2]
};
model.Parameters = reorderedParams;
//SetupFactory
var factory = SetupFactory(model);
var messageBox = new Mock<IMessageBox>();
messageBox.Setup(m => m.Show(It.IsAny<string>(), It.IsAny<string>(), MessageBoxButtons.OK, MessageBoxIcon.Warning)).Returns(DialogResult.OK);
//Act
var refactoring = new ReorderParametersRefactoring(factory.Object, new ActiveCodePaneEditor(vbe.Object, codePaneFactory), messageBox.Object);
refactoring.Refactor(qualifiedSelection);
//Assert
Assert.AreEqual(expectedCode, module.Lines());
}
public void IntroduceFieldRefactoring_PassInTarget_Nonvariable()
{
//Input
const string inputCode =
@"Private bar As Boolean
Private Sub Foo()
bar = True
End Sub";
//Arrange
var builder = new MockVbeBuilder();
VBComponent component;
var vbe = builder.BuildFromSingleStandardModule(inputCode, out component);
var project = vbe.Object.VBProjects.Item(0);
var module = project.VBComponents.Item(0).CodeModule;
var codePaneFactory = new CodePaneWrapperFactory();
var mockHost = new Mock<IHostApplication>();
mockHost.SetupAllProperties();
var parser = MockParser.Create(vbe.Object, new RubberduckParserState());
parser.Parse();
if (parser.State.Status == ParserState.Error) { Assert.Inconclusive("Parser Error"); }
var messageBox = new Mock<IMessageBox>();
messageBox.Setup(m => m.Show(It.IsAny<string>(), It.IsAny<string>(), It.IsAny<MessageBoxButtons>(), It.IsAny<MessageBoxIcon>()))
.Returns(DialogResult.OK);
//Act
var refactoring = new MoveCloserToUsageRefactoring(parser.State, new ActiveCodePaneEditor(vbe.Object, codePaneFactory), messageBox.Object);
//Assert
try
{
refactoring.Refactor(parser.State.AllUserDeclarations.First(d => d.DeclarationType != DeclarationType.Variable));
}
catch (ArgumentException e)
{
Assert.AreEqual("Invalid Argument. DeclarationType must be 'Variable'\r\nParameter name: target", e.Message);
Assert.AreEqual(inputCode, module.Lines());
messageBox.Verify(m =>
m.Show(It.IsAny<string>(), It.IsAny<string>(), It.IsAny<MessageBoxButtons>(),
It.IsAny<MessageBoxIcon>()), Times.Once);
return;
}
Assert.Fail();
}
public void ReorderParams_MoveOptionalParamBeforeNonOptionalParamFails()
{
//Input
const string inputCode =
@"Private Sub Foo(ByVal arg1 As Integer, Optional ByVal arg2 As String, Optional ByVal arg3 As Boolean = True)
End Sub";
var selection = new Selection(1, 23, 1, 27);
//Arrange
var builder = new MockVbeBuilder();
VBComponent component;
var vbe = builder.BuildFromSingleStandardModule(inputCode, out component);
var project = vbe.Object.VBProjects.Item(0);
var module = project.VBComponents.Item(0).CodeModule;
var codePaneFactory = new CodePaneWrapperFactory();
var mockHost = new Mock<IHostApplication>();
mockHost.SetupAllProperties();
var parser = MockParser.Create(vbe.Object, new RubberduckParserState());
parser.Parse();
if (parser.State.Status == ParserState.Error) { Assert.Inconclusive("Parser Error"); }
var qualifiedSelection = new QualifiedSelection(new QualifiedModuleName(component), selection);
//set up model
var model = new ReorderParametersModel(parser.State, qualifiedSelection, null);
var reorderedParams = new List<Parameter>()
{
model.Parameters[1],
model.Parameters[2],
model.Parameters[0]
};
model.Parameters = reorderedParams;
var factory = SetupFactory(model);
var messageBox = new Mock<IMessageBox>();
messageBox.Setup(m => m.Show(It.IsAny<string>(), It.IsAny<string>(), MessageBoxButtons.OK, MessageBoxIcon.Warning)).Returns(DialogResult.OK);
//act
var refactoring = new ReorderParametersRefactoring(factory.Object, new ActiveCodePaneEditor(vbe.Object, codePaneFactory), messageBox.Object);
refactoring.Refactor(qualifiedSelection);
//assert
Assert.AreEqual(inputCode, module.Lines());
}
public void IntroduceParameterRefactoring_ImplementsInterface_Reject()
{
//Input
const string inputCode1 =
@"Sub fizz(ByVal boo As Boolean)
End Sub";
const string inputCode2 =
@"Implements IClass1
Sub IClass1_fizz(ByVal boo As Boolean)
Dim fizz As Date
End Sub";
var selection = new Selection(4, 10, 4, 14);
//Arrange
var builder = new MockVbeBuilder();
var project = builder.ProjectBuilder("TestProject1", vbext_ProjectProtection.vbext_pp_none)
.AddComponent("IClass1", vbext_ComponentType.vbext_ct_ClassModule, inputCode1)
.AddComponent("Class1", vbext_ComponentType.vbext_ct_ClassModule, inputCode2)
.Build();
var vbe = builder.AddProject(project).Build();
var component = project.Object.VBComponents.Item(1);
vbe.Setup(v => v.ActiveCodePane).Returns(component.CodeModule.CodePane);
var codePaneFactory = new CodePaneWrapperFactory();
var mockHost = new Mock<IHostApplication>();
mockHost.SetupAllProperties();
var parser = MockParser.Create(vbe.Object, new RubberduckParserState());
parser.Parse();
if (parser.State.Status == ParserState.Error) { Assert.Inconclusive("Parser Error"); }
var qualifiedSelection = new QualifiedSelection(new QualifiedModuleName(component), selection);
var module1 = project.Object.VBComponents.Item(0).CodeModule;
var module2 = project.Object.VBComponents.Item(1).CodeModule;
var messageBox = new Mock<IMessageBox>();
messageBox.Setup(m => m.Show(It.IsAny<string>(), It.IsAny<string>(), It.IsAny<MessageBoxButtons>(), It.IsAny<MessageBoxIcon>()))
.Returns(DialogResult.No);
//Act
var refactoring = new IntroduceParameterRefactoring(parser.State, new ActiveCodePaneEditor(vbe.Object, codePaneFactory), messageBox.Object);
refactoring.Refactor(qualifiedSelection);
//Assert
Assert.AreEqual(inputCode1, module1.Lines());
Assert.AreEqual(inputCode2, module2.Lines());
}
public void RenameRefactoring_RenameProject()
{
const string oldName = "TestProject1";
const string newName = "Renamed";
//Arrange
var builder = new MockVbeBuilder();
var vbe = builder.ProjectBuilder(oldName, vbext_ProjectProtection.vbext_pp_none)
.AddComponent("Module1", vbext_ComponentType.vbext_ct_StdModule, string.Empty)
.MockVbeBuilder()
.Build();
var codePaneFactory = new CodePaneWrapperFactory();
var mockHost = new Mock<IHostApplication>();
mockHost.SetupAllProperties();
var parser = MockParser.Create(vbe.Object, new RubberduckParserState());
parser.Parse();
if (parser.State.Status == ParserState.Error) { Assert.Inconclusive("Parser Error"); }
var model = new RenameModel(vbe.Object, parser.State, default(QualifiedSelection), null) { NewName = newName };
model.Target = model.Declarations.First(i => i.DeclarationType == DeclarationType.Project && !i.IsBuiltIn);
//SetupFactory
var factory = SetupFactory(model);
//Act
var refactoring = new RenameRefactoring(factory.Object, new ActiveCodePaneEditor(vbe.Object, codePaneFactory), null, parser.State);
refactoring.Refactor(model.Target);
//Assert
Assert.AreEqual(newName, vbe.Object.VBProjects.Item(0).Name);
}
