public async Task UseOf_nameof_DoesNotProduceWarnings()
{
var test = @"
using System;
using System.Threading.Tasks;
public class Test {
void PrivateFoo() {
const string f = nameof(Task<int>.Result);
const string g = nameof(Task.Wait);
Task<int> t = null;
const string h = nameof(t.Result);
const string i = nameof(t.Wait);
}
public void PublicFoo() {
const string f = nameof(Task<int>.Result);
const string g = nameof(Task.Wait);
Task<int> t = null;
const string h = nameof(t.Result);
const string i = nameof(t.Wait);
}
}
";
await Verify.VerifyAnalyzerAsync(test);
}
public async Task NameOfUsedInAttributeArgument()
{
var test = @"
[System.Diagnostics.DebuggerDisplay(""hi"", Name = nameof(System.Console))]
class Foo { }
";
await Verify.VerifyAnalyzerAsync(test);
}
public async Task ManyMethodInvocationStyles()
{
var test = @"
using System;
using System.Threading.Tasks;
public class A {
private Action a;
public void B() {
a();
(a).Invoke();
D<int>();
E().ToString();
E()();
string v = nameof(E);
}
internal void C() {
a();
(a).Invoke();
D<int>();
E().ToString();
E()();
string v = nameof(E);
}
public Task BAsync() {
a();
(a).Invoke();
D<int>();
E().ToString();
E()();
string v = nameof(E);
return null;
}
internal Task CAsync() {
a();
(a).Invoke();
D<int>();
E().ToString();
E()();
string v = nameof(E);
return null;
}
private void D<T>() { }
private Action E() => null;
}
";
await Verify.VerifyAnalyzerAsync(test);
}
public async Task JustOneDiagnosticPerLine()
{
var test = @"
using System.Threading.Tasks;
using Microsoft.VisualStudio.Threading;
class Test {
JoinableTaskFactory jtf;
Task<int> FooAsync() {
Task t = Task.FromResult(1);
t.GetAwaiter().GetResult(); // VSTHRD002, VSTHRD103, VSTHRD102
jtf.Run(async delegate { await BarAsync().ConfigureAwait(true); }); // VSTHRD103, VSTHRD102
return Task.FromResult(1);
}
Task BarAsync() => null;
static void SetTaskSourceIfCompleted<T>(Task<T> task, TaskCompletionSource<T> tcs) {
if (task.IsCompleted) {
tcs.SetResult(task.Result);
}
}
}";
DiagnosticResult[] expected =
{
Verify.Diagnostic(VSTHRD103UseAsyncOptionAnalyzer.DescriptorNoAlternativeMethod).WithSpan(10, 24, 10, 33).WithArguments("GetResult"),
Verify.Diagnostic(VSTHRD103UseAsyncOptionAnalyzer.Descriptor).WithSpan(11, 13, 11, 16).WithArguments("Run","RunAsync"),
Verify.Diagnostic(VSTHRD002UseJtfRunAnalyzer.Descriptor).WithSpan(19, 32, 19, 38),
};
// All expected diagnostics should include a location
Assert.All(expected, item => Assert.True(item.HasLocation));
// All diagnostics should fit on one line
Assert.All(expected, item => Assert.Equal(item.Spans[0].EndLinePosition.Line, item.Spans[0].StartLinePosition.Line));
// At most one diagnostic appears on any given line
Assert.Equal(expected.Length, expected.Select(d => d.Spans[0].StartLinePosition.Line).Distinct().Count());
var verifyTest = new Verify.Test
{
TestCode = test,
TestState = { MarkupHandling = MarkupMode.None },
};
verifyTest.ExpectedDiagnostics.AddRange(expected);
await verifyTest.RunAsync();
}
public async Task AnonymousTypeObjectCreationSyntax()
{
var test = @"
using System;
public class A {
public void B() {
var c = new { D = 5 };
}
internal void C() {
var c = new { D = 5 };
}
}
";
await Verify.VerifyAnalyzerAsync(test);
}
public async Task MissingInterfaceImplementationMember()
{
var test = @"
public interface A {
void Foo();
}
public class Parent : A {
// This class intentionally does not implement the interface
}
internal class Child : Parent {
public Child() { }
}
";
var expected = Verify.CompilerError("CS0535").WithLocation(6, 23).WithMessage("'Parent' does not implement interface member 'A.Foo()'");
await Verify.VerifyAnalyzerAsync(test, expected);
}
public async Task MissingInterfaceImplementationMember()
{
var test = @"
public interface A {
void Foo();
}
public class Parent : A {
// This class intentionally does not implement the interface
}
internal class Child : Parent {
public Child() { }
}
";
DiagnosticResult expected = Verify.CompilerError("CS0535").WithLocation(6, 23).WithArguments("Parent", "A.Foo()");
await Verify.VerifyAnalyzerAsync(test, expected);
}
public async Task UseOf_Delegate_DoesNotProduceWarnings()
{
var test = @"
using System;
using System.Threading.Tasks;
public class Test {
void PrivateFoo() {
Task<int> t = null;
var i = new Action(t.Wait);
}
public void PublicFoo() {
Task<int> t = null;
var i = new Action(t.Wait);
}
}
";
await Verify.VerifyAnalyzerAsync(test);
}
public async Task UseOf_XmlDocRefs_DoesNotProduceWarnings()
{
var test = @"
using System;
using System.Threading.Tasks;
public class Test {
/// <summary>Check out <see cref=""Task{int}.Result"" /></summary>
/// <remarks>Ya, <see cref=""Task<int>.Result"" /> is ... <see cref=""Task.Wait()"" />...</remarks>
void PrivateFoo() {
}
/// <summary>Check out <see cref=""Task{int}.Result"" /></summary>
/// <remarks>Ya, <see cref=""Task<int>.Result"" /> is ... <see cref=""Task.Wait()"" />...</remarks>
public void PublicFoo() {
}
}
";
await Verify.VerifyAnalyzerAsync(test);
}
public async Task MissingTypeObjectCreationSyntax()
{
var test = @"
using System;
public class A {
public void B() {
var c = new C();
}
internal void C() {
var c = new C();
}
}
";
DiagnosticResult[] expected =
{
Verify.CompilerError("CS0246").WithLocation(6, 21).WithMessage("The type or namespace name 'C' could not be found (are you missing a using directive or an assembly reference?)"),
Verify.CompilerError("CS0246").WithLocation(10, 21).WithMessage("The type or namespace name 'C' could not be found (are you missing a using directive or an assembly reference?)"),
};
await Verify.VerifyAnalyzerAsync(test, expected);
}
public async Task MissingTypeObjectCreationSyntax()
{
var test = @"
using System;
public class A {
public void B() {
var c = new C();
}
internal void C() {
var c = new C();
}
}
";
DiagnosticResult[] expected =
{
Verify.CompilerError("CS0246").WithLocation(6, 21).WithArguments("C"),
Verify.CompilerError("CS0246").WithLocation(10, 21).WithArguments("C"),
};
await Verify.VerifyAnalyzerAsync(test, expected);
}