/* goodG2B() - use goodsource and badsink */ private void GoodG2B() { int count = 0; /* FIX: Use a hardcoded number that won't cause underflow, overflow, divide by zero, or loss-of-precision issues */ count = 2; goodG2BPublicStatic = true; CWE400_Uncontrolled_Resource_Consumption__sleep_Connect_tcp_22b.GoodG2BSink(count); }
/* goodB2G1() - use badsource and goodsink by setting the static variable to false instead of true */ private void GoodB2G1() { int count = 0; count = int.MinValue; /* Initialize count */ /* Read data using an outbound tcp connection */ { try { String stringNumber = ""; /* Read data using an outbound tcp connection */ using (TcpClient tcpConn = new TcpClient("host.example.org", 39544)) { /* read input from socket */ using (StreamReader sr = new StreamReader(tcpConn.GetStream())) { /* POTENTIAL FLAW: Read count using an outbound tcp connection */ stringNumber = sr.ReadLine(); } } if (stringNumber != null) /* avoid NPD incidental warnings */ { try { count = int.Parse(stringNumber.Trim()); } catch (FormatException exceptNumberFormat) { IO.Logger.Log(NLog.LogLevel.Warn, exceptNumberFormat, "Number format exception parsing count from string"); } } } catch (IOException exceptIO) { IO.Logger.Log(NLog.LogLevel.Warn, exceptIO, "Error with stream reading"); } } goodB2G1PublicStatic = false; CWE400_Uncontrolled_Resource_Consumption__sleep_Connect_tcp_22b.GoodB2G1Sink(count); }