public void ValidArrayParameterModifierShouldProduceNoDiagnostics()
{
var obj = TestSyntaxFactory.CreateObject(new[]
{
TestSyntaxFactory.CreateProperty("default", TestSyntaxFactory.CreateArray(new []
{
TestSyntaxFactory.CreateArrayItem(TestSyntaxFactory.CreateBool(true))
})),
TestSyntaxFactory.CreateProperty("allowed", TestSyntaxFactory.CreateArray(new []
{
TestSyntaxFactory.CreateArrayItem(TestSyntaxFactory.CreateArray(Enumerable.Empty <ArrayItemSyntax>()))
})),
TestSyntaxFactory.CreateProperty("minLength", TestSyntaxFactory.CreateInt(33)),
TestSyntaxFactory.CreateProperty("maxLength", TestSyntaxFactory.CreateInt(25)),
TestSyntaxFactory.CreateProperty("metadata", TestSyntaxFactory.CreateObject(new[]
{
TestSyntaxFactory.CreateProperty("description", TestSyntaxFactory.CreateString("my description")),
TestSyntaxFactory.CreateProperty("extra1", TestSyntaxFactory.CreateString("extra")),
TestSyntaxFactory.CreateProperty("extra2", TestSyntaxFactory.CreateBool(true)),
TestSyntaxFactory.CreateProperty("extra3", TestSyntaxFactory.CreateInt(100))
}))
});
TypeValidator.GetExpressionAssignmentDiagnostics(CreateTypeManager(), obj, LanguageConstants.CreateParameterModifierType(LanguageConstants.Array)).Should().BeEmpty();
}
public void Variousobjects_ShouldProduceAnErrorWhenAssignedToString(string displayName, ObjectSyntax @object)
{
var errors = TypeValidator.GetExpressionAssignmentDiagnostics(CreateTypeManager(), @object, LanguageConstants.Int).ToList();
errors.Should().HaveCount(1);
errors.Single().Message.Should().Be("Expected a value of type int but the provided value is of type object.");
}
public void ValidStringParameterModifierShouldProduceNoDiagnostics()
{
var obj = TestSyntaxFactory.CreateObject(new[]
{
TestSyntaxFactory.CreateProperty("secure", TestSyntaxFactory.CreateBool(false)),
TestSyntaxFactory.CreateProperty("default", TestSyntaxFactory.CreateString("One")),
TestSyntaxFactory.CreateProperty("allowed", TestSyntaxFactory.CreateArray(new []
{
TestSyntaxFactory.CreateArrayItem(TestSyntaxFactory.CreateString("One")),
TestSyntaxFactory.CreateArrayItem(TestSyntaxFactory.CreateString("Two")),
})),
TestSyntaxFactory.CreateProperty("minLength", TestSyntaxFactory.CreateInt(33)),
TestSyntaxFactory.CreateProperty("maxLength", TestSyntaxFactory.CreateInt(25)),
TestSyntaxFactory.CreateProperty("metadata", TestSyntaxFactory.CreateObject(new[]
{
TestSyntaxFactory.CreateProperty("description", TestSyntaxFactory.CreateString("my description")),
TestSyntaxFactory.CreateProperty("extra1", TestSyntaxFactory.CreateString("extra")),
TestSyntaxFactory.CreateProperty("extra2", TestSyntaxFactory.CreateBool(true)),
TestSyntaxFactory.CreateProperty("extra3", TestSyntaxFactory.CreateInt(100))
}))
});
var allowedValuesType = UnionType.Create(new StringLiteralType("One"), new StringLiteralType("Two"));
TypeValidator.GetExpressionAssignmentDiagnostics(CreateTypeManager(), obj, LanguageConstants.CreateParameterModifierType(LanguageConstants.String, allowedValuesType)).Should().BeEmpty();
}
public void MinimalResourceShouldBeValid()
{
var obj = TestSyntaxFactory.CreateObject(new[]
{
TestSyntaxFactory.CreateProperty("name", TestSyntaxFactory.CreateString("test"))
});
TypeValidator.GetExpressionAssignmentDiagnostics(CreateTypeManager(), obj, CreateDummyResourceType()).Should().BeEmpty();
}
public void RequiredPropertyShouldBeRequired()
{
var obj = TestSyntaxFactory.CreateObject(new ObjectPropertySyntax[0]);
var errors = TypeValidator.GetExpressionAssignmentDiagnostics(CreateTypeManager(), obj, CreateDummyResourceType()).ToList();
errors.Should().HaveCount(1);
errors.Single().Message.Should().Be("The specified object is missing the following required properties: name.");
}
public void RequiredPropertyWithParseErrorsShouldProduceNoErrors()
{
var obj = TestSyntaxFactory.CreateObject(new []
{
TestSyntaxFactory.CreateProperty("dupe", TestSyntaxFactory.CreateString("a")),
TestSyntaxFactory.CreateProperty("dupe", TestSyntaxFactory.CreateString("a"))
});
TypeValidator.GetExpressionAssignmentDiagnostics(CreateTypeManager(), obj, CreateDummyResourceType()).Should().BeEmpty();
}
public void WrongTypeOfAdditionalPropertiesWithParseErrorsShouldProduceNoErrors()
{
var obj = TestSyntaxFactory.CreateObject(new[]
{
TestSyntaxFactory.CreateProperty("name", TestSyntaxFactory.CreateString("test")),
TestSyntaxFactory.CreateProperty("tags", TestSyntaxFactory.CreateObject(new[]
{
TestSyntaxFactory.CreateProperty("wrongTagType", TestSyntaxFactory.CreateBool(true)),
TestSyntaxFactory.CreateProperty("wrongTagType", TestSyntaxFactory.CreateInt(3))
}))
});
TypeValidator.GetExpressionAssignmentDiagnostics(CreateTypeManager(), obj, CreateDummyResourceType()).Should().BeEmpty();
}
public void ResourceWithValidZonesShouldBeAccepted()
{
var obj = TestSyntaxFactory.CreateObject(new[]
{
TestSyntaxFactory.CreateProperty("name", TestSyntaxFactory.CreateString("test")),
TestSyntaxFactory.CreateProperty("zones", TestSyntaxFactory.CreateArray(new []
{
TestSyntaxFactory.CreateArrayItem(TestSyntaxFactory.CreateString("1")),
TestSyntaxFactory.CreateArrayItem(TestSyntaxFactory.CreateString("2"))
}))
});
TypeValidator.GetExpressionAssignmentDiagnostics(CreateTypeManager(), obj, CreateDummyResourceType()).Should().BeEmpty();
}
public void ParameterModifierShouldRejectAdditionalProperties()
{
var obj = TestSyntaxFactory.CreateObject(new []
{
TestSyntaxFactory.CreateProperty("extra", TestSyntaxFactory.CreateString("foo")),
TestSyntaxFactory.CreateProperty("extra2", TestSyntaxFactory.CreateString("foo"))
});
TypeValidator.GetExpressionAssignmentDiagnostics(CreateTypeManager(), obj, LanguageConstants.CreateParameterModifierType(LanguageConstants.String))
.Select(e => e.Message)
.Should()
.Equal(
"The property 'extra' is not allowed on objects of type ParameterModifier_string.",
"The property 'extra2' is not allowed on objects of type ParameterModifier_string.");
}
public void ParameterModifierShouldRejectAdditionalProperties()
{
var obj = TestSyntaxFactory.CreateObject(new []
{
TestSyntaxFactory.CreateProperty("extra", TestSyntaxFactory.CreateString("foo")),
TestSyntaxFactory.CreateProperty("extra2", TestSyntaxFactory.CreateString("foo"))
});
TypeValidator.GetExpressionAssignmentDiagnostics(CreateTypeManager(), obj, LanguageConstants.CreateParameterModifierType(LanguageConstants.String, LanguageConstants.String))
.Select(e => e.Message)
.Should()
.Equal(
"The property 'extra' is not allowed on objects of type ParameterModifier<string>. Permissible properties include 'allowed', 'default', 'maxLength', 'metadata', 'minLength', 'secure'.",
"The property 'extra2' is not allowed on objects of type ParameterModifier<string>. Permissible properties include 'allowed', 'default', 'maxLength', 'metadata', 'minLength', 'secure'.");
}
public override IEnumerable <ErrorDiagnostic> GetDiagnostics()
{
var diagnostics = this.ValidateIdentifierAccess();
switch (this.Modifier)
{
case ParameterDefaultValueSyntax defaultValueSyntax:
diagnostics = diagnostics.Concat(ValidateDefaultValue(defaultValueSyntax));
break;
case ObjectSyntax modifierSyntax when this.Type.TypeKind != TypeKind.Error:
diagnostics = diagnostics.Concat(TypeValidator.GetExpressionAssignmentDiagnostics(this.Context.TypeManager, modifierSyntax, LanguageConstants.CreateParameterModifierType(this.Type)));
break;
}
return(diagnostics);
}
public void CompletelyInvalidBoolParameterModifier_ShouldLogExpectedErrors()
{
var obj = TestSyntaxFactory.CreateObject(new[]
{
// not a bool and not allowed
TestSyntaxFactory.CreateProperty("secure", TestSyntaxFactory.CreateInt(1)),
// default value of wrong type
TestSyntaxFactory.CreateProperty("default", TestSyntaxFactory.CreateInt(1231)),
// not an array
TestSyntaxFactory.CreateProperty("allowed", TestSyntaxFactory.CreateArray(new []
{
TestSyntaxFactory.CreateArrayItem(TestSyntaxFactory.CreateInt(22))
})),
// not allowed
TestSyntaxFactory.CreateProperty("minValue", TestSyntaxFactory.CreateBool(true)),
TestSyntaxFactory.CreateProperty("maxValue", TestSyntaxFactory.CreateString("11")),
TestSyntaxFactory.CreateProperty("minLength", TestSyntaxFactory.CreateObject(new ObjectPropertySyntax[0])),
TestSyntaxFactory.CreateProperty("maxLength", TestSyntaxFactory.CreateBool(false)),
// extra property
TestSyntaxFactory.CreateProperty("extra", TestSyntaxFactory.CreateBool(false)),
TestSyntaxFactory.CreateProperty("metadata", TestSyntaxFactory.CreateObject(new[]
{
// wrong type of description
TestSyntaxFactory.CreateProperty("description", TestSyntaxFactory.CreateInt(155))
}))
});
TypeValidator.GetExpressionAssignmentDiagnostics(CreateTypeManager(), obj, LanguageConstants.CreateParameterModifierType(LanguageConstants.Bool))
.Select(d => d.Message)
.Should().BeEquivalentTo(
"The property 'default' expected a value of type bool but the provided value is of type int.",
"The enclosing array expected an item of type bool, but the provided item was of type int.",
"The property 'description' expected a value of type string but the provided value is of type int.",
"The property 'secure' is not allowed on objects of type ParameterModifier_bool.",
"The property 'minValue' is not allowed on objects of type ParameterModifier_bool.",
"The property 'maxValue' is not allowed on objects of type ParameterModifier_bool.",
"The property 'minLength' is not allowed on objects of type ParameterModifier_bool.",
"The property 'maxLength' is not allowed on objects of type ParameterModifier_bool.",
"The property 'extra' is not allowed on objects of type ParameterModifier_bool.");
}
public void CompletelyInvalidArrayParameterModifier_ShouldLogExpectedErrors()
{
var obj = TestSyntaxFactory.CreateObject(new[]
{
// not a bool
TestSyntaxFactory.CreateProperty("secure", TestSyntaxFactory.CreateInt(1)),
// default value of wrong type
TestSyntaxFactory.CreateProperty("default", TestSyntaxFactory.CreateBool(true)),
// not an array
TestSyntaxFactory.CreateProperty("allowed", TestSyntaxFactory.CreateObject(new ObjectPropertySyntax[0])),
// not ints
TestSyntaxFactory.CreateProperty("minValue", TestSyntaxFactory.CreateBool(true)),
TestSyntaxFactory.CreateProperty("maxValue", TestSyntaxFactory.CreateString("11")),
TestSyntaxFactory.CreateProperty("minLength", TestSyntaxFactory.CreateObject(new ObjectPropertySyntax[0])),
TestSyntaxFactory.CreateProperty("maxLength", TestSyntaxFactory.CreateBool(false)),
// extra property
TestSyntaxFactory.CreateProperty("extra", TestSyntaxFactory.CreateBool(false)),
TestSyntaxFactory.CreateProperty("metadata", TestSyntaxFactory.CreateObject(new[]
{
// wrong type of description
TestSyntaxFactory.CreateProperty("description", TestSyntaxFactory.CreateInt(155))
}))
});
TypeValidator.GetExpressionAssignmentDiagnostics(CreateTypeManager(), obj, LanguageConstants.CreateParameterModifierType(LanguageConstants.Array))
.Select(d => d.Message)
.Should()
.BeEquivalentTo(
"The property 'default' expected a value of type 'array' but the provided value is of type 'bool'.",
"The property 'maxLength' expected a value of type 'int' but the provided value is of type 'bool'.",
"The property 'allowed' expected a value of type 'array[]' but the provided value is of type 'object'.",
"The property 'minLength' expected a value of type 'int' but the provided value is of type 'object'.",
"The property 'description' expected a value of type 'string' but the provided value is of type 'int'.",
"The property 'secure' is not allowed on objects of type 'ParameterModifier_array'.",
"The property 'minValue' is not allowed on objects of type 'ParameterModifier_array'.",
"The property 'maxValue' is not allowed on objects of type 'ParameterModifier_array'.",
"The property 'extra' is not allowed on objects of type 'ParameterModifier_array'.");
}
public void Valid_parameter_modifier_should_ensure_default_value_is_assignable_to_allowed_values()
{
var obj = TestSyntaxFactory.CreateObject(new[]
{
TestSyntaxFactory.CreateProperty("default", TestSyntaxFactory.CreateString("Three")),
TestSyntaxFactory.CreateProperty("allowed", TestSyntaxFactory.CreateArray(new []
{
TestSyntaxFactory.CreateArrayItem(TestSyntaxFactory.CreateString("One")),
TestSyntaxFactory.CreateArrayItem(TestSyntaxFactory.CreateString("Two")),
})),
});
var allowedValuesType = UnionType.Create(new StringLiteralType("One"), new StringLiteralType("Two"));
TypeValidator.GetExpressionAssignmentDiagnostics(CreateTypeManager(), obj, LanguageConstants.CreateParameterModifierType(LanguageConstants.String, allowedValuesType))
.Should().SatisfyRespectively(
x => x.Message.Should().Be("The property 'default' expected a value of type 'One' | 'Two' but the provided value is of type 'Three'."));
}
public void WrongTypeOfAdditionalPropertiesShouldBeRejected()
{
var obj = TestSyntaxFactory.CreateObject(new[]
{
TestSyntaxFactory.CreateProperty("name", TestSyntaxFactory.CreateString("test")),
TestSyntaxFactory.CreateProperty("tags", TestSyntaxFactory.CreateObject(new[]
{
TestSyntaxFactory.CreateProperty("wrongTagType", TestSyntaxFactory.CreateBool(true)),
TestSyntaxFactory.CreateProperty("wrongTagType2", TestSyntaxFactory.CreateInt(3))
}))
});
TypeValidator.GetExpressionAssignmentDiagnostics(CreateTypeManager(), obj, CreateDummyResourceType())
.Select(d => d.Message)
.Should()
.BeEquivalentTo(
"The property 'wrongTagType' expected a value of type string but the provided value is of type bool.",
"The property 'wrongTagType2' expected a value of type string but the provided value is of type int.");
}
public void InvalidArrayValuesShouldBeRejected()
{
var obj = TestSyntaxFactory.CreateObject(new[]
{
TestSyntaxFactory.CreateProperty("name", TestSyntaxFactory.CreateString("test")),
// zones is an array of strings - set wrong item types
TestSyntaxFactory.CreateProperty("zones", TestSyntaxFactory.CreateArray(new[]
{
TestSyntaxFactory.CreateArrayItem(TestSyntaxFactory.CreateBool(true)),
TestSyntaxFactory.CreateArrayItem(TestSyntaxFactory.CreateInt(2))
})),
// this property is an array - specify a string instead
TestSyntaxFactory.CreateProperty("managedByExtended", TestSyntaxFactory.CreateString("not an array"))
});
TypeValidator.GetExpressionAssignmentDiagnostics(CreateTypeManager(), obj, CreateDummyResourceType())
.Select(d => d.Message)
.Should().BeEquivalentTo(
"The enclosing array expected an item of type string, but the provided item was of type bool.",
"The property 'managedByExtended' expected a value of type string[] but the provided value is of type 'not an array'.",
"The enclosing array expected an item of type string, but the provided item was of type int.");
}
public void DiscriminatedObjectType_raises_appropriate_diagnostics_for_matches()
{
var discriminatedType = new DiscriminatedObjectType(
"discObj",
"myDiscriminator",
new []
{
new NamedObjectType("typeA", new []
{
new TypeProperty("myDiscriminator", new StringLiteralType("valA")),
new TypeProperty("fieldA", LanguageConstants.Any, TypePropertyFlags.Required),
}, null),
new NamedObjectType("typeB", new []
{
new TypeProperty("myDiscriminator", new StringLiteralType("valB")),
new TypeProperty("fieldB", LanguageConstants.Any, TypePropertyFlags.Required),
}, null),
});
// no discriminator field supplied
var obj = TestSyntaxFactory.CreateObject(new []
{
TestSyntaxFactory.CreateProperty("fieldA", TestSyntaxFactory.CreateString("someVal")),
});
var errors = TypeValidator.GetExpressionAssignmentDiagnostics(CreateTypeManager(), obj, discriminatedType);
errors.Should().SatisfyRespectively(
x => {
x.Message.Should().Be("The property 'myDiscriminator' requires a value of type 'valA' | 'valB', but none was supplied.");
});
// incorrect type specified for the discriminator field
obj = TestSyntaxFactory.CreateObject(new []
{
TestSyntaxFactory.CreateProperty("myDiscriminator", TestSyntaxFactory.CreateObject(Enumerable.Empty <ObjectPropertySyntax>())),
TestSyntaxFactory.CreateProperty("fieldB", TestSyntaxFactory.CreateString("someVal")),
});
errors = TypeValidator.GetExpressionAssignmentDiagnostics(CreateTypeManager(), obj, discriminatedType);
errors.Should().SatisfyRespectively(
x => {
x.Message.Should().Be("The property 'myDiscriminator' expected a value of type 'valA' | 'valB' but the provided value is of type object.");
});
// discriminator value that matches neither option supplied
obj = TestSyntaxFactory.CreateObject(new []
{
TestSyntaxFactory.CreateProperty("myDiscriminator", TestSyntaxFactory.CreateString("valC")),
});
errors = TypeValidator.GetExpressionAssignmentDiagnostics(CreateTypeManager(), obj, discriminatedType);
errors.Should().SatisfyRespectively(
x => {
x.Message.Should().Be("The property 'myDiscriminator' expected a value of type 'valA' | 'valB' but the provided value is of type 'valC'.");
});
// missing required property for the 'valB' branch
obj = TestSyntaxFactory.CreateObject(new []
{
TestSyntaxFactory.CreateProperty("myDiscriminator", TestSyntaxFactory.CreateString("valB")),
});
errors = TypeValidator.GetExpressionAssignmentDiagnostics(CreateTypeManager(), obj, discriminatedType);
errors.Should().SatisfyRespectively(
x => {
x.Message.Should().Be("The specified object is missing the following required properties: fieldB.");
});
// supplied the required property for the 'valB' branch
obj = TestSyntaxFactory.CreateObject(new []
{
TestSyntaxFactory.CreateProperty("myDiscriminator", TestSyntaxFactory.CreateString("valB")),
TestSyntaxFactory.CreateProperty("fieldB", TestSyntaxFactory.CreateString("someVal")),
});
errors = TypeValidator.GetExpressionAssignmentDiagnostics(CreateTypeManager(), obj, discriminatedType);
errors.Should().BeEmpty();
}
public override IEnumerable <ErrorDiagnostic> GetDiagnostics()
{
return(TypeValidator.GetExpressionAssignmentDiagnostics(this.Context.TypeManager, this.Body, this.Type));
}
public void VariousObjects_ShouldProduceNoDiagnosticsWhenAssignedToObjectType(string displayName, ObjectSyntax @object)
{
TypeValidator.GetExpressionAssignmentDiagnostics(CreateTypeManager(), @object, LanguageConstants.Object).Should().BeEmpty();
}
public void EmptyModifierIsValid()
{
var obj = TestSyntaxFactory.CreateObject(new ObjectPropertySyntax[0]);
TypeValidator.GetExpressionAssignmentDiagnostics(CreateTypeManager(), obj, LanguageConstants.CreateParameterModifierType(LanguageConstants.Int)).Should().BeEmpty();
}
