public override void Bad() { data = long.MinValue; /* Initialize data */ /* Read data from a database */ { SqlConnection connection = null; SqlDataReader dr = null; try { /* setup the connection */ using (connection = IO.GetDBConnection()) { connection.Open(); /* prepare and execute a (hardcoded) query */ SqlCommand command = new SqlCommand(null, connection); command.CommandText = "select name from users where id=0"; command.Prepare(); dr = command.ExecuteReader(); /* FLAW: Read data from a database query SqlDataReader */ string stringNumber = dr.GetString(1); if (stringNumber != null) /* avoid NPD incidental warnings */ { try { data = long.Parse(stringNumber.Trim()); } catch (FormatException exceptNumberFormat) { IO.Logger.Log(NLog.LogLevel.Warn, exceptNumberFormat, "Number format exception parsing data from string"); } } } } catch (SqlException exceptSql) { IO.Logger.Log(NLog.LogLevel.Warn, exceptSql, "Error with SQL statement"); } finally { /* Close database objects */ try { if (dr != null) { dr.Close(); } } catch (Exception except) /* INCIDENTAL: CWE 396 Catch Generic Exception */ { IO.Logger.Log(NLog.LogLevel.Warn, except, "Error closing SqlDataReader"); } try { if (connection != null) { connection.Close(); } } catch (SqlException exceptSql) { IO.Logger.Log(NLog.LogLevel.Warn, exceptSql, "Error closing Connection"); } } } CWE197_Numeric_Truncation_Error__long_database_to_int_68b.BadSink(); }
/* goodG2B() - use goodsource and badsink */ private static void GoodG2B() { /* FIX: Use a hardcoded number that won't cause underflow, overflow, divide by zero, or loss-of-precision issues */ data = 2; CWE197_Numeric_Truncation_Error__long_database_to_int_68b.GoodG2BSink(); }