public override void Bad() { float data; data = float.MinValue; /* Initialize data */ { /* read user input from console with ReadLine */ try { /* FLAW: Read data from the console using ReadLine */ string stringNumber = Console.ReadLine(); if (stringNumber != null) // avoid NPD incidental warnings { try { data = float.Parse(stringNumber.Trim()); } catch (FormatException exceptNumberFormat) { IO.Logger.Log(NLog.LogLevel.Warn, exceptNumberFormat, "Number format exception parsing data from string"); } } } catch (IOException exceptIO) { IO.Logger.Log(NLog.LogLevel.Warn, exceptIO, "Error with stream reading"); } } float[] dataArray = new float[5]; dataArray[2] = data; CWE197_Numeric_Truncation_Error__float_console_ReadLine_to_short_66b.BadSink(dataArray); }
/* goodG2B() - use goodsource and badsink */ private static void GoodG2B() { float data; /* FIX: Use a hardcoded number that won't cause underflow, overflow, divide by zero, or loss-of-precision issues */ data = 2; float[] dataArray = new float[5]; dataArray[2] = data; CWE197_Numeric_Truncation_Error__float_console_ReadLine_to_short_66b.GoodG2BSink(dataArray); }